Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4678833ybi; Mon, 3 Jun 2019 15:23:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqz5Eajd2Fh1RLEkLuIig1fdKUafDGBm+D30kPlPXF+u5gPUiDZjVk1WjWEX6uANoD6T97yv X-Received: by 2002:a63:de4b:: with SMTP id y11mr28549618pgi.301.1559600625194; Mon, 03 Jun 2019 15:23:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559600625; cv=none; d=google.com; s=arc-20160816; b=zL/apvNpNcHp9Ut6ZzrPc7rxAbllS2SV4+x/oBk6vls4c+4xEX9gA1aA1C69PxtuW4 FJmw4CA1PFY86p3l35PV/ffOtUn3l4Z6fA9+1Q0y3gQ6uPcXPpaqsLN+6oQjl3NhZnFs yW1IdIhbuAHQVdN5TZrYwChiSNDV/t8XLCNHueR3eOkN7nNQZN/cflsj/Q8H66UI/9+a SY65cW8SmBZlqZY6XsmqEK0/Et8UwKEKmZr5oemzYb8ViQ435S8O8v2eJQpyXrFILfAa 61XzW1kW+q+GjQ/Zx/5jN61IGiurmnx53QrDY0B/ulehJYc8CANQN2UmistTYrCzD0my maLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6SwsUdnmJqsKjqmMv1ig0nFgLQISlIZ4mL0Bgh3d+ww=; b=Vi9hX+vV0TXG+d57Crtt2gRg/SbC85eP06552bl7X2OraK8dXSmr2dOx9WI++80PVX qKIkfeFlLd7uF/fKE0dYVQaRPdqXbtK9030C8Dbg8adPoWisvJtviv90EnZCx+uF8qrP Xrt1c46pM3MA42V9huq64kJ30irqh/r62R4CwcMKNwQlZ2OX1TfkbIJUcwotY9mYIeNN ZM7bjlCyqtp7xg65lGMDhDNOpTnve2gnPk7Za7/dq/KOG0NpvftLdg+iYs8VJyK63svE PcoINVzNx7Ake5NfBpW82pyo0WcJniEu7FS74VOdq1HPhkCIS+zYAHKQ8fvhwmPENg5H 1OeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rHbA+7oj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s12si20235074pgp.572.2019.06.03.15.23.29; Mon, 03 Jun 2019 15:23:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rHbA+7oj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726658AbfFCWU7 (ORCPT + 99 others); Mon, 3 Jun 2019 18:20:59 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:42556 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfFCWU7 (ORCPT ); Mon, 3 Jun 2019 18:20:59 -0400 Received: by mail-ed1-f68.google.com with SMTP id z25so2965139edq.9; Mon, 03 Jun 2019 15:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6SwsUdnmJqsKjqmMv1ig0nFgLQISlIZ4mL0Bgh3d+ww=; b=rHbA+7ojNx2L8Y/O1X17tjfQ/ccJkMcflnR9LyPSByMs/+CaDM7588Ir9t9RCF6Tin lNZZwQ9Gf0eaxcIBJmjzcKt2W/7xPDdtLNk3lqUkdPFDIqLQfWYVNK1FRCS6m8izMj8o CR8zKd+dzcYJmoPDewqMUtr0ZbSeKyM9zcbLqCVtcX+d99RD0IWoF/R+GdWe40Jb+ghp 5EOciicMprv68Ht7k4mZyACACMbu85DqHslBZ5G3Oo68aNWaOSqAEOq69+ZZj5//eY+r LpdPgsxdma7p37jEdVF6X/XXb3au94zh2bUhNBDUHRdrMUmk0e4c3GsyikXDu4Bjt3eQ PDww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6SwsUdnmJqsKjqmMv1ig0nFgLQISlIZ4mL0Bgh3d+ww=; b=j3eIMRCrgDkGoAWQ8zUldsnwj55+6HcRqmJO5zs5ipr8avXK5OFFMd7uqodoooVE/Y Sq7ik0zpx+XuWAdAEDxvp+AdA46jaL0GBXvjqDxCKVtfrrV/FfcxYETnO/CHFN1qCwKC U394R4M5AGMo2iqtQYiwL2p2uaiJ1yAOVPqpqwS548+s5djDGELvGA3H1BdPWNBj72HD Wh76v71yG6O+vutQvTIECvFZkZVKgAivtVG0xNU1bh/dLJlPz/gxQjHZnWUM69rWpSJg fbfFhQMkKj3I4u5VPCACFPoaNnBFpkpEmL3OiCC6EGlDDiehmYY8QBMKNAuQHeZSuqWm /N2g== X-Gm-Message-State: APjAAAWM00YO1Y0WYy6B/WocBB35GiJRjYtkYFhsgwrmo/ZhSTlyrPVS pyTmr2HZ74nAnCQwSG83lLg= X-Received: by 2002:a50:a4f7:: with SMTP id x52mr31464852edb.86.1559600457550; Mon, 03 Jun 2019 15:20:57 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f9:2b:2b15::2]) by smtp.gmail.com with ESMTPSA id j9sm1515579ejm.68.2019.06.03.15.20.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 15:20:56 -0700 (PDT) From: Nathan Chancellor To: Tyrel Datwyler , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Michael Ellerman Subject: [PATCH v2] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work Date: Mon, 3 Jun 2019 15:19:42 -0700 Message-Id: <20190603221941.65432-1-natechancellor@gmail.com> X-Mailer: git-send-email 2.22.0.rc3 In-Reply-To: <20190531185306.41290-1-natechancellor@gmail.com> References: <20190531185306.41290-1-natechancellor@gmail.com> MIME-Version: 1.0 X-Patchwork-Bot: notify Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clang warns: drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case IBMVSCSI_HOST_ACTION_NONE: ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/ibmvscsi/ibmvscsi.c:2151:6: note: uninitialized use occurs here if (rc) { ^~ Initialize rc to zero in the case statements that clang mentions so that the atomic_set and dev_err statement don't trigger for them. Fixes: 035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states") Link: https://github.com/ClangBuiltLinux/linux/issues/502 Suggested-by: Michael Ellerman Signed-off-by: Nathan Chancellor --- v1 -> v2: * Initialize rc in the case statements, rather than at the top of the function, as suggested by Michael. drivers/scsi/ibmvscsi/ibmvscsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index 65053daef5f7..3b5647d622d9 100644 --- a/drivers/scsi/ibmvscsi/ibmvscsi.c +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c @@ -2109,9 +2109,6 @@ static void ibmvscsi_do_work(struct ibmvscsi_host_data *hostdata) spin_lock_irqsave(hostdata->host->host_lock, flags); switch (hostdata->action) { - case IBMVSCSI_HOST_ACTION_NONE: - case IBMVSCSI_HOST_ACTION_UNBLOCK: - break; case IBMVSCSI_HOST_ACTION_RESET: spin_unlock_irqrestore(hostdata->host->host_lock, flags); rc = ibmvscsi_reset_crq_queue(&hostdata->queue, hostdata); @@ -2128,7 +2125,10 @@ static void ibmvscsi_do_work(struct ibmvscsi_host_data *hostdata) if (!rc) rc = ibmvscsi_send_crq(hostdata, 0xC001000000000000LL, 0); break; + case IBMVSCSI_HOST_ACTION_NONE: + case IBMVSCSI_HOST_ACTION_UNBLOCK: default: + rc = 0; break; } -- 2.22.0.rc3