Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4755186ybi; Mon, 3 Jun 2019 17:06:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqyg+VCYK1Lb7pLN3aVD7nG9gpx9C0CHqMp3bH4fFELD++hie2A3eMyyU3VPRw8N3r47/cE5 X-Received: by 2002:a65:42cd:: with SMTP id l13mr1939046pgp.72.1559606818466; Mon, 03 Jun 2019 17:06:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559606818; cv=none; d=google.com; s=arc-20160816; b=oDn3+rsEVPRo2kRYyggi2J+jiZETS+/uhM/tbzea5Mt1lXdd94ae84myHqW4+nitJL Vjw6geLxHVf9T5OcpJX1AHO0pBKNbNRdwO38k6FpC6i1GIRjFu/DBbXc+iTzx1QNabKZ IivfNSdfuU+FwN5StHtvU6S8JqxfSZ2QXXziXMR0xXxK2f7Tze8IvYtIZCHY8UZGB1b/ veO1cvZOHskRWH9XAfW3H/AOFjtPqBoQLRsiV1TIEQbvwOcpBkHRhUbn+JSdGnutzbhL Tdj4xSl2jYp9zcYz2COC0ZGFe/lrT7rkMVJXM6m4hUfc4ODxzT19Ez4QPomUbbj5mHzO K7qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date; bh=dcPQQBWbZ/wTq87WGXx66x5tzICa6yAfgY1u/hRtVXU=; b=Vc4SoYXXZaZppYrM6empL5It2p1tK0qJ0XluH5Bhhuus31uN6p8uaP5PUIuup1pHwO Y7hEJNUUQh2ocNzIAXuOIyLPCd0ZfARJPcpFwLec1TRxnNVvti6ryvHfwpVqcbNpfLPm hjg/UE8nXVgRo0Nx1/SEnt22c0X1iIkBiAPDKuk7rJ/2UFNXbiJMc73L86P5hy95n+OT xXb9dt0hduYPABeljwSojKg5LSrL4NEYejCE7XEAqEOhxcEkA5UpW2n20+6TFqkZcU6H yYabMsB9RL44xCDc3VFUbFbBL5CwedKYyzqht83sT18vSLX3EjyMHkb/ZTbq8rBxD3+b LnwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q3si20264435pgc.116.2019.06.03.17.06.41; Mon, 03 Jun 2019 17:06:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726406AbfFDAFg (ORCPT + 99 others); Mon, 3 Jun 2019 20:05:36 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:42236 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfFDAFg (ORCPT ); Mon, 3 Jun 2019 20:05:36 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id 885D327E27; Mon, 3 Jun 2019 20:05:33 -0400 (EDT) Date: Tue, 4 Jun 2019 10:05:44 +1000 (AEST) From: Finn Thain To: Michael Schmitz cc: Geert Uytterhoeven , "James E.J. Bottomley" , "Martin K. Petersen" , scsi , Linux Kernel Mailing List , stable , linux-m68k Subject: Re: [PATCH 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2 In-Reply-To: <247ed79a-75c7-41fd-0932-0b7701ee5d4e@gmail.com> Message-ID: References: <247ed79a-75c7-41fd-0932-0b7701ee5d4e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Jun 2019, Michael Schmitz wrote: > Hi Finn, > > On 3/06/19 7:40 PM, Finn Thain wrote: > > > > > There are several other drivers that contain pieces of assembler code. > > > > > Does any driver contain assembler code for multiple architectures? I was > > trying to avoid that -- though admittedly I don't yet have actual code for > > the PDMA implementation for mac_scsi for Nubus PowerMacs. > > > I've seen that once, for one of the ESP drivers that were supported on both > m68k and ppc (APUS, PPC upgrade to Amiga computers). But that driver was > removed long ago (after 2.6?). > > In that case, the assembly file did reside in drivers/scsi/. That still > appears to be current practice (see drivers/scsi/arm/acornscsi-io.S). > The presence of that file would be an argument for adding drivers/scsi/m68k/. This seems to be begging the question. Since there's no clear policy, I'll combine the two files and avoid the question for now. -- > Cheers, > > ??? Michael > > >