Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4944828ybi; Mon, 3 Jun 2019 21:27:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqy6PjhVc1OTxtquTCsofZ0tceCOI1jLeq9dHywOMJM2EjfKXAbtVa+adFuMtGv2kNI/2bMC X-Received: by 2002:a63:5e42:: with SMTP id s63mr33149350pgb.234.1559622457503; Mon, 03 Jun 2019 21:27:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559622457; cv=none; d=google.com; s=arc-20160816; b=lmRDc84Zxar3k2JA1rbGFu0297KrMt21tctwk8dAa46omLjPPb81aU4lK4EEGLpYsQ p4/grFDuEPkaBsS1g9oLAQjNIoisQCO+VJa5CVVJTJ89xqH15LCs/Jid2AEBI/s0zZmx 4ixWIMwIhs7frKkumHI1EI5TMvIMKEbd6opEM2J90S/DKGOTsm/UGG/qa7Xv7qRAarrj p3sYnol1R01SQENXowDCMEEwSmWmM+WLwzpyB8BspGMLYzWv+FV4EX7PIlnUFcpuoS5g 6dgqTuMYCMrDf/ar+8p/nOXz4/sRtZWLf5OWeT347LDaKXhY/O6cjenQRL8eI41ZYtpa MjkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=JRko3NiVek+fFwIFN7wwZrw7E2QDpoIdWt11EOuKuDo=; b=JrRi8/F4GWtOO5Rp2IF+rstfV7eXtrq/zw123WfpFLtdvnxbUV3/0+oeliFzms1b+S XLMHZmCKKxoe1esP733Qj9NmjAvLMiZsv3GnvkI2q1OcfHkvl+GWlLFE+A31gaCajKMy vXnxFDk6y+GqY39xmymL3ZYughn6bJ+1apu4vIxi4pwObGFWgye32YoA4sM1KG79WOWB dYqyJKvxcG4tryUcv9an5bqOtlhLv0QgGdxNzIQX7tlk9+LIHD/y464hmn7gamgVx4mb 08OE7ZSM8/PKoQXKlP6InygUTgh1DU3vN/CDUIxseOqd3ROyqruHJuWYTdLOd/GIKz9h jjRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cam4pLTn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o32si524165pld.115.2019.06.03.21.27.21; Mon, 03 Jun 2019 21:27:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cam4pLTn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbfFDEX6 (ORCPT + 99 others); Tue, 4 Jun 2019 00:23:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:38478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbfFDEXr (ORCPT ); Tue, 4 Jun 2019 00:23:47 -0400 Received: from wens.tw (mirror2.csie.ntu.edu.tw [140.112.30.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C498D24CA4; Tue, 4 Jun 2019 04:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559622226; bh=gLtAailyS6IJm8z2V2PeInJ4Zh8RQw5AhexkL1edZlQ=; h=From:To:Cc:Subject:Date:From; b=Cam4pLTngHKbpei8gF74EopX7nX49t8VOukQeGIYWDwfJxCUpn/HHzpXC/6yv3Lbi mD9+WZgi6RoCqqxVoYLpJTJxAwCO6UQqV89tXiAwC6xD/1tDPHs0ghtyCHW8ha9Kzn ENTn73F6Rk+QP+lOB42/QBxsDkFAKrCPa5JpXW2A= Received: by wens.tw (Postfix, from userid 1000) id 6A0A35FCDF; Tue, 4 Jun 2019 12:23:43 +0800 (CST) From: Chen-Yu Tsai To: Maxime Ripard , Alessandro Zummo , Alexandre Belloni Cc: Chen-Yu Tsai , Vincent Donnefort , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/3] rtc: pcf8563: Fix unhandled interrupt storm Date: Tue, 4 Jun 2019 12:23:34 +0800 Message-Id: <20190604042337.26129-1-wens@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chen-Yu Tsai Hi everyone, While bringing up my Pine H64, I encountered an interrupt storm from the pcf8563 RTC. The RTC chip's interrupt line is shared with the PMIC, and was not properly added to the device tree. Also, the driver was using an trigger method incompatible with the PMIC, preventing the interrupt line from being shared. Last, the driver only clears and masks the alarm interrupt, while leaving the timer interrupt untouched. This is a problem if previous systems left the timer interrupt enabled, and there was an interrupt pending. This patch set fixes all three issues, one per patch. Please have a look. Chen-Yu Tsai (3): rtc: pcf8563: Fix interrupt trigger method rtc: pcf8563: Clear event flags and disable interrupts before requesting irq arm64: dts: allwinner: h6: Pine H64: Add interrupt line for RTC .../arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 ++ drivers/rtc/rtc-pcf8563.c | 13 ++++++------- 2 files changed, 8 insertions(+), 7 deletions(-) -- 2.20.1