Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5086474ybi; Tue, 4 Jun 2019 00:41:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqwWi4oNBUnypkAsu2Ybz6l1NqN3m0MAE6QAdLFONJgqgggX0bIyvPgB79ync+jZ08+yYVkG X-Received: by 2002:aa7:8b49:: with SMTP id i9mr8795595pfd.74.1559634091089; Tue, 04 Jun 2019 00:41:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559634091; cv=none; d=google.com; s=arc-20160816; b=1ABEyOyM2gRr8OWxEDhLmnCsVLzeD4Za8c16xTpWyfaLoYuCo/EWY7GaJHoSCHSmG5 OPeczmG+EAk1c/Fg+rsJpQ5mehdonRxZbAPIUg+oEj+6EFFtAbyZw9lNmb763+8GZmCj Bbka3fkBXbnf47IBU6JgXnR9fyNqpOIHpeIjPlztpcGfGknJolUi2iLV5Lp0uM2c9QhE 9XgPB1A6oeIzt/LcYOxME6N01ppN3yMySX0HRojcoyn1kflNEnMa3hFNxp0thgkxCrMl ALJ9gbYrtsSHNZXDmMbRUXuAfu6ZnQVG0hvA+6MOzOzIN6U3I4pZ/xm27bM0hAd4fmCy uMbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=CYZmXX0Qajsd2CJ4M9QVAkg8+0uFy5kGttoDqJVnpRg=; b=WUetTuY/hq2HNy2aZAo5qrFO44rWkQhcEBAK+dY5vzqO+3oKZnLuECfGzoxM9jnS3a 470AqGIX8eNZ+5MkZWhWMgY6nW3WAFL2MprH2Y5LlhTVteTAbJ6AgNx1rdjr78fuKfvL FJPKIbnIfw6GeREhiMBeHuhA/cWk0m7cFr29dk5qeuBABONZ6uOlKO0s4xruHCUabWqK mXvNE9C7ALaoeNg5UO35a7kYnKXQSKO5ZyPzZkIjEwyuU0ZERTQxiSCWhrdxu+Xu/09X eiKtPUA7l3l+lgmhfqABYAWxHRfkTuJarty7okzTx920aS7UZHs3fyzjskqORP//rKpw zq1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v97si8942763pjb.23.2019.06.04.00.41.14; Tue, 04 Jun 2019 00:41:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727027AbfFDHjH (ORCPT + 99 others); Tue, 4 Jun 2019 03:39:07 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:45248 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726792AbfFDHjH (ORCPT ); Tue, 4 Jun 2019 03:39:07 -0400 Received: by mail-ed1-f68.google.com with SMTP id f20so30560326edt.12 for ; Tue, 04 Jun 2019 00:39:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CYZmXX0Qajsd2CJ4M9QVAkg8+0uFy5kGttoDqJVnpRg=; b=iksKGf7/KT9+ZQtLoB6dvKmG0mw5TUxzpjdG5S6iMzcjZUlaqdcmAzOvbxmceMoZRl OqDMgOfKWKwFjqUIOvbBZCUJTM03BAQjkrEOn80Q8DS0rPPopEoggSLmKfif3zmqO792 rUu020k1Lr+wBoFjIzvZ43ycQ5pTCoMmRrNZPUzeZYyW8OOYuFiLEh5sX968pYydLJ+v ZYeyxF4W4Qed+UrKRgVopOGLSW4fJQEOuM9v90+jaJOVsN4t++n/DHp1wPwpCJvmataC pbKfWoiATSG3vups8V7NxQcrzTrcXQ6X3qgr8rFQs+QdIkZrBG1W5TlkVtllI2MKkN0B CFFQ== X-Gm-Message-State: APjAAAUOOoSONtDNtkTmdV06GTP+RR5LcbVrXb0zbk8xD8I1JEhqrIEJ LVlaivH7KUZXx11uBo9ROD6z0lJZUmk= X-Received: by 2002:a17:906:606:: with SMTP id s6mr28632594ejb.192.1559633945279; Tue, 04 Jun 2019 00:39:05 -0700 (PDT) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com. [209.85.128.51]) by smtp.gmail.com with ESMTPSA id a19sm2330179ejb.22.2019.06.04.00.39.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 00:39:04 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id 16so9269126wmg.5 for ; Tue, 04 Jun 2019 00:39:04 -0700 (PDT) X-Received: by 2002:a7b:c344:: with SMTP id l4mr16737404wmj.25.1559633944348; Tue, 04 Jun 2019 00:39:04 -0700 (PDT) MIME-Version: 1.0 References: <20190603174735.21002-1-codekipper@gmail.com> <20190603174735.21002-2-codekipper@gmail.com> <20190604073443.cnnqd7ucbaehxdvj@flea> In-Reply-To: <20190604073443.cnnqd7ucbaehxdvj@flea> From: Chen-Yu Tsai Date: Tue, 4 Jun 2019 15:38:53 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] Re: [PATCH v4 1/9] ASoC: sun4i-i2s: Fix sun8i tx channel offset mask To: Maxime Ripard , Code Kipper Cc: linux-sunxi , linux-arm-kernel , Liam Girdwood , Mark Brown , linux-kernel , Linux-ALSA , "Andrea Venturi (pers)" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 4, 2019 at 3:34 PM Maxime Ripard wrote: > > On Mon, Jun 03, 2019 at 07:47:27PM +0200, codekipper@gmail.com wrote: > > From: Marcus Cooper > > > > Although not causing any noticeable issues, the mask for the > > channel offset is covering too many bits. > > > > Signed-off-by: Marcus Cooper > > Acked-by: Maxime Ripard Would be nice to have Fixes: 7d2993811a1e ("ASoC: sun4i-i2s: Add support for H3") But otherwise, Acked-by: Chen-Yu Tsai