Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5089085ybi; Tue, 4 Jun 2019 00:45:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqyOfid6ed6eOvAW816bZ9qPFCO+CxvXe4h2/UZNySk1mwCLdfkyY1faLecoeIFmF0pjShau X-Received: by 2002:aa7:919a:: with SMTP id x26mr22570349pfa.134.1559634304419; Tue, 04 Jun 2019 00:45:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559634304; cv=none; d=google.com; s=arc-20160816; b=xdFjgll/1m46xfjsS+Ka+OrkIDjmsZ2zm4oDWAN1cA6CvUnwTcEl65MssF4zi69h6f 1LemRH2GcufL8sPx8L4lJP1u0EZ9l0XpXCnumO71BiJSZPf/xpQFdYJ/9yzWWnpNrCLT Y38pZ/JmblvgrPUZTvm+dyYJ0A/teoqs8tFVxQmWDRr1Ie5DSLtB3ufhmdDT/mtXPCim GwW1gk4tXfjK9SUtRYbf/Y8Snzbz18JHcL+zgzOroKEOgrilIMSw0AUIqYwbUUFyGmpv VCECcvTL3U/P1iKJpPywHYG1ba3JzNRNJMulL6Rmxbh0vwc3HWkg7N2c/wSUEJAk8Bwc zpPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=rmUWvY6vszLChEDaejA9+Li0kAdAh5y067TI4p51SH0=; b=VM+sPmChWi+GwE72F4PSw+XG2DAgCImiYCXoqgPJxSrWdOVV8vnJFZJSa6MYWcdVFD B/JPSD4xDs0N2j3rPhxuYyUQrQS3suv01msMWiw5MhzZE1lph2aOPgpCMnZJUStSBHKR UbMHb/l73IDSxkwRqIj95Fdcs/z9RPYQTu72H3+vV/QU8YQ9Xx6MfIdOqTQUk0OiNA7E Oak78LFQfLxN/0hitXeYlhsefDaxGioSgF1RR2U3m8Cha9Yea2rpp7cpiIeVr9yXC3YO Z7AIEWJV43ggLELMu2J6qTfT45ekcza/wxs9ip255lLDaZhlf4t+LDXm38seZdD+kopy +s7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2si17420942pls.93.2019.06.04.00.44.47; Tue, 04 Jun 2019 00:45:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726789AbfFDHnF (ORCPT + 99 others); Tue, 4 Jun 2019 03:43:05 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:51141 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726637AbfFDHnF (ORCPT ); Tue, 4 Jun 2019 03:43:05 -0400 X-Originating-IP: 90.88.144.139 Received: from localhost (aaubervilliers-681-1-24-139.w90-88.abo.wanadoo.fr [90.88.144.139]) (Authenticated sender: maxime.ripard@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 5D1EF20007; Tue, 4 Jun 2019 07:43:02 +0000 (UTC) Date: Tue, 4 Jun 2019 09:43:01 +0200 From: Maxime Ripard To: codekipper@gmail.com Cc: wens@csie.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com, broonie@kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, be17068@iperbole.bo.it Subject: Re: [PATCH v4 3/9] ASoC: sun4i-i2s: Add regmap field to sign extend sample Message-ID: <20190604074301.p27e5towgehmraoy@flea> References: <20190603174735.21002-1-codekipper@gmail.com> <20190603174735.21002-4-codekipper@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4iu232naw3x4dexg" Content-Disposition: inline In-Reply-To: <20190603174735.21002-4-codekipper@gmail.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4iu232naw3x4dexg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 03, 2019 at 07:47:29PM +0200, codekipper@gmail.com wrote: > From: Marcus Cooper > > On the newer SoCs this is set by default to transfer a 0 after Which SoCs? > each sample in each slot. However the platform that this driver Which platform? > was developed on had the default setting where it padded the audio > gain with zeros. This isn't a problem whilst we have only support > for 16bit audio but with larger sample resolution rates in the > pipeline then it should be fixed to also pad. Without this the audio > gets distorted. > > Signed-off-by: Marcus Cooper Once the commit log fixed, Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --4iu232naw3x4dexg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXPYhBQAKCRDj7w1vZxhR xcVmAQDSGaycvO/U1wpX1Ai6mvSxxamMb37KG7EScFKOC3oa5gEAzJ68Gg6XPP/O EBu14S2afGHTqLHHKTGeLzVHp5ZKHwU= =1Yj6 -----END PGP SIGNATURE----- --4iu232naw3x4dexg--