Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5096897ybi; Tue, 4 Jun 2019 00:55:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTF9pBvrPrJ2NAs5fHWJ63QApAoxtEopls7rHzeJzxIIKjFlmBgNGwqnhCMTJTS09h+F37 X-Received: by 2002:a62:36c1:: with SMTP id d184mr37428805pfa.49.1559634944857; Tue, 04 Jun 2019 00:55:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559634944; cv=none; d=google.com; s=arc-20160816; b=WNRBXKW+GzvLQ1jSL0TUxj3LloCHfA5rRyZLxcZtJuIB6PwHLOlA/sXbvWhw1Tvuum TMYw0bAWvtei+qnkmVCAWnxVaGjm1JJhZD9bokz+cKBIFHYVF1Ke1Qg+YueDWLpJj5jP t0Q4Y48Kuj6lQeA+T0p9RsYBEgSDMbpbwKF33WXtkQOXomvQUMJdO5EZRT8eA9zWDtnq XoAGkkLI+cSpXTErGqYJvo/2DRpofCowJQ8Dd3kPvm+2ZscA2V0Nxmq79LInkEbadvjo JOnICUpcMTvZVd9XUw8a8JRT0vA9NBoD3bYRv5m2eC7j7+z3V0/yZAuoCWSCcK0yzMQ/ tT+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=8kXR/Wugoq2W2WYGTeEioRnRB98XfA5Ei0oVhXo4cgM=; b=nraiTsV8dx5a8x5J+A3fIGqTGFQfPU/BAcOxFH59XhvooI0RTnVIWLe3uQ1AU0iTbl aVLsx96cqleCiWswMUmJIKvRZAmK1GjFcAZTAxYQEf9VwpMyO0CfEIDAmJINz3X/9dUr yklvsqpiTS8w0BCf13bseVfRhzECovOlnZTldovejmGb6+wl9LX5L3SQpbwefgt2N4TB ipR70zQLEyGoGZdrzi4TrRCt9O2woz6dAVfkz9YON0LmDbuq2CqyamEREvUtIXJNGL6w dG3WQPTpBF8S8pJGdzqPhA+LWftidXsOb2fdyFXiUetmHOi1vR6zFjMMgJypGr1/WWv9 aZYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w27si21031481pgl.277.2019.06.04.00.55.29; Tue, 04 Jun 2019 00:55:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726981AbfFDHxr (ORCPT + 99 others); Tue, 4 Jun 2019 03:53:47 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:59348 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726792AbfFDHxr (ORCPT ); Tue, 4 Jun 2019 03:53:47 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 183D9802F2; Tue, 4 Jun 2019 09:53:35 +0200 (CEST) Date: Tue, 4 Jun 2019 09:53:44 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Zhang, Baoli" , Ong Boon Leong , Weifeng Voon , "David S. Miller" Subject: Re: [PATCH 4.19 22/32] net: stmmac: dma channel control register need to be init first Message-ID: <20190604075344.GB24856@amd> References: <20190603090308.472021390@linuxfoundation.org> <20190603090314.784323813@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QKdGvSO+nmPlgiQ/" Content-Disposition: inline In-Reply-To: <20190603090314.784323813@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --QKdGvSO+nmPlgiQ/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2019-06-03 11:08:16, Greg Kroah-Hartman wrote: > From: Weifeng Voon >=20 > stmmac_init_chan() needs to be called before stmmac_init_rx_chan() and > stmmac_init_tx_chan(). This is because if PBLx8 is to be used, > "DMA_CH(#i)_Control.PBLx8" needs to be set before programming > "DMA_CH(#i)_TX_Control.TxPBL" and "DMA_CH(#i)_RX_Control.RxPBL". This one misses upstream id, too. It is hash af8f3fb7fb077c9df9fed97113a031e792163def . Best regrads, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --QKdGvSO+nmPlgiQ/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlz2I4gACgkQMOfwapXb+vK4CgCeLZrO3dduXeqF4tPZ88gGIdhy ChAAn3fShcUval/ahyqwxSZZ8xtnJ8sH =YHbt -----END PGP SIGNATURE----- --QKdGvSO+nmPlgiQ/--