Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v11 0/2] usb: xhci: Add Clear_TT_Buffer
To:     Greg KH <gregkh@linuxfoundation.org>, <stern@rowland.harvard.edu>
References: <1559559224-9845-1-git-send-email-jilin@nvidia.com>
 <20190603122303.GA16267@kroah.com>
CC:     <mathias.nyman@intel.com>, <kai.heng.feng@canonical.com>,
        <drinkcat@chromium.org>, <Thinh.Nguyen@synopsys.com>,
        <nsaenzjulienne@suse.de>, <jflat@chromium.org>, <malat@debian.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From:   Jim Lin <jilin@nvidia.com>
Message-ID: <e7ccbc27-2ff4-b1b9-aa1b-c77da5e122ca@nvidia.com>
Date:   Tue, 4 Jun 2019 16:53:54 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20190603122303.GA16267@kroah.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019=E5=B9=B406=E6=9C=8803=E6=97=A5 20:23, Greg KH wrote:
> On Mon, Jun 03, 2019 at 06:53:42PM +0800, Jim Lin wrote:
>> USB 2.0 specification chapter 11.17.5 says "as part of endpoint halt
>> processing for full-/low-speed endpoints connected via a TT, the host
>> software must use the Clear_TT_Buffer request to the TT to ensure
>> that the buffer is not in the busy state".
>>
>> In our case, a full-speed speaker (ConferenceCam) is behind a high-
>> speed hub (ConferenceCam Connect), sometimes once we get STALL on a
>> request we may continue to get STALL with the folllowing requests,
>> like Set_Interface.
>>
>> Solution is to invoke usb_hub_clear_tt_buffer() to send
>> Clear_TT_Buffer request to the hub of the device for the following
>> Set_Interface requests to the device to get ACK successfully.
>>
>> The Clear_TT_Buffer request sent to the hub includes the address of
>> the LS/FS child device in wValue field. usb_hub_clear_tt_buffer()
>> uses udev->devnum to set the address wValue. This won't work for
>> devices connected to xHC.
>>
>> For other host controllers udev->devnum is the same as the address of
>> the usb device, chosen and set by usb core. With xHC the controller
>> hardware assigns the address, and won't be the same as devnum.
>>
>> Here we have two patches.
>> One is to add devaddr in struct usb_device for
>> usb_hub_clear_tt_buffer() to use.
>> Another is to invoke usb_hub_clear_tt_buffer() for halt processing.
> Why did you resend patch series 11?
Didn't get response in 2 or 3 days.
Will be more patient next time.

May I get patch v11 1/2 acked or reviewed by Alan?

Thanks,
Jim