Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 4 Jun 2019 18:07:35 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Eric Dumazet <edumazet@google.com>
Cc:     kernel test robot <rong.a.chen@intel.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Willem de Bruijn <willemb@google.com>,
        Soheil Hassas Yeganeh <soheil@google.com>,
        LKML <linux-kernel@vger.kernel.org>, "lkp@01.org" <lkp@01.org>,
        "David S. Miller" <davem@davemloft.net>, ying.huang@intel.com
Subject: Re: [LKP] [tcp] 8b27dae5a2: netperf.Throughput_Mbps -25.7% regression
Message-ID: <20190604100735.s2g3tc35ofybimek@shbuild888>
References: <20190403063436.GG20952@shao2-debian>
 <20190530103048.hfld4t4m37jsg4yo@shbuild888>
 <CANn89iL4TYBYVnRhzVAH8UXSptStnYkZ+Rq3swzsMWngRJmGCA@mail.gmail.com>
 <20190530152314.ise5ycz6sdwfygph@shbuild888>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190530152314.ise5ycz6sdwfygph@shbuild888>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 30, 2019 at 11:23:14PM +0800, Feng Tang wrote:
> Hi Eric,
> 
> On Thu, May 30, 2019 at 05:21:40AM -0700, Eric Dumazet wrote:
> > On Thu, May 30, 2019 at 3:31 AM Feng Tang <feng.tang@intel.com> wrote:
> > >
> > > On Wed, Apr 03, 2019 at 02:34:36PM +0800, kernel test robot wrote:
> > > > Greeting,
> > > >
> > > > FYI, we noticed a -25.7% regression of netperf.Throughput_Mbps due to commit:
> > > >
> > > >
> > > > commit: 8b27dae5a2e89a61c46c6dbc76c040c0e6d0ed4c ("tcp: add one skb cache for rx")
> > > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
> > >
> > > Hi Eric,
> > >
> > > Could you help to check this? thanks,
> > >
> > 
> > Hmmm... patch is old and had some bugs that have been fixed.
> > 
> > What numbers do you have with more recent kernels ?
> 
> 
> I just run the test  with 5.2-rc2, and the regression is still there.

Hi Eric,

Any hint on this?

From the perf data, the spinlock contention has an obvious increase:

9.28            +7.6       16.91        perf-profile.calltrace.cycles-pp.native_queued_spin_lock_slowpath._raw_spin_lock.free_one_page.__free_pages_ok.___pskb_trim
18.55           +8.6       27.14        perf-profile.calltrace.cycles-pp.native_queued_spin_lock_slowpath._raw_spin_lock_irqsave.get_page_from_freelist.__alloc_pages_nodemask.skb_page_frag_refill

And for commit 8b27dae5a2 ("tcp: add one skb cache for rx"), IIUC, it
is not a real cache like the "tx skb cache" patch, and kind of a
delayed freeing.

Thanks,
Feng