Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5215612ybi; Tue, 4 Jun 2019 03:14:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqxV8ZXbfOC2kjIz1oWYEIuP8KdsYBP6db2wd7Ib6dhrTZmmIQcSk5fUaDyAY9nJxXYn9zHT X-Received: by 2002:a63:6105:: with SMTP id v5mr18336286pgb.312.1559643248005; Tue, 04 Jun 2019 03:14:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559643247; cv=none; d=google.com; s=arc-20160816; b=aAYa8zPp/753aGHl3zACa30m5IaJFhghrdPmkXwUBLylGgMigU/W/AdX2+gOY9U/oG /nbnX4+3ukQ2J6o0LO+uYtSL/T6Mj4uJzfe5LNpw+PpcPWlvgR7nLs6oZxaDNsAYjkOA d6f92YP3IkkO0A3uojx5ftfongP5VQd5/00UNnJFfgZzldTutlsEXsyUhtdYEXlzAaLF FsXWMFVVe4NOAhUWUuH+eNI6rw2AjbvatvfzyT0P97y2w05TySg/HJL0Gy6TUqn8MwpW vbH5hdfy17F90oh4VaY4dnPdzqxsGxBiTakgbsl+qBydehGRFDWCJ+VeHgcXvtV3Vlee AQ0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=X82u0k5Tt+0WfEI1nYZg4HT5FFOfhfBLzKE7JXG2HsI=; b=pCkWw4d2y9bU01KKrqDkw0iEw4VhrYps1Ev65il26c2TLzP4CwTeLBLn9fJsBobgxz lajkGARqN6fLhjLCASA4dwCLtHqb5E19ZDTono+rbXHr3sZlsezBWqV6Yqc60LJigBHB RadSEe8EV1Te7ulfzSUVj3TbtVg4m6rkQ0FQMAYgBMRU7QImeY6ztD/rIJVOZRKrcoLG 9ZNRQRLmmuxQPw2ZkGYwxHEAKvUjkmAQF7SGQB14YQJXX+Ujt33AVL8HFuYX36CXdmal HY+ohCVtDToyVUmUjjGKuuXD2ecr8GMrfPLW4vqeJfoIay+p20jI5ndY2muAn5YHTKLF EceA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a33si22567923plc.283.2019.06.04.03.13.51; Tue, 04 Jun 2019 03:14:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727381AbfFDKM1 (ORCPT + 99 others); Tue, 4 Jun 2019 06:12:27 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:37102 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727272AbfFDKMZ (ORCPT ); Tue, 4 Jun 2019 06:12:25 -0400 X-UUID: 08f2d07d951549c0ac5e50be68833bcd-20190604 X-UUID: 08f2d07d951549c0ac5e50be68833bcd-20190604 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 360373016; Tue, 04 Jun 2019 18:12:03 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 4 Jun 2019 18:12:01 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 4 Jun 2019 18:12:01 +0800 From: Stu Hsieh To: Mauro Carvalho Chehab , Rob Herring , CK Hu CC: Mark Rutland , Matthias Brugger , Stu Hsieh , , , , , , Subject: [PATCH v4 13/14] [media] mtk-mipicsi: add debugfs for mipicsi driver Date: Tue, 4 Jun 2019 18:11:54 +0800 Message-ID: <1559643115-15124-14-git-send-email-stu.hsieh@mediatek.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1559643115-15124-1-git-send-email-stu.hsieh@mediatek.com> References: <1559643115-15124-1-git-send-email-stu.hsieh@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch add debugfs for mipicsi driver. Signed-off-by: Stu Hsieh --- .../media/platform/mtk-mipicsi/mtk_mipicsi.c | 68 ++++++++++++++++++- 1 file changed, 67 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c index b291c95bbf0e..9b5983b39f2b 100644 --- a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c +++ b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c @@ -50,6 +50,7 @@ #include #include #include +#include #define MTK_MIPICSI_DRV_NAME "mtk-mipicsi" #define MTK_PLATFORM_STR "platform:mt2712" @@ -78,6 +79,7 @@ #define SENINF_NCSI2_INT_EN 0xB0 #define SENINF_NCSI2_INT_STATUS 0xB4 #define SENINF_NCSI2_DBG_SEL 0xB8 +#define SENINF_NCSI2_DBG_PORT 0xBC #define SENINF_NCSI2_HSRX_DBG 0xD8 #define SENINF_NCSI2_DI 0xDC #define SENINF_NCSI2_DI_CTRL 0xE4 @@ -87,6 +89,7 @@ #define SENINF_TOP_MUX 0x08 #define SENINF_MUX_CTRL 0x00 +#define SENINF_MUX_DEBUG_2 0x14 #define CAMSV_MODULE_EN 0x10 #define CAMSV_FMT_SEL 0x14 @@ -108,6 +111,8 @@ #define IMGO_STRIDE 0x238 #define DMA_FRAME_HEADER_EN 0xE00 +#define CONFIG_DEBUG_FS 1 + #define notifier_to_mipicsi(n) container_of(n, struct mtk_mipicsi_dev, \ notifier) static int mtk_mipicsi_dbg_level; @@ -184,7 +189,9 @@ struct mtk_mipicsi_dev { spinlock_t irqlock; spinlock_t queue_lock; struct mutex lock; - +#ifdef CONFIG_DEBUG_FS + struct dentry *mtk_mipicsi_debugfs; +#endif }; static const struct mtk_format mtk_mipicsi_formats[] = { @@ -207,12 +214,56 @@ static const struct mtk_format mtk_mipicsi_formats[] = { }, }; +#ifdef CONFIG_DEBUG_FS +static ssize_t mtk_mipicsi_debug_read(struct file *file, char __user *user_buf, + size_t count, loff_t *ppos) +{ + struct device *dev = file->private_data; + struct mtk_mipicsi_dev *mipicsi = dev_get_drvdata(dev); + struct mtk_mipicsi_channel *ch = mipicsi->channel; + u32 int_val; + u32 dbg_port; + u32 cnt_val; + u32 hcnt; + u32 vcnt; + char buf[256]; + char cnt_info[150]; + int i; + + int_val = readl(mipicsi->seninf + SENINF_NCSI2_INT_STATUS); + dbg_port = readl(mipicsi->seninf + SENINF_NCSI2_DBG_PORT); + memset(buf, 0, sizeof(buf)); + snprintf(buf, sizeof(buf), "%s\nSENINF_NCSI2_INT_STATUS: 0x%X\n" + "SENINF_NCSI2_DBG_PORT: 0x%X\n", + dev_name(dev), int_val, dbg_port); + + for (i = 0; i < mipicsi->camsv_num; ++i) { + cnt_val = readl(ch[i].seninf_mux + SENINF_MUX_DEBUG_2); + hcnt = (cnt_val >> 16) & 0xFFFF; + vcnt = cnt_val & 0xFFFF; + memset(cnt_info, 0, sizeof(cnt_info)); + snprintf(cnt_info, sizeof(cnt_info), + "HCNT[%d]: 0x%X\n" + "VCNT[%d]: 0x%X\n", + i, hcnt, i, vcnt); + strcat(buf, cnt_info); + } + + return simple_read_from_buffer(user_buf, count, ppos, buf, strlen(buf)); +} +static const struct file_operations mtk_mipicsi_debug_fops = { + .open = simple_open, + .read = mtk_mipicsi_debug_read, +}; +#endif /* CONFIG_DEBUG_FS */ + static int get_subdev_link(struct mtk_mipicsi_dev *mipicsi, unsigned int *link, u8 *link_reg_val) { struct device *dev = &mipicsi->pdev->dev; struct mtk_mipicsi_subdev *sd = &mipicsi->mipicsi_sd; + if (sd->max_vc == 1) { *link = 1; *link_reg_val = 0x1; @@ -1574,6 +1625,16 @@ static int mtk_mipicsi_probe(struct platform_device *pdev) goto clean; } +#ifdef CONFIG_DEBUG_FS + mipicsi->mtk_mipicsi_debugfs = + debugfs_create_file(mipicsi->drv_name, 0444, NULL, + (void *)(&pdev->dev), &mtk_mipicsi_debug_fops); + if (mipicsi->mtk_mipicsi_debugfs == NULL) { + dev_err(&pdev->dev, "debugfs_create_file fail\n"); + goto clean; + } +#endif + dev_set_drvdata(&pdev->dev, mipicsi); dev_info(&pdev->dev, "probe done\n"); @@ -1591,6 +1652,11 @@ static int mtk_mipicsi_probe(struct platform_device *pdev) static int mtk_mipicsi_remove(struct platform_device *pdev) { +#ifdef CONFIG_DEBUG_FS + struct mtk_mipicsi_dev *mipicsi = dev_get_drvdata(&pdev->dev); + + debugfs_remove(mipicsi->mtk_mipicsi_debugfs); +#endif pm_runtime_disable(&pdev->dev); return 0; -- 2.18.0