Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5273391ybi; Tue, 4 Jun 2019 04:14:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqxqDahS2GdeLRGwtAEm72KOjNSBzdKmh18haJJG1vgdsvOZrXCIzppkYVnQp4RRXWaDiTVo X-Received: by 2002:a63:1119:: with SMTP id g25mr33818025pgl.380.1559646851044; Tue, 04 Jun 2019 04:14:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559646851; cv=none; d=google.com; s=arc-20160816; b=Z7uaXtyXOMXzIKa7ouGyMLLKqyA51y+0/LHxQIs8uCWjJOXiRUCwU8k+F6akAL8lPZ qUbzJkanhOhYNByt0sYh2aRYuWTX45JDql/nStEAVjsvpeqo0RvpQpq9cBM8ZgvyHflg YUGa6VPNZ7xLA0Vfox5nX64BcS49clweHlWv/r7B/eP7uj5B2TKl706pNUDwbJ6kuHJQ 5d9HW3Sx844+jOYBhAVfW1Yo/OWp+KiX4ztfaACA54GroSXLb+UUxeWK9OACRnsVvkNO e8K4zZci7hP+MR+fzrh3oBdhYadWZng/3hLUDfQ10zBTLa6oXWwG5Z1tQh4IZZEMWUsO k1Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=sCZYu7OHbgkbtU1yamkBwdBmvEW9qZuwTA4BoapwJoc=; b=P0KaB3i7r8HA8ZACdBQTCDoO/qWjksnmRi3958Wp2XWPnPCs0FRC4aNIkZJ9EAIGRM TKQAxwN5kYTZdilw6U92BEopd2S79tVcPl0kSZhx9GvbgmtZcBvLrohoo67gbHnEvZ4z FG9kRKb02yw/VG+VQtHi66sEOo5YfuDsNzOIy3S/24S1mUagNUisKGD8rnME4YDVjyY1 a4YMp3xYAd653+HpoaOXa3VH8UiscYeVT3zXjhbMgmZf/o9O9n6KEUDWIsyzGxrIEb6Z SnHu/LURjD3D1dNAra5tAYxXl5LTMTbD0oiqcpUlnzExMpkxkKnAl3pjS+Y/FyxIbglP EPSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m62si22067340pgm.392.2019.06.04.04.13.52; Tue, 04 Jun 2019 04:14:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727301AbfFDLMg (ORCPT + 99 others); Tue, 4 Jun 2019 07:12:36 -0400 Received: from foss.arm.com ([217.140.101.70]:40454 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726508AbfFDLMg (ORCPT ); Tue, 4 Jun 2019 07:12:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E61280D; Tue, 4 Jun 2019 04:12:36 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC0753F690; Tue, 4 Jun 2019 04:12:33 -0700 (PDT) Date: Tue, 4 Jun 2019 12:12:31 +0100 From: Catalin Marinas To: Julien Grall Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, will.deacon@arm.com, christoffer.dall@arm.com, marc.zyngier@arm.com, james.morse@arm.com, julien.thierry@arm.com, suzuki.poulose@arm.com, Dave.Martin@arm.com, ard.biesheuvel@linaro.org Subject: Re: [PATCH v5 2/3] arch/arm64: fpsimd: Introduce fpsimd_save_and_flush_cpu_state() and use it Message-ID: <20190604111230.GA5668@arrakis.emea.arm.com> References: <20190521172139.21277-1-julien.grall@arm.com> <20190521172139.21277-3-julien.grall@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190521172139.21277-3-julien.grall@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2019 at 06:21:38PM +0100, Julien Grall wrote: > The only external user of fpsimd_save() and fpsimd_flush_cpu_state() is > the KVM FPSIMD code. > > A following patch will introduce a mechanism to acquire owernship of the > FPSIMD/SVE context for performing context management operations. Rather > than having to export the new helpers to get/put the context, we can just > introduce a new function to combine fpsimd_save() and > fpsimd_flush_cpu_state(). > > This has also the advantage to remove any external call of fpsimd_save() > and fpsimd_flush_cpu_state(), so they can be turned static. > > Lastly, the new function can also be used in the PM notifier. > > Signed-off-by: Julien Grall > Reviewed-by: Dave Martin [...] > --- > arch/arm64/include/asm/fpsimd.h | 4 +--- > arch/arm64/kernel/fpsimd.c | 17 +++++++++++++---- > arch/arm64/kvm/fpsimd.c | 4 +--- > 3 files changed, 15 insertions(+), 10 deletions(-) Marc, since this touches KVM, can I get an ack on this patch? I plan to queue the series. Thanks. -- Catalin