Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5509388ybi; Tue, 4 Jun 2019 07:43:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqyv6LlP0l2dyyrlcrWls+GsIAHeLY/x23VKkCYkdSiyMOVaGtlWpAEjQO6EEvT9K8d2yHpL X-Received: by 2002:a17:902:8d95:: with SMTP id v21mr16825253plo.225.1559659407751; Tue, 04 Jun 2019 07:43:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559659407; cv=none; d=google.com; s=arc-20160816; b=CvJtPUtj4OAjhBQRPVNGexoUwgGEmyEnCk49sUOgoe0cev6e4xGk7ir+Jt4nFPbYSZ 02JIZw4CUvYpn7uQAUQSCd+hD9w5AvRJUtUfIJOYYtm2cxoge7AIzz1DjwadGLmHDlVR g5OiXYtkiCelTk2Nv6gCUKqH5Xrzhaviiy6tuC65iiRdsDKDhBh39rtEyRbb+xB+Kzr4 DBmXwqVsoxlwlGJ2nbVQs1B6upN0YdclR5K4ISxrnhv6XTZslU4JW1UjvAVxAqd4fy6l s38VIYu6cv32mN32GUCtg2LLRSU439G9Zy8ZOUAqU7U7Tzy7TMSHNgwTbWNHsqExmz0n 3QZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=N8b0nbgILUFGl4UhABnT90OSTFViNxt/Voe8ebDAUhw=; b=FV1GWPpKSdGs1IM7d6tjkPRVZ9acbUxylO864S0xnZC0dfVOpzJdFoLuSPTWHO/y5K ghCtHRs6T5KlXADRqRfv5wVIqBCi3pbX1nBJ+nMsCFCruQiml2K0hgQGW2gi9NHGPPOC 5OdbFVdfuv9UPQox3nIFtO+HDFQU5W2TI/uESQhsvjYTMmPfvdgNTrmgi/7foB50R1Fa 6rlUQ7E4F2Ln1p42omwaZ0/7f0MLaULIwDgDb4IQs4tIloFHL8CiMdMUtWihYt5ZL+iM IRVlL2zgJ+AD+OjRq4rf+hRnxro9BKg/jWFZWbcrgJcfisykNJv5nCV/j4gTn8nVdCy9 aXtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ghWNYbIh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 91si24759931pld.334.2019.06.04.07.43.11; Tue, 04 Jun 2019 07:43:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ghWNYbIh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727665AbfFDOl6 (ORCPT + 99 others); Tue, 4 Jun 2019 10:41:58 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:40785 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727182AbfFDOl6 (ORCPT ); Tue, 4 Jun 2019 10:41:58 -0400 Received: by mail-lj1-f196.google.com with SMTP id a21so4733772ljh.7; Tue, 04 Jun 2019 07:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=N8b0nbgILUFGl4UhABnT90OSTFViNxt/Voe8ebDAUhw=; b=ghWNYbIhPC6NlWyE+BZpNLhuHwETwE7B0fWdhCiAG4IA4jsTtN61T517kBBgAtOLNG z2jlVHxg2ZfIshZkWLpMfffA2xszE3IxepJXAjK9koyhen3nqCcLnHlRCDwGeZsiMIMA PBdvovgf0UX1ZfP7I4dJcmTaXlf6TSEIQ0j5lSSAnTjk8BKCA0MYl6uzsT+B1m3V0NyT RQEknCuvA0eAwG80q1OVcQ5HXrOVO3MliWV4rVUaJaki7j1XVdFbyIK5L7qKnQ4/ARps rJ7PslclJDPTRvlaBFRkvZ4HHAXTK0uGlji+k5qrgEII4qOHVrP39z6v4X34yP7shTyD meKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=N8b0nbgILUFGl4UhABnT90OSTFViNxt/Voe8ebDAUhw=; b=j02gs/p7/kJArAkfgfjscPBldvQODmufDpKmlLQRHkKM/Bqq5V5/ukZ9aVVn6yQO8M ukZGdQHAyQ8oELZJTgDo27hr3sPWM8M7xlD3ftelmur/XB37bY1lVpjPXlkqEUMwI6mF sv4ERVRjxA0aEHGS5gAdQytVKwvIO4yBQIU4iD3In1HNb5/a2KHsIVIdOb39+5NIPoQP +vtWiw+AWexoM9P8AGHwCdUZqs/ou4hWksbLxdPMZMl2kAVO+cktOfzrSeJ5G4gWxwOH DdZ+Z1WnujcHvoaus2yYFk7kFzQa5/N8S+nxUsMjqWVPipSaHUCLmSFKQgJ0to9ORcZy d6/w== X-Gm-Message-State: APjAAAU2LdrKoMYhEh2bkcRenH7htSwp5HcbhlJ+3Net+qbrMgaJsAHh can5aeS9twQY8MyRisAyFKGstxKq X-Received: by 2002:a2e:9a96:: with SMTP id p22mr86177lji.57.1559659315586; Tue, 04 Jun 2019 07:41:55 -0700 (PDT) Received: from [192.168.2.145] ([94.29.35.141]) by smtp.googlemail.com with ESMTPSA id h10sm3223813lfj.10.2019.06.04.07.41.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 07:41:54 -0700 (PDT) Subject: Re: [PATCH v4 14/16] PM / devfreq: tegra: Enable COMPILE_TEST for the driver To: Thierry Reding Cc: Jonathan Hunter , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Tomeu Vizoso , linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190501233815.32643-1-digetx@gmail.com> <20190501233815.32643-15-digetx@gmail.com> <20190604112026.GN16519@ulmo> <20190604141031.GB397@ulmo> <20190604141824.GC397@ulmo> From: Dmitry Osipenko Message-ID: <02a6651f-17f3-2e79-7780-57657596ba23@gmail.com> Date: Tue, 4 Jun 2019 17:41:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190604141824.GC397@ulmo> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 04.06.2019 17:18, Thierry Reding пишет: > On Tue, Jun 04, 2019 at 04:10:31PM +0200, Thierry Reding wrote: >> On Tue, Jun 04, 2019 at 04:53:17PM +0300, Dmitry Osipenko wrote: >>> 04.06.2019 14:20, Thierry Reding пишет: >>>> On Thu, May 02, 2019 at 02:38:13AM +0300, Dmitry Osipenko wrote: >>>>> The driver's compilation doesn't have any specific dependencies, hence >>>>> the COMPILE_TEST option can be supported in Kconfig. >>>>> >>>>> Reviewed-by: Chanwoo Choi >>>>> Signed-off-by: Dmitry Osipenko >>>>> --- >>>>> drivers/devfreq/Kconfig | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig >>>>> index 56db9dc05edb..a6bba6e1e7d9 100644 >>>>> --- a/drivers/devfreq/Kconfig >>>>> +++ b/drivers/devfreq/Kconfig >>>>> @@ -93,7 +93,7 @@ config ARM_EXYNOS_BUS_DEVFREQ >>>>> >>>>> config ARM_TEGRA_DEVFREQ >>>>> tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver" >>>>> - depends on ARCH_TEGRA >>>>> + depends on ARCH_TEGRA || COMPILE_TEST >>>>> select PM_OPP >>>>> help >>>>> This adds the DEVFREQ driver for the Tegra family of SoCs. >>>> >>>> You need to be careful with these. You're using I/O register accessors, >>>> which are not supported on the UM architecture, for example. >>>> >>>> This may end up getting flagged during build testing. >>> >>> We have similar cases in other drivers and it doesn't cause any known >>> problems because (I think) build-bots are aware of this detail. Hence >> >> I don't understand how the build-bots would be aware of this detail. >> Unless you explicitly state what the dependencies are, how would the >> build-bots know? Perhaps there's some logic built-in somewhere that I >> don't know about? > > So looks like COMPILE_TEST has a !UML dependency, so this might just > work. > > Acked-by: Thierry Reding > Thank you very much for the clarification! Certainly that would caused problems already since there are such cases all over the kernel, including Tegra drivers.