Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5537480ybi; Tue, 4 Jun 2019 08:08:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqy7dKdL1LKf4ci91l6TDuqJa6cb7MQALZR4VVf6Rl9+cvOnSs19KbP0TwQtAFJjyWhzOSbN X-Received: by 2002:a17:902:7448:: with SMTP id e8mr26594261plt.222.1559660899939; Tue, 04 Jun 2019 08:08:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559660899; cv=none; d=google.com; s=arc-20160816; b=bDxu+u/zjOavtxauH0O81ztmmKw3MGT/F+w6LjCkz1/87lTzV0oB6LXFw3CZfHTuiI vSndEQvG547xhtOTdWBbhMeAcYCb9hRNlXwjKOO//vjVzHKpUC57Fn2Lnq+xFs5JZDpx 58rgTuDncyUDJ4kpUwJ2H7Vrim5NFikir3mGJdjpyBxONepSguh1pWYuPk7my7GnB89k 39QgJssf0rtlOnh+lDtDHtr0suhgfLHMC/ryMNbI5JIX8SaIPzoFL6NOzveTv+KicuDp a0gUXy4RqCnrHkZlRKWHJqCijC0qjHWUA/SDPfWcRYbkc4lEoi11RJuZH/t+dVSOFNj5 KvMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=mm+beSoAnAMWpvw6Y7kl4thy8yeDJ6vEadqPoh1YEEo=; b=z8CfyKp2C+XaPnwn9CCn5sHlvRvBRPHoOLEopWeA0oBdHwPDeJUFHOwwWAKChVhLJD Xo+TlvU5CCe7gwzptudIdeepdsyCmrGYWn7SgGOW8+9GSV5r3SA8apZ2ptxKgznhOaqg IuWNxucVM5tW5YJKPYnBE8hBZlEcXHPN0ukE/NTNnev7fM8QpjeVhFc0AWUFrxGwNIu+ 7XJmQnoeScw02YSHwjmnjVApB4P1FoPWADWgBlJZV50GHtfWFU3iIwZnlLZqmneF2/cH +TErWRlaNWr4C5VMgxjJlqkGflECBW4FEyDOHzewVeIbUB2u+sepxanFzj7HLu4moCcB 0JTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c1si23591274pld.99.2019.06.04.08.08.01; Tue, 04 Jun 2019 08:08:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728054AbfFDPEr (ORCPT + 99 others); Tue, 4 Jun 2019 11:04:47 -0400 Received: from www62.your-server.de ([213.133.104.62]:56112 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727771AbfFDPEr (ORCPT ); Tue, 4 Jun 2019 11:04:47 -0400 Received: from [78.46.172.2] (helo=sslproxy05.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hYAzO-0007Rt-AO; Tue, 04 Jun 2019 17:04:38 +0200 Received: from [178.197.249.21] (helo=linux.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1hYAzO-000MVF-2f; Tue, 04 Jun 2019 17:04:38 +0200 Subject: Re: [PATCH][next][V2] bpf: remove redundant assignment to err To: Colin King , Alexei Starovoitov , "David S . Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , netdev@vger.kernel.org, xdp-newbies@vger.kernel.org, bpf@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190604082146.2049-1-colin.king@canonical.com> From: Daniel Borkmann Message-ID: <4e971d2b-1143-dd1a-6d2a-a2b75dec815b@iogearbox.net> Date: Tue, 4 Jun 2019 17:04:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190604082146.2049-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.3/25470/Tue Jun 4 10:01:16 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2019 10:21 AM, Colin King wrote: > From: Colin Ian King > > The variable err is assigned with the value -EINVAL that is never > read and it is re-assigned a new value later on. The assignment is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Applied, thanks!