Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5637478ybi; Tue, 4 Jun 2019 09:35:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqyC5eNpKSbPslrQe+/TKKUiVR+Qsz5B7wldZ+uRdtxlT6Vws2TlG/1SvkXadpjsfb6RfesB X-Received: by 2002:a17:90a:ae10:: with SMTP id t16mr38319618pjq.51.1559666128811; Tue, 04 Jun 2019 09:35:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559666128; cv=none; d=google.com; s=arc-20160816; b=fBf3OIFMG1iOZr9yfAj2+5cCtPs2gPWKqAhEnNKI/IZRZ1n6t7k5UbV7/eRhkGRefD SWwXYUjWGzpcG7XrVPKOW71ODsPvpA9sgV4GnR40SFbp+QjpQVLwo3Mt45pkNKedohKW A6xvohPZzQZs4ftMx64vh8I+67TtKwd4gW2VF2eXHTA5ZeP/0GEX8wQ8eQaSEhbO+jX5 HlZY0xmQ7nUQeiMHauuzVlkuAYvPVBQxOYjx5XlWKesvNcKW+QrZDbZgxz2j1A537xn9 ZG4NaVWLoqOH0FiIutTwEq9LWF0iOMTwLwmCx/eLbp6pcmt9ewgoW/tA9eoRncnG9hhx gbdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=j0HsjNCBgw6fb89AS0Z7APClR+xnsmHO6MK4li8L+Yg=; b=N3jSLKdgdy5U4ViHcOb5MqyL3v8/829PlGngmCSiHw7N5YV1vIOhLmrBsKa8Jv48/E Llohf3Y2Q1f90tsxx+w/uKk1WZND71pdcf7RksN78nGdBTLUmF05LCiU7gn9HgEqwHLF WgJA3YiAvb/3ALamg9Tfi8yOFef/gIRBpS/Wjo7HlgAsW0r000m6xQjU23lqsEihhu3W Fe9S7Viq1G89TkfGQkGagIbx8zyv00O7Cdzjksx5nJlyQLQAEE1xSszwsA7dYKVJzX1Z LdphrnB9EqGFFmR/ztAkPPCK7iYj5kJKmRK0yxAukC1u0zN5m7PrsozXC7uaHZUy1esp U0Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@crapouillou.net header.s=mail header.b=dnheEqEu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u126si19911893pgu.117.2019.06.04.09.35.10; Tue, 04 Jun 2019 09:35:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@crapouillou.net header.s=mail header.b=dnheEqEu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727840AbfFDQeA (ORCPT + 99 others); Tue, 4 Jun 2019 12:34:00 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:47148 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727795AbfFDQd7 (ORCPT ); Tue, 4 Jun 2019 12:33:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1559666037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=j0HsjNCBgw6fb89AS0Z7APClR+xnsmHO6MK4li8L+Yg=; b=dnheEqEuK7O6vdqyl/0cBNMRU4cw17F0bPm4lIdzfwqPlS/zyW9SIf2s9PnClisWI0PQNA LnUy2qiihxP4YCHu9pkxA8k2GK12dcHGeBUprchnxPOUX3YDqrgfNbqsBZYuTiAk+KH1Ft oHxUNTjM+ks36004qmTWCR0YqqD0oRo= From: Paul Cercueil To: Ralf Baechle , Paul Burton , James Hogan Cc: Linus Walleij , od@zcrc.me, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil , stable@vger.kernel.org Subject: [PATCH] MIPS: lb60: Fix pin mappings Date: Tue, 4 Jun 2019 18:33:11 +0200 Message-Id: <20190604163311.19059-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pin mappings introduced in commit 636f8ba67fb6 ("MIPS: JZ4740: Qi LB60: Add pinctrl configuration for several drivers") are completely wrong. The pinctrl driver name is incorrect, and the function and group fields are swapped. Fixes: 636f8ba67fb6 ("MIPS: JZ4740: Qi LB60: Add pinctrl configuration for several drivers") Cc: Signed-off-by: Paul Cercueil --- arch/mips/jz4740/board-qi_lb60.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/mips/jz4740/board-qi_lb60.c b/arch/mips/jz4740/board-qi_lb60.c index 071e9d94eea7..daed44ee116d 100644 --- a/arch/mips/jz4740/board-qi_lb60.c +++ b/arch/mips/jz4740/board-qi_lb60.c @@ -466,27 +466,27 @@ static unsigned long pin_cfg_bias_disable[] = { static struct pinctrl_map pin_map[] __initdata = { /* NAND pin configuration */ PIN_MAP_MUX_GROUP_DEFAULT("jz4740-nand", - "10010000.jz4740-pinctrl", "nand", "nand-cs1"), + "10010000.pin-controller", "nand-cs1", "nand"), /* fbdev pin configuration */ PIN_MAP_MUX_GROUP("jz4740-fb", PINCTRL_STATE_DEFAULT, - "10010000.jz4740-pinctrl", "lcd", "lcd-8bit"), + "10010000.pin-controller", "lcd-8bit", "lcd"), PIN_MAP_MUX_GROUP("jz4740-fb", PINCTRL_STATE_SLEEP, - "10010000.jz4740-pinctrl", "lcd", "lcd-no-pins"), + "10010000.pin-controller", "lcd-no-pins", "lcd"), /* MMC pin configuration */ PIN_MAP_MUX_GROUP_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "mmc", "mmc-1bit"), + "10010000.pin-controller", "mmc-1bit", "mmc"), PIN_MAP_MUX_GROUP_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "mmc", "mmc-4bit"), + "10010000.pin-controller", "mmc-4bit", "mmc"), PIN_MAP_CONFIGS_PIN_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "PD0", pin_cfg_bias_disable), + "10010000.pin-controller", "PD0", pin_cfg_bias_disable), PIN_MAP_CONFIGS_PIN_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "PD2", pin_cfg_bias_disable), + "10010000.pin-controller", "PD2", pin_cfg_bias_disable), /* PWM pin configuration */ PIN_MAP_MUX_GROUP_DEFAULT("jz4740-pwm", - "10010000.jz4740-pinctrl", "pwm4", "pwm4"), + "10010000.pin-controller", "pwm4", "pwm4"), }; -- 2.21.0.593.g511ec345e18