Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5810071ybi; Tue, 4 Jun 2019 12:40:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqwjlnXwOwKQBU37Ws/VkKEMVXGN1Q6qlKkzUCtr5bkm+FnrE8gVS3BJOqtV1pcTxBfyXZQt X-Received: by 2002:a17:90a:b104:: with SMTP id z4mr17662545pjq.102.1559677218904; Tue, 04 Jun 2019 12:40:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559677218; cv=none; d=google.com; s=arc-20160816; b=zAZUZVXfaAzw/oKJagKCsO0PY1No8f4ts8mRFVi/syEhxGwSquc583NNmAdB0gwvMl cWBP+eR7gm5oM2cUkOyzrwSeza2HkTh42emO91IJxi92DwpAPJFzMiTWgdZutFI4KQsX 9r5CYvI/pUYkc2emKe5CI6/lCEjrCcpzVukgc6nlAlCghQG1LLQGC11Y5bN5ga1LFmEm moSFEEHI+kFBt2/qjye4nBZOmZfE5qL9kED11NP1mPFo+TUVyog2qsBJFanXOxb93KEV U47zQA/6Jf0m+MvIQYxgNHDLH5KwLhKm2odc04B0qor2vdcAKbGrqFhReD/6XszLWgJ5 gZNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=5awe/yDakGGO/BxwxBGm2kDwtqm01hxaeRIR5WSClTE=; b=yS41KznCV9c9yUkjwq+4sEWrKRVZpuJN4Cav3NGkikfTMUQZMQ3a+1GPxXjxTiwABt xXlqfLrJkkpDDk8G3eUEE7957Hdh/t1+FuWpeQFAq0ppGdTtWS8u0ysp99eFhypNHRDu nKTotNq7XJLhfPfTt+ODKk9J5W3c8Ui79M/3S5ZA43wOYQ4uX4oCOChh34W4VO4KXbCj LbdQBggN+yLhmGJf7nl+HFYSAWeC6XTfma/3Mb4rqoo7iyckQQJyqQu0tjngsiE5HqXj oAdLHv5iBRUY4TmprNv6fWrs9vFRnaN5lKXc1OM5rFtQvDICjN8BoAomZw0/W9UidnWb meIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=kSGpqLi9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g21si22745791pgb.313.2019.06.04.12.40.02; Tue, 04 Jun 2019 12:40:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=kSGpqLi9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726341AbfFDTio (ORCPT + 99 others); Tue, 4 Jun 2019 15:38:44 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:46020 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbfFDTin (ORCPT ); Tue, 4 Jun 2019 15:38:43 -0400 Received: by mail-pg1-f194.google.com with SMTP id w34so10915983pga.12 for ; Tue, 04 Jun 2019 12:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5awe/yDakGGO/BxwxBGm2kDwtqm01hxaeRIR5WSClTE=; b=kSGpqLi9hgVEttJY+zJphTmom5Q5BaBDXDBe5zqhVVAGx7/lugNzzuHC7qLjH6bnXr IUe2OT/8ZM/oxAdRpwwWcyUEv7AUKPVc3AYzfI/eItQVRaisMwh9h7SPmJZvCIYcZO8E k0KU0cJ86d1ViyKOEcuw5rfV9Iturz7XlAV/RSWm36Eo82G5fTfwPv19U8bu4Gqxr+CM BOCLx6BdgS+3LP7moHlYOItVLkSA+uR6lvepvP/wm0DjH8S9/gjwkn3dESclnow+ueU/ 4U/x1D5g4h53bvUfCc0X3Likoos40SvliquEQdlR35M4pDRvMfbhkhbCoZHuLe1G8KmI OGHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5awe/yDakGGO/BxwxBGm2kDwtqm01hxaeRIR5WSClTE=; b=gOJOT8BPO0SngzOvm5JcW8U4rKlxihzVZgflhh2Kz4m2E3LavdFx6gESwnH9XVmxfs YjqpLDz8mo85hDKZhTcmbS1FZ0acH1nzWYSMm2kdiYKgcl5GuGpKNM61+FeR5DF6Nysk 6QH1G/r7oO244dru5ZeadAT1qrBYCrVegF5GHZzFc8ZfckyNtSXvT69xmV3lRAq+rxVo nyltg6N6WWOUn4QAvoF1KCOEPMB0jqnC37v6soB2+I4j2xFo8VOFXiSnU4Jn37FOsSLz O34OxwAHfO0Kq95fAxRXlyWZ/xsaNIJut0PXX84JDoZpWNzBaejuAef5vA5tffmLfx9W NjcA== X-Gm-Message-State: APjAAAUk5eZfSBq2hU/UlmemTmlsyVYOepp2sdR4fZsVdOvaPsHZ+sc7 W2HmZG66agonu+UvPCYF8R3AUFFlbShsqw== X-Received: by 2002:a63:6fce:: with SMTP id k197mr295216pgc.140.1559677123064; Tue, 04 Jun 2019 12:38:43 -0700 (PDT) Received: from [192.168.1.158] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id c129sm21243833pfa.106.2019.06.04.12.38.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 12:38:41 -0700 (PDT) Subject: Re: [PATCH v3] block: aoe: no need to check return value of debugfs_create functions To: Greg Kroah-Hartman , Justin Sanders , linux-kernel@vger.kernel.org Cc: "Ed L. Cashin" , linux-block@vger.kernel.org References: <20190122152151.16139-5-gregkh@linuxfoundation.org> <20190603194754.GB21877@kroah.com> From: Jens Axboe Message-ID: <168b8cf5-15ed-a4c1-6393-4f8df336a68e@kernel.dk> Date: Tue, 4 Jun 2019 13:38:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190603194754.GB21877@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/3/19 1:47 PM, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Applied, thanks. -- Jens Axboe