Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5854576ybi; Tue, 4 Jun 2019 13:31:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzsCPNq6I1wEN+qVxkvhWc7mZz+XcEx5jBE2Jd+r/JMbnGiL8NDdtZKZ2lxLdWEw3heC/sk X-Received: by 2002:aa7:82cd:: with SMTP id f13mr41851718pfn.203.1559680269995; Tue, 04 Jun 2019 13:31:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559680269; cv=none; d=google.com; s=arc-20160816; b=cFLPtXXh09GSrWIgNp81lcb8dxp67K33LmngGWQzxx7zJzBIEqrLSRNUdrrZtx0QPE q0bOXSJRk9jKshcBDp4QMVihRwGNhltEIdGovXrQ703fxeX6LlJufp0kDYFTI4xDWKop AvVXXAAOTvlbW4FHydP+tjbjuxXxNSWZ4iTGpQ5E3XhE9bIzmKtNT/TQmHTX7ZssLghh fl4DCa34PsyCaRyZCmJUC7RRF1qPO26a6QdtrbRNTXcO9ByFfSRFYi9mmbRhlX7RRH7x J1f13HlsXVe5SO3Ls0rG/GqiSGQ1MphZzJw4VdCpMsk1qyNmzpyuBo/PvjrtLTPr+XxK 81bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=ShuaCglHMPdgyal6GGIwZRaEUD77Ogg+O3HSaYQ63/E=; b=J1BifWbcWCB8pfoHS+ltM0af9JfUIY8H0wmEOaxMRDEPTJakmsnJI6QPfKOXxagqIY JikuE9o36dcSQuVWEyxu6DTHR5ErsVUv3hg+VfyNQCgCNEpKHnkL8LOSA5HW7Ta77rts M6dfOy2ZZhhGJENVtybaXPg7EvfuXCv0Cn8efkOl3qsg7Fgj/EmOsmjG6SMeL7QLYx98 ttEyM52cEIp1M9XlylK5j1NuNw6mI7SktjV8BYhyQwk0p+Z8PLD4SNP9XRsEC3QB2eWa VM+4SfxNVgxCk991oy8tZo0VqPW6XpojT37cFeM3TKJra9ndATyPsxJFWpSYl40mYwvu PdrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n9si24367930pgr.280.2019.06.04.13.30.53; Tue, 04 Jun 2019 13:31:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726460AbfFDU3g (ORCPT + 99 others); Tue, 4 Jun 2019 16:29:36 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:46766 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726312AbfFDU3g (ORCPT ); Tue, 4 Jun 2019 16:29:36 -0400 Received: by mail-ot1-f65.google.com with SMTP id z23so5878179ote.13; Tue, 04 Jun 2019 13:29:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ShuaCglHMPdgyal6GGIwZRaEUD77Ogg+O3HSaYQ63/E=; b=CVlglNZ3fYT4sh8jRWA/ENRM9vOKKJjFYdOARzZ1z7pILRDYvcSXjw8hfk1n5DZB46 +Wpw97xUeg2KhxiPjzKvwzLsF4dV6hXeSdH9knYD608BgLnxcm9eaq0nwetMrWFA2ApI rxwP6BdCLtfkLy2d0piYEl8AX12J58q19PkEWtxIrskemvH+Wl+qSz0NsaWJSBBECyqI Lb5R+24tRU25cY7s9uj8/UoIX3Xrsr5ytlM3S4XF1ZmnG0bNJ/XY8onMb37q18vDnRAi J1WW72rkqXCF3ZWLffe8szpKfcSSq/sg6akDLZqg3VKxZlCt/f+y/nNBeEmHOkipSmIY 20YA== X-Gm-Message-State: APjAAAXu9ecDkXRoi33uMBcaZLaumAoKA0RyxksZQ/bcH53NIoGyd+Ie 8NZFDzxcoDMTtK5VX6G2HzcEB4nGkdQ= X-Received: by 2002:a9d:6c46:: with SMTP id g6mr457114otq.162.1559680175033; Tue, 04 Jun 2019 13:29:35 -0700 (PDT) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com. [209.85.210.54]) by smtp.gmail.com with ESMTPSA id v13sm6022078oth.23.2019.06.04.13.29.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 13:29:34 -0700 (PDT) Received: by mail-ot1-f54.google.com with SMTP id t24so7102820otl.12; Tue, 04 Jun 2019 13:29:33 -0700 (PDT) X-Received: by 2002:a9d:6058:: with SMTP id v24mr441623otj.110.1559680173629; Tue, 04 Jun 2019 13:29:33 -0700 (PDT) MIME-Version: 1.0 References: <20190501092841.9026-1-rasmus.villemoes@prevas.dk> <20190513111442.25724-1-rasmus.villemoes@prevas.dk> In-Reply-To: <20190513111442.25724-1-rasmus.villemoes@prevas.dk> From: Li Yang Date: Tue, 4 Jun 2019 15:29:22 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/6] soc/fsl/qe: cleanups and new DT binding To: Rasmus Villemoes Cc: "devicetree@vger.kernel.org" , Qiang Zhao , Mark Rutland , "linux-kernel@vger.kernel.org" , Scott Wood , Rasmus Villemoes , Rob Herring , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 13, 2019 at 6:17 AM Rasmus Villemoes wrote: > > This small series consists of some small cleanups and simplifications > of the QUICC engine driver, and introduces a new DT binding that makes > it much easier to support other variants of the QUICC engine IP block > that appears in the wild: There's no reason to expect in general that > the number of valid SNUMs uniquely determines the set of such, so it's > better to simply let the device tree specify the values (and, > implicitly via the array length, also the count). > > Which tree should this go through? > > v3: > - Move example from commit log into binding document (adapting to > MPC8360 which the existing example pertains to). > - Add more review tags. > - Fix minor style issue. > > v2: > - Address comments from Christophe Leroy > - Add his Reviewed-by to 1/6 and 3/6 > - Split DT binding update to separate patch as per > Documentation/devicetree/bindings/submitting-patches.txt > > Rasmus Villemoes (6): > soc/fsl/qe: qe.c: drop useless static qualifier > soc/fsl/qe: qe.c: reduce static memory footprint by 1.7K > soc/fsl/qe: qe.c: introduce qe_get_device_node helper > dt-bindings: soc/fsl: qe: document new fsl,qe-snums binding > soc/fsl/qe: qe.c: support fsl,qe-snums property > soc/fsl/qe: qe.c: fold qe_get_num_of_snums into qe_snums_init Series applied to soc/fsl for-next. Thanks! Regards, Leo > > .../devicetree/bindings/soc/fsl/cpm_qe/qe.txt | 13 +- > drivers/soc/fsl/qe/qe.c | 163 +++++++----------- > 2 files changed, 77 insertions(+), 99 deletions(-) > > -- > 2.20.1 >