Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6018242ybi; Tue, 4 Jun 2019 17:02:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqxn2UHblz+UF/zvL/6pZcK41Huh77eHnll6HQCz9NL65f+4JLlTrRaltyaLNxH6sp22/I5I X-Received: by 2002:a65:4c07:: with SMTP id u7mr471241pgq.93.1559692946931; Tue, 04 Jun 2019 17:02:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559692946; cv=none; d=google.com; s=arc-20160816; b=PUPvEKfYW4t8eyikc4hJzfc/0PrXYiAFOdBVgBheKHsYLbhpGZ3GvDp176QELjhYoj xitKaxzZH6KM+oSyx8OQCsdUBsMMF4nv2TsQgJUcJnYi56TWDPYrelVbEwUIQomxaYF0 4BTrTLnoi7Uh8A8kBBauzE0PSjYfCVXztA95oTh275ZrV+go2wtHaFI63Jfbd5J/mjJR I9KjlbBTHk7I9sSg8e6PVOb68gMJ5uwFDDOBiTzeGP6l7eD7mjI+2j7+2G/xNPOOsueD YZeEcVHTeVsN2++GlN6OpnktuaXqfPytIP790Jug95Afad15o52EPl3lXOt331skLVHs AQUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from; bh=5HGodIrzJJv/2Z8WX/TlHd7QCV+ynn/O0V7Glu3XS70=; b=sFAZAN3yFSu4g9+qSZVlEt7SbOpw3q+P5feMRPbTCiIFsamEuhqHkCAqb524D7pZEs zA6klXr5l7iXMU3Ocoi0OxwuqQcyPvVaY/iw1NRD1chtsbDZ/S68RGg5W5SOUnECkNTE 1Db/lOrdkFb/Jp+cej48zqWPDtxGVVRgW5pqbXamOsZ9KdJgflHBc8ALsU9/aStHXGT5 Vbw1goKUmugypFWZsOdOi6UAhrn7CaMObiVPwEsMwJKN8XK8yBxtuqeyacrN5OXZ18Jc 1DFDdOvtupEbspMi8DEJH7BOMvz1yvk2xbrY15WK1dM/r5Zsb3+FWKup2LcF97SZIKsK YALg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w185si30068738pfb.170.2019.06.04.17.02.08; Tue, 04 Jun 2019 17:02:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726604AbfFEAA4 (ORCPT + 99 others); Tue, 4 Jun 2019 20:00:56 -0400 Received: from anholt.net ([50.246.234.109]:50568 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726427AbfFEAA4 (ORCPT ); Tue, 4 Jun 2019 20:00:56 -0400 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 3FE4110A2DB7; Tue, 4 Jun 2019 17:00:55 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id J5PPjNu5RML4; Tue, 4 Jun 2019 17:00:54 -0700 (PDT) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 0254810A1128; Tue, 4 Jun 2019 17:00:53 -0700 (PDT) Received: by eliezer.anholt.net (Postfix, from userid 1000) id 728A22FE3AAE; Tue, 4 Jun 2019 17:00:53 -0700 (PDT) From: Eric Anholt To: Nicolas Saenz Julienne , stefan.wahren@i2se.com, Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Cc: mbrugger@suse.de, viresh.kumar@linaro.org, rjw@rjwysocki.net, sboyd@kernel.org, ptesarik@suse.com, linux-rpi-kernel@lists.infradead.org, ssuloev@orpaltech.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mturquette@baylibre.com, linux-pm@vger.kernel.org, Nicolas Saenz Julienne , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] clk: bcm2835: register Raspberry Pi's firmware clk device In-Reply-To: <20190604173223.4229-4-nsaenzjulienne@suse.de> References: <20190604173223.4229-1-nsaenzjulienne@suse.de> <20190604173223.4229-4-nsaenzjulienne@suse.de> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Tue, 04 Jun 2019 17:00:51 -0700 Message-ID: <87muiwzyrw.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Nicolas Saenz Julienne writes: > Registers clk-raspberrypi as a platform device as part of the driver's > probe sequence. Similar to how we have VCHI register platform devices for the services VCHI provides, shouldn't we have the firmware driver register the device for clk_raspberrypi? Or put the clk provider in the fw driver instead of a separate driver (no opinion on my part). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlz3BjMACgkQtdYpNtH8 nugXZxAApCxDEcQNUZSA82dd4rtrlp/1uMz/j6cXVe9KKGi7a52dfc8MEIvoZDbq PAN/yjpvQVJosHh+JOUmXzKOEd9seFx9/gZwzdb3/8VKNnkYAy0ugfAzAN6K1XFW eAV1rSbBAkAtrvL/FUK1WxMN+4yf/yMcY9ZVmKSML2A9KcwkQHpNISOidbfdMy5c NkqMl9lTD3XoE+VZgUUsLg440KidEOO5kKix7VhP5zQiQ9OG2RInZvhUthTz0qRS 9j+4XCyC7IPe8QpejvK9eocR0CW7sVbEaujUsScR1xSFLWGI11fPgCjnGDzBxzkN jzofDEUVgfM8hzX+sIJ/DXI7WNNf01H51c8h0H7fxII2U3nNw5WgsQvU8BdoyRS5 WZdWPUAwFMkdlZNqRL7WdJL15in11f5lfiSZjT+Hxp95y77Jf/esA5Wfg3N5KD5I MWfTvdku3c6IBNi7Iy+l1knz+FjyoV1wYgYtYrzjrZtrGsIssySU+ZrzIrECo/8s k8B5kM2CHq5GM1d82sqj1haF0IsfChjQQVfIzkKja/FHmpC1IJBAnYjGUas7L+Z8 LVbsHuYZX+yH6k5cMe6f7cljlmeyjaHLDerVVnqlKO7ByYFgbGZUMP8acuBIIrzd LyNFmfuctdyaiwCnR/0wEmMAWlzn+HvxM7G31vBGo4ihTnlPaS0= =dVrD -----END PGP SIGNATURE----- --=-=-=--