Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6112659ybi; Tue, 4 Jun 2019 19:16:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7oyr2RpDyXQRvmRdCcmPI0SbY1SuPr3ZY9LMAEUzfORCUaLi3kaK4pYqNCFm439dSWnex X-Received: by 2002:a17:90a:2627:: with SMTP id l36mr12652524pje.71.1559700997965; Tue, 04 Jun 2019 19:16:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559700997; cv=none; d=google.com; s=arc-20160816; b=jviVsYwSicxUlhhS+Hp0LswmFaaGGbxK0Tzunaexa+Sj5UicAhsEmdKnakh9mi4rob tsJDal1ou6pgwPz4l7+SUcPe8UjDvsSn8AZ1FMQ9+1on1z4Q5mrGORMRuDw2b4Md+O1P z6HYpLgjXW/HwI51ocytzD5fnrYQ+IPU5ck5oCmd98bc84hLY6TxIOmu75rq9WV4VEQE 64N1s7UKazXXYjlfo4xxwjdzZWkMAuUpT5Xab1I/cCbtagD1I3ae5Mu6CMfhtXJbrK91 7JeHCLuy00q9JxSyh2j3EvJG2eSvCpcEYJn7Adswt5R5DdAeIKL6sPZdL5cmu50WgPX1 MKiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=vGYATL7lKerrKTUV1eWjFKUy4cU2Egt2DpNjUAywJhM=; b=OC+vce0cMtZgE2Zp2d+mA4FeE1I/25Qb4LN/lL38IgXAzl26QdjRw7+e+fZUDjMtqo +oNL03F4uJNc2tnWcFkr6/EolSdYFy65tHMZZib7J3O5jh2Wl0j3atCIBgOTH9BI46bk iHjaVSwyVY6FinBZ4GauSwExOtaiAztB6cVTJfIbCNqYNY94f2r29ZQu6xIDfJGh2BdP vO5fpsrxX+ARamcwSaDgTVR5tjlyX7rRU8eiQFXGPGcW43+iaeScHt00YFP4tvyWSDj5 a23n+/kel3ddTcrpbcjVRyq0fttLE69ncjFO01I1AAQEw9PagFFzIL+jG4nRnGJME/6/ NIOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=QwBBcWdP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 67si24331300pla.356.2019.06.04.19.16.20; Tue, 04 Jun 2019 19:16:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=QwBBcWdP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726488AbfFECOL (ORCPT + 99 others); Tue, 4 Jun 2019 22:14:11 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:50106 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbfFECOK (ORCPT ); Tue, 4 Jun 2019 22:14:10 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x552DpVl036365; Wed, 5 Jun 2019 02:13:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=vGYATL7lKerrKTUV1eWjFKUy4cU2Egt2DpNjUAywJhM=; b=QwBBcWdP74ksA8zuUHuA1MuDeYbxUm8bsHvsyQj8wdYmWRIP31h22KysOCYs4n+xGLi/ CCA8LovIh3M282IQQO1ctKKVJNYbVHDDx3KECIwBzMUJHnhDiDMDsCOLrZxTmIz40Zz6 uGUA9zJfEnLaeC4Wrnzgsd+Fy6nWV9VGSUT/bHbnQyikHhEYPVwuNo2XpDVJ/XEurYTT KBAQyTY9E7+dBuQ4VjMeQ/4o2fMk+sld1pFLTlRQGOuRMgIW/6Bn7gFqtbAdw8/xD3dL ynW83VgyT1MdhS5iPSW/f2ikVu3oOcxs1/S4snzaMEDGB+8g5jY97+XgBNPxMPjFL1Wm SQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2suj0qg7gs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Jun 2019 02:13:59 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x552AwW9035898; Wed, 5 Jun 2019 02:11:59 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2swngknt4g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Jun 2019 02:11:59 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x552Bv6e013090; Wed, 5 Jun 2019 02:11:57 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 04 Jun 2019 19:11:57 -0700 To: Avri Altman Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Evan Green , Bean Huo , Pedro Sousa , Alim Akhtar , Avi Shchislowski , Alex Lemberg Subject: Re: [PATCH] scsi: ufs: Check that space was properly alloced in copy_query_response From: "Martin K. Petersen" Organization: Oracle Corporation References: <1558427062-5084-1-git-send-email-avri.altman@wdc.com> Date: Tue, 04 Jun 2019 22:11:54 -0400 In-Reply-To: <1558427062-5084-1-git-send-email-avri.altman@wdc.com> (Avri Altman's message of "Tue, 21 May 2019 11:24:22 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9278 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906050011 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9278 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906050012 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Avri, > struct ufs_dev_cmd is the main container that supports device management > commands. In the case of a read descriptor request, we assume that the > proper space was allocated in dev_cmd to hold the returning descriptor. > > This is no longer true, as there are flows that doesn't use dev_cmd > for device management requests, and was wrong in the first place. Applied to 5.2/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering