Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6128358ybi; Tue, 4 Jun 2019 19:41:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqz0li17WMmQU9uliWhYgcvCw5opbm2AE69jULFiA+As1y1l8+mCcA4n6naHuHS3PZBwHf8c X-Received: by 2002:a17:90b:d8f:: with SMTP id bg15mr158222pjb.78.1559702470209; Tue, 04 Jun 2019 19:41:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559702470; cv=none; d=google.com; s=arc-20160816; b=ZtKaUg18NfNNDylqGLMFv3xWcSiAvpTePs1UANn+/lXp4jt8t8Rk9iTqIceMxYT9Nx ITCtr64WMeExv+xMhswLGhrvdD5ZUKUtNdfU2cJmmTdI5RTGNvSB92vQrLfmkWo5Bd05 ChqKaQMiqHWkl5QVOXhZq1PE3KI6knIjlfj+0dMZqBJhE5d++DHXDCq4Fiw+0NAfUWZp mQq0II1+BOjKbrif5hiYL8TBUdEy69CT50AcXpI698rcm+MBzg7rraewtLK+NUwX7H1I 5PAcehF1p26+nIWqCGAkBxBSDKg9FPYU5b3KDIieOhMUF6yZixcCyS86PX99zzKFI1dP MW0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=z/la0Iaw8QvvEtAdeZ/2XourCSKmrS+ERTV018zk7cI=; b=j2g3Eg9pRQQMmvcxOxhQmm5X+0wFNDja8Vn1HqDYCVke+PLe7Y2ICP7/1aQNYiVPrd /w7YdSFxuwNc2FB11gDMrn/ZjPl+T9/Rbgus9o9xKvF/Bkr5kLOobNokpxOqLNPAzDor HqBdEGbYybg1FD4sj2ly7iG90+utN9cItD8CQv7Qong56aWXKVoU8e5uTgXMSuz4ACqO IY1XLdZ5wgUtoo8OX80NLxk0Rf28ORSwUIijRtDO2Mkpona64KPYnb+vr5IGv9b1sroT CnW5XVcIhfkjUq4YotfWbVeBk6o0+sfbIdY3uWj8hA+jdhJD8in+oeSm7d+gxH5LqCYZ fuNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="l/5PCHpN"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 9si21804291pfp.180.2019.06.04.19.40.52; Tue, 04 Jun 2019 19:41:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="l/5PCHpN"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbfFECjq (ORCPT + 99 others); Tue, 4 Jun 2019 22:39:46 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:41448 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbfFECjq (ORCPT ); Tue, 4 Jun 2019 22:39:46 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x552XZTP048759; Wed, 5 Jun 2019 02:39:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=z/la0Iaw8QvvEtAdeZ/2XourCSKmrS+ERTV018zk7cI=; b=l/5PCHpNUqUOkOl1KntQONU3PjFaETgfVfGLnBhy2cbt8wcY4T7Kl0nXn3uAorPiiSUO E0vga1hS/A1bmyi7LS3gePe/QahKsvyCnZAKp6BZbWejVqyiRm5hkCS2//YGNsBAvD3/ LeRw+su+tsvRP+FnYyVwIBsYdktkBT/cG06q+wW0bO8lU8y+AHmmW4EdLbBeN5xdgryM LBxOUYSOP2yguCUAW/wkOPYY/4/xJqC+UzBMBaIi7pqAkWCTJsI1SzDV6Pxv1RMuK200 QrSZ+5X2oAh7LoBWGy6lsKmtv23yvQeezAZTiyvwWum8eeTbms7/OpT0kHjx1ymEGgmK eQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2suj0qg94t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Jun 2019 02:39:26 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x552c2SX145348; Wed, 5 Jun 2019 02:39:25 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 2swnghp1kn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Jun 2019 02:39:25 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x552dM0N020688; Wed, 5 Jun 2019 02:39:22 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 04 Jun 2019 19:39:22 -0700 To: Nathan Chancellor Cc: Tyrel Datwyler , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Michael Ellerman Subject: Re: [PATCH v3] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190603221941.65432-1-natechancellor@gmail.com> <20190603234405.29600-1-natechancellor@gmail.com> Date: Tue, 04 Jun 2019 22:39:19 -0400 In-Reply-To: <20190603234405.29600-1-natechancellor@gmail.com> (Nathan Chancellor's message of "Mon, 3 Jun 2019 16:44:06 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9278 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=773 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906050014 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9278 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=814 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906050014 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nathan, > clang warns: > > drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used > uninitialized whenever switch case is taken [-Wsometimes-uninitialized] > case IBMVSCSI_HOST_ACTION_NONE: > ^~~~~~~~~~~~~~~~~~~~~~~~~ Applied to 5.3/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering