Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6144942ybi; Tue, 4 Jun 2019 20:07:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyoKE1qoKFrfNskUWM2PdPkMFHRhvBzTwQBFFgUzci8dsWpwnPgufWJuKvK9UfmZOpIvwho X-Received: by 2002:a63:1c10:: with SMTP id c16mr1161200pgc.442.1559704065616; Tue, 04 Jun 2019 20:07:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559704065; cv=none; d=google.com; s=arc-20160816; b=Oa04q3cQ+RPvDBqmOvbVo3iczHi4hENdvgd0CFvCSLzrqVvMGAAl0KaqfMU926OugZ Ydhxxikr1t+jHNRZ7fesynZa5lg7ZA/CedNP+7K+Bn4TwINHJp9bc0KGUuF7tAp3yTU3 /ja8X7IUkkzdfFcxjifJEJUEaHwrMJoL9asDB139n62Cn40mhrH1FmB9bg+Bgv+t55sf 0hj+9wIiDTVwR+/wAvhGLphCiK31W8ukgn+HlJIlwS8WGcjfIjh9FycZeGCAzYCS13du Jeqrqnl7ZymocfpUk76TomSRSpXFhzVUgxQCAHLkizYopQnx8bqgm9rhCsk9EVUHR5cZ EPbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=urdH7fAO305xMe0jWevNDfas+YNPwNmO9kKb0LyIsWY=; b=r0Jn8u5Rz/d6qQzEl2uQsOoNFLO8yjYgz2ESxle2MtreAH34B1EMKD6yknoYFDIFbu Qdktp4hHAmqfmDwZYqCO4XLQvF5cNit/Yy6htTVyrlApBbkCrQqiOwYytUY0xJSLtSff KK/Vxi0rUJuggbLvA755WWv3G2LtvgA6lBlVE6RP4m0y8oo0amXhOutudX1fgsKZLi2L nPjqx4RZkWUB7erdNpYmaspFTvBgoXaYt9t2l61PdtZXayDQy6ZdreJMUGh8PlKuLsNw TMlZn1OtPbYAkzl2HCpDY6hZ2ADGOMf/XGi4XysWQYbrwpUcrNh9MXFUgxrVVejIN4N3 MiMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m11si24497101pjl.64.2019.06.04.20.07.27; Tue, 04 Jun 2019 20:07:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726631AbfFEDGI (ORCPT + 99 others); Tue, 4 Jun 2019 23:06:08 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56314 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726354AbfFEDGI (ORCPT ); Tue, 4 Jun 2019 23:06:08 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1450A150477E2; Tue, 4 Jun 2019 20:06:08 -0700 (PDT) Date: Tue, 04 Jun 2019 20:06:07 -0700 (PDT) Message-Id: <20190604.200607.239727257233292079.davem@davemloft.net> To: doshir@vmware.com Cc: netdev@vger.kernel.org, pv-drivers@vmware.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] vmxnet3: turn off lro when rxcsum is disabled From: David Miller In-Reply-To: <20190604065838.22243-1-doshir@vmware.com> References: <20190604065838.22243-1-doshir@vmware.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 04 Jun 2019 20:06:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ronak Doshi Date: Mon, 3 Jun 2019 23:58:38 -0700 > Currently, when rx csum is disabled, vmxnet3 driver does not turn > off lro, which can cause performance issues if user does not turn off > lro explicitly. This patch adds fix_features support which is used to > turn off LRO whenever RXCSUM is disabled. > > Signed-off-by: Ronak Doshi > Acked-by: Rishi Mehta Applied.