Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6224051ybi;
        Tue, 4 Jun 2019 21:16:07 -0700 (PDT)
X-Google-Smtp-Source: APXvYqzQ9hM9inopWOys74LtQThUu3EhIG2lFF6W8n5Yr2Ks4eQUe2gBKGPom9INBOvGze1tbloB
X-Received: by 2002:a65:5684:: with SMTP id v4mr1597665pgs.160.1559708167379;
        Tue, 04 Jun 2019 21:16:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1559708167; cv=none;
        d=google.com; s=arc-20160816;
        b=fJhIoFnucwHqCYW+9IXcQQjSmz+Fihu6vowstNf0uAgRH+i8fOtszRIXOjU8D83b4q
         t4v+WNrroH63rufpj7V0Kn0kI+hONEQRdGTVmfAOVTxPpT4W5ReXp1/l4iUo3iyGGz7f
         KGXf5cS4UF3Tho4K9CD0F76kMnm8Mow594ILIqEX9s1ZGVdGMWvOuze4i6UPXC1Ov4a9
         FDLGe2SqLbHGVZPWDunXOkQ2yjTZDOio24mc3I1+L20RolguqsgzwxHI7eHGKKj0wC5h
         D54gA/phqLqFMr8IdWQ5Y//UW556HH00E1xpRFrO9VGQOrM482C/N+O+jNOmqhzlOC9U
         QAQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=2B/B0prAKkIbjLIXSxxyPuwJGhJKz6fYqry9vA7T2YQ=;
        b=G/7ljpOaru9OYugKInyroIwC8bvj76mi9Iew8u52qbtKwI43539YBOXzqkqXj+WQ1u
         uFXgUU5HW0SV3dw4isZk/J8aIqSIxA6VWZVbpobPOEYs76R4mop1nzC3LgHNrZA2U7cZ
         wKneZJBT6vq0kXgHiyevEmUS2FGU6+P6zWtrDdSQ7i8PlwuFDvY0vcxmlwib7DSQ1fj8
         7KPHVRzVgKGr6Iz6L5IDXdNX3yONt2zHQ/yYg1X/9oavZW12hJlWYC92g04LIHm0WjL6
         gs8QJwWSLFYvqcJQoa9cEJeOndgxpTwxNWmlK/N0IRttK5iGlY19Vz3LtfFQFrpfkJnr
         J7KA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=2YKq0Ebk;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id g9si25182248pgq.563.2019.06.04.21.15.49;
        Tue, 04 Jun 2019 21:16:07 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=2YKq0Ebk;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726554AbfFEEOT (ORCPT <rfc822;chenc2371@gmail.com> + 99 others);
        Wed, 5 Jun 2019 00:14:19 -0400
Received: from mail.kernel.org ([198.145.29.99]:46354 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725268AbfFEEOT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Jun 2019 00:14:19 -0400
Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 8AA582083E;
        Wed,  5 Jun 2019 04:14:18 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1559708058;
        bh=edj9xHB7N4qyQuNAjukxlep6ykAdTpTJSbDVobW9eyE=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=2YKq0Ebk1+cB6qr58E9NAgemhGn6EHb0HDouxp1tY+7raXsMRSeotQrm+P5lIPs1v
         L6mN1jBg0wqjF15WZC+qr2bLNQOb6kr4HaRV+v0csG/ttAlC9TpwLb3UFcUAR0mm1f
         QiE+/S8AFSkUzLizIkatXvaSNq3NKDwY8kGiTTn8=
Date:   Tue, 4 Jun 2019 21:14:18 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Roman Gushchin <guro@fb.com>
Cc:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <kernel-team@fb.com>, Johannes Weiner <hannes@cmpxchg.org>,
        Shakeel Butt <shakeelb@google.com>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Waiman Long <longman@redhat.com>
Subject: Re: [PATCH v6 00/10] mm: reparent slab memory on cgroup removal
Message-Id: <20190604211418.70d178253550d96da46cee21@linux-foundation.org>
In-Reply-To: <20190605024454.1393507-1-guro@fb.com>
References: <20190605024454.1393507-1-guro@fb.com>
X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 4 Jun 2019 19:44:44 -0700 Roman Gushchin <guro@fb.com> wrote:

> So instead of trying to find a maybe non-existing balance, let's do reparent
> the accounted slabs to the parent cgroup on cgroup removal.

s/slabs/slab caches/.  Take more care with the terminology, please...

> There is a bonus: currently we do release empty kmem_caches on cgroup
> removal, however all other are waiting for the releasing of the memory cgroup.
> These refactorings allow kmem_caches to be released as soon as they
> become inactive and free.

Unclear.

s/All other/releasing of all non-empty slab caches depends upon the releasing/

I think?