Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6269301ybi; Tue, 4 Jun 2019 21:59:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqyKnbTYCUlh240vIb8lSVTogX5EvuXPE4jw1ZlOVIq070gvG5c2iavSsF5iEs7MGBetoBf0 X-Received: by 2002:a17:90a:9503:: with SMTP id t3mr41272256pjo.47.1559710764270; Tue, 04 Jun 2019 21:59:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559710764; cv=none; d=google.com; s=arc-20160816; b=oR35rzpgABS7wnTrv0NqxsBrCGsxfP/ePmCgVzLIK9kYNHhTDHcxBVTMnzIgUJTatz gDkivyRJLeUziBogukciQIu9FZhVtlkC1JaoZfVajQVbPuRpjfs4H+wLYa/OZnjFQ/vD f/0389ZhYc+UAl/QY1GLjHQqjPLuPD1TMx9wWxrubBRlP6tTnXthdNbCB5Eofm1eAPhb M4tI3+cbs7H1t0CCGArkVeI+TRHk8ICYMqsyP7MCnZi3ArZuJic+utKzCOf8gWTvjdZb 8G3Xr9wVwIl86xnsjcDnWwCiZWmW0A6atCNcZkBJZ9scCW3w87WFo5xwSsFi50VXaxI1 co4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=G3o44A9+gEGot8gIpQ6nWR7VSfa60cI0rlZugeFfA2Q=; b=X8znhwV2Ce6qsHc/1jmwtfk2Y9m/bE6FdKK/CO236/OgokuJxfUv+er35xdYyPZvxL Zoq7GeZ6MIiJVdeecjOpq7XMxD/Fa1TNMME3T442cXFzZElWbvbFAQShGBzOQM1HM6E+ WblB/fUe81hDr6Wl0Qdof83NGDMw/52NQ8lsePATJogFRA3dDuamKuzb72zfoL48riYh 5vhk53XcRBfhY0jlP4MYvrhskzIXv0zha69WlmBMwo08YXjLkJEuki7WrijAaVTA8OeW 3rezzjhq6blRTfJrBo91aNi6Ic6mJJNClg7+1tmNPFgRrFX3JqbvfwdfTsaomxt+Qhyr QI0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 61si24464931plb.177.2019.06.04.21.59.03; Tue, 04 Jun 2019 21:59:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726597AbfFEE5H (ORCPT + 99 others); Wed, 5 Jun 2019 00:57:07 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:45211 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbfFEE5G (ORCPT ); Wed, 5 Jun 2019 00:57:06 -0400 Received: by mail-wr1-f67.google.com with SMTP id f9so3273210wre.12 for ; Tue, 04 Jun 2019 21:57:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=G3o44A9+gEGot8gIpQ6nWR7VSfa60cI0rlZugeFfA2Q=; b=C7q3lpal7DSF8t2zuQaSNfXs1Fj9KHIp6evRA94cE4Hne0GNWqQjWqk9CMo2/fAd/G 40oM/qyrjV/gpZ50/gICM6zu470RlhyTwpN0x+H4tnx5mRdfM9ql3HFaqBu2mCl5mY2f NhPPdqvM9xOKrZgcVe8N44HcE5k3gIlfHKRtb4k5mnebKOtTP5owfHTvr+i7YP0q6K0X 4QCCBknrN2YNbXOqlHWfZNtttWrgCAcQE4D5IQKza0q8IKpIt8RnLs2GpZRO6mbYkHC3 4Dteoq4nuke90fG+olwns1XfSqASp6yKc7PlEPb/SChAENXy7yL+XOQfMsdJgZ7DzYNH q2BQ== X-Gm-Message-State: APjAAAWhVNPxx2C1iXWHxVCBgffp78AGEY+f3dWNgiOx5IqmhSfWPjh5 eYoguRARNQo07N0Tpzmg33ntfx3w X-Received: by 2002:adf:dd51:: with SMTP id u17mr9071452wrm.218.1559710624636; Tue, 04 Jun 2019 21:57:04 -0700 (PDT) Received: from [192.168.1.49] (185-219-167-24-static.vivo.cz. [185.219.167.24]) by smtp.gmail.com with ESMTPSA id y132sm29699531wmd.35.2019.06.04.21.57.03 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 21:57:03 -0700 (PDT) Subject: Re: [PATCH] wcd9335: fix a incorrect use of kstrndup() To: Gen Zhang , broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, wen.yang99@zte.com.cn Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20190529015305.GA4700@zhanggen-UX430UQ> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBtKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jej6JAjgEEwECACIFAk6S6NgCGwMGCwkIBwMCBhUIAgkKCwQWAgMB Ah4BAheAAAoJEL0lsQQGtHBJgDsP/j9wh0vzWXsOPO3rDpHjeC3BT5DKwjVN/KtP7uZttlkB duReCYMTZGzSrmK27QhCflZ7Tw0Naq4FtmQSH8dkqVFugirhlCOGSnDYiZAAubjTrNLTqf7e 5poQxE8mmniH/Asg4KufD9bpxSIi7gYIzaY3hqvYbVF1vYwaMTujojlixvesf0AFlE4x8WKs wpk43fmo0ZLcwObTnC3Hl1JBsPujCVY8t4E7zmLm7kOB+8EHaHiRZ4fFDWweuTzRDIJtVmrH LWvRDAYg+IH3SoxtdJe28xD9KoJw4jOX1URuzIU6dklQAnsKVqxz/rpp1+UVV6Ky6OBEFuoR 613qxHCFuPbkRdpKmHyE0UzmniJgMif3v0zm/+1A/VIxpyN74cgwxjhxhj/XZWN/LnFuER1W zTHcwaQNjq/I62AiPec5KgxtDeV+VllpKmFOtJ194nm9QM9oDSRBMzrG/2AY/6GgOdZ0+qe+ 4BpXyt8TmqkWHIsVpE7I5zVDgKE/YTyhDuqYUaWMoI19bUlBBUQfdgdgSKRMJX4vE72dl8BZ +/ONKWECTQ0hYntShkmdczcUEsWjtIwZvFOqgGDbev46skyakWyod6vSbOJtEHmEq04NegUD al3W7Y/FKSO8NqcfrsRNFWHZ3bZ2Q5X0tR6fc6gnZkNEtOm5fcWLY+NVz4HLaKrJuQINBE6S 54YBEADPnA1iy/lr3PXC4QNjl2f4DJruzW2Co37YdVMjrgXeXpiDvneEXxTNNlxUyLeDMcIQ K8obCkEHAOIkDZXZG8nr4mKzyloy040V0+XA9paVs6/ice5l+yJ1eSTs9UKvj/pyVmCAY1Co SNN7sfPaefAmIpduGacp9heXF+1Pop2PJSSAcCzwZ3PWdAJ/w1Z1Dg/tMCHGFZ2QCg4iFzg5 Bqk4N34WcG24vigIbRzxTNnxsNlU1H+tiB81fngUp2pszzgXNV7CWCkaNxRzXi7kvH+MFHu2 1m/TuujzxSv0ZHqjV+mpJBQX/VX62da0xCgMidrqn9RCNaJWJxDZOPtNCAWvgWrxkPFFvXRl t52z637jleVFL257EkMI+u6UnawUKopa+Tf+R/c+1Qg0NHYbiTbbw0pU39olBQaoJN7JpZ99 T1GIlT6zD9FeI2tIvarTv0wdNa0308l00bas+d6juXRrGIpYiTuWlJofLMFaaLYCuP+e4d8x rGlzvTxoJ5wHanilSE2hUy2NSEoPj7W+CqJYojo6wTJkFEiVbZFFzKwjAnrjwxh6O9/V3O+Z XB5RrjN8hAf/4bSo8qa2y3i39cuMT8k3nhec4P9M7UWTSmYnIBJsclDQRx5wSh0Mc9Y/psx9 B42WbV4xrtiiydfBtO6tH6c9mT5Ng+d1sN/VTSPyfQARAQABiQIfBBgBAgAJBQJOkueGAhsM AAoJEL0lsQQGtHBJN7UQAIDvgxaW8iGuEZZ36XFtewH56WYvVUefs6+Pep9ox/9ZXcETv0vk DUgPKnQAajG/ViOATWqADYHINAEuNvTKtLWmlipAI5JBgE+5g9UOT4i69OmP/is3a/dHlFZ3 qjNk1EEGyvioeycJhla0RjakKw5PoETbypxsBTXk5EyrSdD/I2Hez9YGW/RcI/WC8Y4Z/7FS ITZhASwaCOzy/vX2yC6iTx4AMFt+a6Z6uH/xGE8pG5NbGtd02r+m7SfuEDoG3Hs1iMGecPyV XxCVvSV6dwRQFc0UOZ1a6ywwCWfGOYqFnJvfSbUiCMV8bfRSWhnNQYLIuSv/nckyi8CzCYIg c21cfBvnwiSfWLZTTj1oWyj5a0PPgGOdgGoIvVjYXul3yXYeYOqbYjiC5t99JpEeIFupxIGV ciMk6t3pDrq7n7Vi/faqT+c4vnjazJi0UMfYnnAzYBa9+NkfW0w5W9Uy7kW/v7SffH/2yFiK 9HKkJqkN9xYEYaxtfl5pelF8idoxMZpTvCZY7jhnl2IemZCBMs6s338wS12Qro5WEAxV6cjD VSdmcD5l9plhKGLmgVNCTe8DPv81oDn9s0cIRLg9wNnDtj8aIiH8lBHwfUkpn32iv0uMV6Ae sLxhDWfOR4N+wu1gzXWgLel4drkCJcuYK5IL1qaZDcuGR8RPo3jbFO7Y Message-ID: <7573d8ce-7160-39b1-8901-be9155c451a1@suse.cz> Date: Wed, 5 Jun 2019 06:57:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190529015305.GA4700@zhanggen-UX430UQ> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29. 05. 19, 3:53, Gen Zhang wrote: > In wcd9335_codec_enable_dec(), 'widget_name' is allocated by kstrndup(). > However, according to doc: "Note: Use kmemdup_nul() instead if the size > is known exactly." Except the size is not known exactly. It is at most 15, not 15. Right? > So we should use kmemdup_nul() here instead of > kstrndup(). > > Signed-off-by: Gen Zhang > --- > diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c > index a04a7ce..85737fe 100644 > --- a/sound/soc/codecs/wcd9335.c > +++ b/sound/soc/codecs/wcd9335.c > @@ -2734,7 +2734,7 @@ static int wcd9335_codec_enable_dec(struct snd_soc_dapm_widget *w, > char *dec; > u8 hpf_coff_freq; > > - widget_name = kstrndup(w->name, 15, GFP_KERNEL); > + widget_name = kmemdup_nul(w->name, 15, GFP_KERNEL); > if (!widget_name) > return -ENOMEM; > thanks, -- js suse labs