Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6335030ybi; Tue, 4 Jun 2019 23:02:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqxkg0ft+Pg3kjvVfj8L81nfAsDlKMUHsSYCa5W9TBTJSjkQwttlFu33YKi03Qng+9fgcwax X-Received: by 2002:a63:1b07:: with SMTP id b7mr2085923pgb.289.1559714563486; Tue, 04 Jun 2019 23:02:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559714563; cv=none; d=google.com; s=arc-20160816; b=b2BZS/ooYxo239NDT1HQrpKvAT0mVwAv3wkPdFgZcHGsOVBvjOALuCyTBvqTaxcI4d wCuePblE00autWBhUjWJ62p9tH8Pd296Mw3RUA4QnPZIdg4kLJ9W5F0cJsbXVNXrqKEZ qgkLN3maEuKvAo9rJ6ALpBM/nmX5EhwC/fnpwggWcNsdCPEYCbwczHYncRoEzLIspsNB g/9X7Lny+95Unnm8piGcj/9P9srrpQSLKZyEYbfgWFPwsPfBDUUYY0+H1CwLCoVe3er/ lCVYKSXAptprIXkV5EX/8/0+s+LN+7PSV3xqt1xXhcXgmj1VhpHvCCm9OS2L/2sJtDg0 f4Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=Jr87Gbws8ErCuxH3u7ORPLMbc3HC1qxus6riAj+j6cg=; b=P/2dYS1RehuDrRRx9gvFr7kN5TCHMlM3dF3pO3Zt9+7mPwfY3falkvxJoZ3VEKX/q5 0TC3o8/qBkhsXPK0lv320UN5MGC1tfjoj5gjFoe46U9beU8bVKgWCNM1dsglV96JQzbf Ljj/u3o+f1W0DMPkVzwyGhTxAuXZXWIWbOdWZaJBQsQNdSANheqSQ2O+AgTLEtzY/RKV 0k6lMAAfu0NFY4ICsgApGw3DOE+NvgGI4FPTcesGE/gxuUct06kHKT/Wqz8umkWI43EK E593LaNGEDD7s+rYeRRHpjQwFK8Lz8bFmYpQPu88ZbyKR90o2eCqtSB1k1f3xnu3320x cGsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m4si30092113pfb.134.2019.06.04.23.02.24; Tue, 04 Jun 2019 23:02:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726606AbfFEGAz (ORCPT + 99 others); Wed, 5 Jun 2019 02:00:55 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:33353 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726086AbfFEGAy (ORCPT ); Wed, 5 Jun 2019 02:00:54 -0400 Received: by mail-wr1-f68.google.com with SMTP id n9so5670554wru.0; Tue, 04 Jun 2019 23:00:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Jr87Gbws8ErCuxH3u7ORPLMbc3HC1qxus6riAj+j6cg=; b=bFeyXJdEmCvqwRvb0dk5EN9SJXVPISrlatq/ubsha2JXyx+brqfTiME73Jed8Ga2kp leE0OA4KPpf4mUMjOlMtI5QJKJ7XTtmruxJlLEeDNKlwgTR2k7iWxdYFe+6NFmTpJVDC axTmA1p/1zvRGirYRZX0eSI7s2xKiXezD6iWpd/PiuA9NqaTa8/uExwpV3qZ9PvO90HV btm2JbNXqBG/jAFOQf+Xi0lO38BpUXdydPGrtT+X5c9MNusn1BtCVlUQbBhjNZnMviqw ApLHtb4121VJaPSRLtR+W7ar5vt7U0cX/Aim2Faug7ia56PemoisCDHpaBeVla/3vkvY WSUg== X-Gm-Message-State: APjAAAXyfNn1Q3tOycwygnjQxjjZSGiMDNGGeIYatGCHdoXLrdyvWyXV hVNEeBjq3vcjURp3fsAYTrey5MaO X-Received: by 2002:adf:dd91:: with SMTP id x17mr11865882wrl.291.1559714452100; Tue, 04 Jun 2019 23:00:52 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id 32sm53705912wra.35.2019.06.04.23.00.50 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 23:00:50 -0700 (PDT) Subject: Re: [PATCH] sg: Fix a double-fetch bug in drivers/scsi/sg.c To: Gen Zhang , martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190523023855.GA17852@zhanggen-UX430UQ> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBtKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jej6JAjgEEwECACIFAk6S6NgCGwMGCwkIBwMCBhUIAgkKCwQWAgMB Ah4BAheAAAoJEL0lsQQGtHBJgDsP/j9wh0vzWXsOPO3rDpHjeC3BT5DKwjVN/KtP7uZttlkB duReCYMTZGzSrmK27QhCflZ7Tw0Naq4FtmQSH8dkqVFugirhlCOGSnDYiZAAubjTrNLTqf7e 5poQxE8mmniH/Asg4KufD9bpxSIi7gYIzaY3hqvYbVF1vYwaMTujojlixvesf0AFlE4x8WKs wpk43fmo0ZLcwObTnC3Hl1JBsPujCVY8t4E7zmLm7kOB+8EHaHiRZ4fFDWweuTzRDIJtVmrH LWvRDAYg+IH3SoxtdJe28xD9KoJw4jOX1URuzIU6dklQAnsKVqxz/rpp1+UVV6Ky6OBEFuoR 613qxHCFuPbkRdpKmHyE0UzmniJgMif3v0zm/+1A/VIxpyN74cgwxjhxhj/XZWN/LnFuER1W zTHcwaQNjq/I62AiPec5KgxtDeV+VllpKmFOtJ194nm9QM9oDSRBMzrG/2AY/6GgOdZ0+qe+ 4BpXyt8TmqkWHIsVpE7I5zVDgKE/YTyhDuqYUaWMoI19bUlBBUQfdgdgSKRMJX4vE72dl8BZ +/ONKWECTQ0hYntShkmdczcUEsWjtIwZvFOqgGDbev46skyakWyod6vSbOJtEHmEq04NegUD al3W7Y/FKSO8NqcfrsRNFWHZ3bZ2Q5X0tR6fc6gnZkNEtOm5fcWLY+NVz4HLaKrJuQINBE6S 54YBEADPnA1iy/lr3PXC4QNjl2f4DJruzW2Co37YdVMjrgXeXpiDvneEXxTNNlxUyLeDMcIQ K8obCkEHAOIkDZXZG8nr4mKzyloy040V0+XA9paVs6/ice5l+yJ1eSTs9UKvj/pyVmCAY1Co SNN7sfPaefAmIpduGacp9heXF+1Pop2PJSSAcCzwZ3PWdAJ/w1Z1Dg/tMCHGFZ2QCg4iFzg5 Bqk4N34WcG24vigIbRzxTNnxsNlU1H+tiB81fngUp2pszzgXNV7CWCkaNxRzXi7kvH+MFHu2 1m/TuujzxSv0ZHqjV+mpJBQX/VX62da0xCgMidrqn9RCNaJWJxDZOPtNCAWvgWrxkPFFvXRl t52z637jleVFL257EkMI+u6UnawUKopa+Tf+R/c+1Qg0NHYbiTbbw0pU39olBQaoJN7JpZ99 T1GIlT6zD9FeI2tIvarTv0wdNa0308l00bas+d6juXRrGIpYiTuWlJofLMFaaLYCuP+e4d8x rGlzvTxoJ5wHanilSE2hUy2NSEoPj7W+CqJYojo6wTJkFEiVbZFFzKwjAnrjwxh6O9/V3O+Z XB5RrjN8hAf/4bSo8qa2y3i39cuMT8k3nhec4P9M7UWTSmYnIBJsclDQRx5wSh0Mc9Y/psx9 B42WbV4xrtiiydfBtO6tH6c9mT5Ng+d1sN/VTSPyfQARAQABiQIfBBgBAgAJBQJOkueGAhsM AAoJEL0lsQQGtHBJN7UQAIDvgxaW8iGuEZZ36XFtewH56WYvVUefs6+Pep9ox/9ZXcETv0vk DUgPKnQAajG/ViOATWqADYHINAEuNvTKtLWmlipAI5JBgE+5g9UOT4i69OmP/is3a/dHlFZ3 qjNk1EEGyvioeycJhla0RjakKw5PoETbypxsBTXk5EyrSdD/I2Hez9YGW/RcI/WC8Y4Z/7FS ITZhASwaCOzy/vX2yC6iTx4AMFt+a6Z6uH/xGE8pG5NbGtd02r+m7SfuEDoG3Hs1iMGecPyV XxCVvSV6dwRQFc0UOZ1a6ywwCWfGOYqFnJvfSbUiCMV8bfRSWhnNQYLIuSv/nckyi8CzCYIg c21cfBvnwiSfWLZTTj1oWyj5a0PPgGOdgGoIvVjYXul3yXYeYOqbYjiC5t99JpEeIFupxIGV ciMk6t3pDrq7n7Vi/faqT+c4vnjazJi0UMfYnnAzYBa9+NkfW0w5W9Uy7kW/v7SffH/2yFiK 9HKkJqkN9xYEYaxtfl5pelF8idoxMZpTvCZY7jhnl2IemZCBMs6s338wS12Qro5WEAxV6cjD VSdmcD5l9plhKGLmgVNCTe8DPv81oDn9s0cIRLg9wNnDtj8aIiH8lBHwfUkpn32iv0uMV6Ae sLxhDWfOR4N+wu1gzXWgLel4drkCJcuYK5IL1qaZDcuGR8RPo3jbFO7Y Message-ID: Date: Wed, 5 Jun 2019 08:00:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190523023855.GA17852@zhanggen-UX430UQ> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23. 05. 19, 4:38, Gen Zhang wrote: > In sg_write(), the opcode of the command is fetched the first time from > the userspace by __get_user(). Then the whole command, the opcode > included, is fetched again from userspace by __copy_from_user(). > However, a malicious user can change the opcode between the two fetches. > This can cause inconsistent data and potential errors as cmnd is used in > the following codes. > > Thus we should check opcode between the two fetches to prevent this. > > Signed-off-by: Gen Zhang > --- > diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c > index d3f1531..a2971b8 100644 > --- a/drivers/scsi/sg.c > +++ b/drivers/scsi/sg.c > @@ -694,6 +694,8 @@ sg_write(struct file *filp, const char __user *buf, size_t count, loff_t * ppos) > hp->flags = input_size; /* structure abuse ... */ > hp->pack_id = old_hdr.pack_id; > hp->usr_ptr = NULL; > + if (opcode != cmnd[0]) > + return -EINVAL; Isn't it too early to check cmnd which is copied only here: > if (__copy_from_user(cmnd, buf, cmd_size)) > return -EFAULT; > /* > --- > thanks, -- js suse labs