Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6339951ybi; Tue, 4 Jun 2019 23:06:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqzud53JJedDtfAIsnY6ADJg7I7Eu2a5tuP1EOgCrxu25ryfbF5znj9nwdNmcm5aI33/0FMV X-Received: by 2002:a17:90a:8c10:: with SMTP id a16mr41965160pjo.67.1559714810949; Tue, 04 Jun 2019 23:06:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559714810; cv=none; d=google.com; s=arc-20160816; b=u9L9kJJsVeRKR98y8UfZNhiT70uSs1476ps5USbEoH5aMeGb9uFM30JbB/ecyjYfa5 DCo/50d0cu+59UHPuBKB7fQCwXm81uChFZnYmAJI1KNPboA2m9xLh3dojoR4ymAQ1N5y M46MrI7TXXyhamVm33y6OsN9PYrlHxfPHv+5I/DImQ4R5g/khOPehsPmn8KKZe2oC53F EzC5QPz6GuJpcxLvLXgN76jcEjHl7gfn3Ob45vQLP9iJ3L5RwR9rZujcUfYeKuRh2GKz S5udeIrsQODAS/ckONH1M4rcRQ0SuGhq1kpOQ5NOpZvWTqqqmVKWNskznHAX326qDU9r XfWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=VhpdrklY1lapHIuK8NOWhS5glJHXEOW1eHgVui0fcpE=; b=QEggqlMEnzfPsnw+vbW+jznV9gFSVqXX22FcLVDVgGzvrGMHrJC0ubiIkqeq93LzZr HUFgXS5BgxwVDd1mn+unhP89V7uSsscBlAQjWxtfohppJu9P1rI52wbeD6R3RFGLxRt2 bb7jCKU7FPL272ONdmqhk9bxFupkCfFmeX+N5Sm0OG8zf1naEgf4QQhrV6WLiEoelBCS Q4bUynRXpr0b0O9+vNHle3Lf36CTHe42m2LxKe0PxadV9xtW6Ebh70Wk7pQa+9Wowyyq FC5VvrqfuGW/ZrQXI1dwoFcafJDbHrbPjWYkVLvGv0CVirKhvU0m/rEV8kiXE9Olid3P 8DmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w18si25269389plq.297.2019.06.04.23.06.34; Tue, 04 Jun 2019 23:06:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726554AbfFEGFW (ORCPT + 99 others); Wed, 5 Jun 2019 02:05:22 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38013 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbfFEGFV (ORCPT ); Wed, 5 Jun 2019 02:05:21 -0400 Received: by mail-wm1-f68.google.com with SMTP id t5so921405wmh.3 for ; Tue, 04 Jun 2019 23:05:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=VhpdrklY1lapHIuK8NOWhS5glJHXEOW1eHgVui0fcpE=; b=Kx+iSSk8mU1LzY4oXjScqr60+B4fW2QMTbHKC/EWH4zvl0PH0gZG2erQMDclI15jM6 8eztBFg3NYyPCJmefdWnbkp0n8C+DIxrGyz8/YWJyh/Ij9L5i8mc4UjzBk5jJ1XGD8Dv k9c0JIpNtIkNnHcEDpfKtSHyHlBO5KmdaM0tyJrU/wgP5lITD/9Uh0nkNh1XCkPkzhHM BwpuBunCgiSqeZFB/NrJVJaX1pQ+A+eDN7C5yyabySDoE51IZdAkNWiN0XA9+jOVTbld PgGaBQV8XAVnWk1kyBE7a1AMSQVTMlarAnRVn5ykTKBTuKR7j+tEPPxH1UDRMWdKDdRz 1SEw== X-Gm-Message-State: APjAAAX0aLVQbpeY0YPb5g0bh0dFk5XKtbIAxmVW30mnx82er0AH6kwX ToVa+BBFsl8oDWjWwNwQyKm2cKco X-Received: by 2002:a1c:a483:: with SMTP id n125mr20512407wme.172.1559714719969; Tue, 04 Jun 2019 23:05:19 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id j15sm9243851wrn.50.2019.06.04.23.05.18 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 23:05:19 -0700 (PDT) Subject: Re: [PATCH] dm-region-hash: Fix a missing-check bug in __rh_alloc() To: Gen Zhang , agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com Cc: linux-kernel@vger.kernel.org References: <20190524031248.GA6295@zhanggen-UX430UQ> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBtKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jej6JAjgEEwECACIFAk6S6NgCGwMGCwkIBwMCBhUIAgkKCwQWAgMB Ah4BAheAAAoJEL0lsQQGtHBJgDsP/j9wh0vzWXsOPO3rDpHjeC3BT5DKwjVN/KtP7uZttlkB duReCYMTZGzSrmK27QhCflZ7Tw0Naq4FtmQSH8dkqVFugirhlCOGSnDYiZAAubjTrNLTqf7e 5poQxE8mmniH/Asg4KufD9bpxSIi7gYIzaY3hqvYbVF1vYwaMTujojlixvesf0AFlE4x8WKs wpk43fmo0ZLcwObTnC3Hl1JBsPujCVY8t4E7zmLm7kOB+8EHaHiRZ4fFDWweuTzRDIJtVmrH LWvRDAYg+IH3SoxtdJe28xD9KoJw4jOX1URuzIU6dklQAnsKVqxz/rpp1+UVV6Ky6OBEFuoR 613qxHCFuPbkRdpKmHyE0UzmniJgMif3v0zm/+1A/VIxpyN74cgwxjhxhj/XZWN/LnFuER1W zTHcwaQNjq/I62AiPec5KgxtDeV+VllpKmFOtJ194nm9QM9oDSRBMzrG/2AY/6GgOdZ0+qe+ 4BpXyt8TmqkWHIsVpE7I5zVDgKE/YTyhDuqYUaWMoI19bUlBBUQfdgdgSKRMJX4vE72dl8BZ +/ONKWECTQ0hYntShkmdczcUEsWjtIwZvFOqgGDbev46skyakWyod6vSbOJtEHmEq04NegUD al3W7Y/FKSO8NqcfrsRNFWHZ3bZ2Q5X0tR6fc6gnZkNEtOm5fcWLY+NVz4HLaKrJuQINBE6S 54YBEADPnA1iy/lr3PXC4QNjl2f4DJruzW2Co37YdVMjrgXeXpiDvneEXxTNNlxUyLeDMcIQ K8obCkEHAOIkDZXZG8nr4mKzyloy040V0+XA9paVs6/ice5l+yJ1eSTs9UKvj/pyVmCAY1Co SNN7sfPaefAmIpduGacp9heXF+1Pop2PJSSAcCzwZ3PWdAJ/w1Z1Dg/tMCHGFZ2QCg4iFzg5 Bqk4N34WcG24vigIbRzxTNnxsNlU1H+tiB81fngUp2pszzgXNV7CWCkaNxRzXi7kvH+MFHu2 1m/TuujzxSv0ZHqjV+mpJBQX/VX62da0xCgMidrqn9RCNaJWJxDZOPtNCAWvgWrxkPFFvXRl t52z637jleVFL257EkMI+u6UnawUKopa+Tf+R/c+1Qg0NHYbiTbbw0pU39olBQaoJN7JpZ99 T1GIlT6zD9FeI2tIvarTv0wdNa0308l00bas+d6juXRrGIpYiTuWlJofLMFaaLYCuP+e4d8x rGlzvTxoJ5wHanilSE2hUy2NSEoPj7W+CqJYojo6wTJkFEiVbZFFzKwjAnrjwxh6O9/V3O+Z XB5RrjN8hAf/4bSo8qa2y3i39cuMT8k3nhec4P9M7UWTSmYnIBJsclDQRx5wSh0Mc9Y/psx9 B42WbV4xrtiiydfBtO6tH6c9mT5Ng+d1sN/VTSPyfQARAQABiQIfBBgBAgAJBQJOkueGAhsM AAoJEL0lsQQGtHBJN7UQAIDvgxaW8iGuEZZ36XFtewH56WYvVUefs6+Pep9ox/9ZXcETv0vk DUgPKnQAajG/ViOATWqADYHINAEuNvTKtLWmlipAI5JBgE+5g9UOT4i69OmP/is3a/dHlFZ3 qjNk1EEGyvioeycJhla0RjakKw5PoETbypxsBTXk5EyrSdD/I2Hez9YGW/RcI/WC8Y4Z/7FS ITZhASwaCOzy/vX2yC6iTx4AMFt+a6Z6uH/xGE8pG5NbGtd02r+m7SfuEDoG3Hs1iMGecPyV XxCVvSV6dwRQFc0UOZ1a6ywwCWfGOYqFnJvfSbUiCMV8bfRSWhnNQYLIuSv/nckyi8CzCYIg c21cfBvnwiSfWLZTTj1oWyj5a0PPgGOdgGoIvVjYXul3yXYeYOqbYjiC5t99JpEeIFupxIGV ciMk6t3pDrq7n7Vi/faqT+c4vnjazJi0UMfYnnAzYBa9+NkfW0w5W9Uy7kW/v7SffH/2yFiK 9HKkJqkN9xYEYaxtfl5pelF8idoxMZpTvCZY7jhnl2IemZCBMs6s338wS12Qro5WEAxV6cjD VSdmcD5l9plhKGLmgVNCTe8DPv81oDn9s0cIRLg9wNnDtj8aIiH8lBHwfUkpn32iv0uMV6Ae sLxhDWfOR4N+wu1gzXWgLel4drkCJcuYK5IL1qaZDcuGR8RPo3jbFO7Y Message-ID: <79ec221d-6970-3b30-0660-4a288a4c465e@suse.cz> Date: Wed, 5 Jun 2019 08:05:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190524031248.GA6295@zhanggen-UX430UQ> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24. 05. 19, 5:12, Gen Zhang wrote: > In function __rh_alloc(), the pointer nreg is allocated a memory space > via kmalloc(). And it is used in the following codes. However, when > there is a memory allocation error, kmalloc() fails. Thus null pointer > dereference may happen. And it will cause the kernel to crash. Therefore, > we should check the return value and handle the error. > Further, in __rh_find(), we should also check the return value and > handle the error. > > Signed-off-by: Gen Zhang > > --- > diff --git a/drivers/md/dm-region-hash.c b/drivers/md/dm-region-hash.c > index 1f76045..2fa1641 100644 > --- a/drivers/md/dm-region-hash.c > +++ b/drivers/md/dm-region-hash.c > @@ -290,8 +290,11 @@ static struct dm_region *__rh_alloc(struct dm_region_hash *rh, region_t region) > struct dm_region *reg, *nreg; > > nreg = mempool_alloc(&rh->region_pool, GFP_ATOMIC); > - if (unlikely(!nreg)) > + if (unlikely(!nreg)) { > nreg = kmalloc(sizeof(*nreg), GFP_NOIO | __GFP_NOFAIL); > + if (!nreg) > + return NULL; What's the purpose of checking NO_FAIL allocations? thanks, -- js suse labs