Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6345696ybi; Tue, 4 Jun 2019 23:12:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqwmFj46MS60hbVfOlQ3HqhYFmexgRtB1ahIUcRgkKaM4CeRSrtfPDSyka4i0vgND39CLpMN X-Received: by 2002:a17:90a:af8d:: with SMTP id w13mr41670906pjq.143.1559715154526; Tue, 04 Jun 2019 23:12:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559715154; cv=none; d=google.com; s=arc-20160816; b=AI1TcnKWRHN2wYj/09R81dNwr/Bb/rdzK4QVXQefnQ3AheGtei7hnQEucfLKNhiJjQ Eef34d2vb+abfXPPAG9e8fE/Yu6E1vYGwRivKu496ipsGW9BEh9WeEbiy0xxxaqEV/Jb TsYIKY0O/rk+IY3UazYYcQePpZuEOxgolLdv3LfT4qfTztah+zLoHKIuwoDKz+NxLvlu iijJpS7RAUbeRGlxMZM/6D6Yk9fYuUZVOh9gZa91MJRZbGhPdggWMrWDA8cD/J8SkuWn fSf2nwS50cS/olSQNrFVWYOh/dkmUzkMNfQVPUQw+7izG49mgkOhC8vhNTVUOKX0XT6t zmaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qxShGHJWv5x0Umo/U8E/yfgCR3VursiTtgs3HLuvbeE=; b=z2rLSgvbZqa1AewToFpOISYbjNbSogjQU4cwGLHCoiY7dKdN5U4LRE+O7BFbPHJx9D 5owm8Q3dGb650DCxOptVBQUmErGgQJxLBU6AVVn+J6IGGcpSR4mipYPpMLC2J9YuG1W3 xsBGwGeBy9XJ6To0zdNa0EpBFP2PMOS87GU5NqPjJgznM+3EwyDKiWCRRuFpYSh0FFjI XHbO8gUGphnlMqKUpRLq2J792xdX9OaXAWkr7MpVMrdIkGcSIR9+xwCkvY4YeLDpuDUh JsXumDfZTKKq/OjHktMQlx4p9kn0X4XCN8r2ZBp/+PPn+rSw6WnmBSKymyVzqhqqVobi dI7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=twASdHOl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j184si28140932pfb.88.2019.06.04.23.12.16; Tue, 04 Jun 2019 23:12:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=twASdHOl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726537AbfFEGKC (ORCPT + 99 others); Wed, 5 Jun 2019 02:10:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:53696 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726086AbfFEGKC (ORCPT ); Wed, 5 Jun 2019 02:10:02 -0400 Received: from dragon (li1264-180.members.linode.com [45.79.165.180]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C9D3D2075C; Wed, 5 Jun 2019 06:09:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559715001; bh=wTYwhYyVAwH/37258YCULY4b/DDUHUmOmKJEh2hkUE4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=twASdHOlRFsxs4nkKKw8rd0OyYEdxLC4gTqsSzQ0mLPfAHk84ARn1oy0XSQwuw4H8 Jq+QAgMrqoIaTG1d4aBHc2zX/R4SADoWn50kWf3ZapEh6vmoqqzAuDeXtEgOdiZsYq XLbgypHFHC7Bq+d9YTWOuGC+4tHDU3ZkfMquJAkY= Date: Wed, 5 Jun 2019 14:09:45 +0800 From: Shawn Guo To: Anson.Huang@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, leonard.crestez@nxp.com, abel.vesa@nxp.com, viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hyc.nju@gmail.com, Linux-imx@nxp.com Subject: Re: [PATCH RESEND 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling Message-ID: <20190605060944.GB29853@dragon> References: <20190524055101.3424-1-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190524055101.3424-1-Anson.Huang@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 01:51:00PM +0800, Anson.Huang@nxp.com wrote: > From: Anson Huang > > of_node_put() is called after of_match_node() successfully called, > then in the following error handling, of_node_put() is called again > which is unnecessary, this patch adjusts the location of of_node_put() > to avoid such scenario. > > Signed-off-by: Anson Huang > Reviewed-by: Leonard Crestez Applied both, thanks.