Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6361048ybi; Tue, 4 Jun 2019 23:28:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqx2hHE7FJ7jESrwZDM0rI87u7DDjoNHSzDHglnJiCGcEs59UKsF8Y7/nwM/DyIoX2gyy3kK X-Received: by 2002:a65:62c6:: with SMTP id m6mr2281942pgv.306.1559716112209; Tue, 04 Jun 2019 23:28:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559716112; cv=none; d=google.com; s=arc-20160816; b=Ql0od7+zjRmep8rJ4Ki75JghlL2DYLicUqvzUFYMN/kpyBmq2YyFuwD9lKlct0kTsy x1QMkQ4QcQjhtykL8Y5ds74xlnzt7Wdhp9ZEHpmj9t+3s+GZ0NpeW4oY1h61lIeLEYWs 83OkK9jjHLBwTE9M4NJ2oTEkd+p12wr2jv51UbooDLxWQwEIz7Ko1SsUh61LFE8wHlyk kBZccd1N1hEZSa9hp4CalmXaMxqmLiYgzKc1vf6zvRLCYs8Kf187RH781nVYfji3swIW 2KLhwQpud+51n8NinMQ6pgvmS0/MzisT/yz9MV4WJcZl448IknqoB8jLHl3osIkSAZSr DVKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=/U7gCaM27g91TlIwrBZwu7yX6OYmORgg7yud1ZYf6HA=; b=IIgwR4MX4Sf4y2h5ERpCn+4hfVJVbaLmz0cAdk51qzCEB0UJpTSpkoN9dZIXa5+CI3 c9L4cDEU6cxKC/zqBnVRvZ5/VxDcDqlxHjVAT0zcvcGbtjDOReyv+SlG+l+p2rHKqeeC diD/4yuB9WwDX51XoewyYuUGk9kgtEd8ZoMzB6gnODE3toFLj26/vIY5mOJazFReB9o/ LnSiv59c1U6HsfXTU5XxscjJXgaI/R5ZL5PUwlRewnd/MBsHjrQ+jIaWY/+8AU4tx9mS WaQaGLBY/cwBkgKDwBMS1tmjJsb+EaSBdB7E92z33hQgQ8ztkzDIySDbIRF2q4RSHBsp VKrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s80si25546754pgs.468.2019.06.04.23.28.14; Tue, 04 Jun 2019 23:28:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbfFEG1I (ORCPT + 99 others); Wed, 5 Jun 2019 02:27:08 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54153 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbfFEG1I (ORCPT ); Wed, 5 Jun 2019 02:27:08 -0400 Received: by mail-wm1-f67.google.com with SMTP id d17so967494wmb.3 for ; Tue, 04 Jun 2019 23:27:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/U7gCaM27g91TlIwrBZwu7yX6OYmORgg7yud1ZYf6HA=; b=Cm4G4hQ73baJiPt5Jm5jflybVlxJW3FsbFtw1C8Vog9EckdXLD5eDdkiy/UIuBzfTe aeDURpCp5BrfJIoIvip2f6aBC/pAz4ZBBzdzWy5rvUiqN448FU8bgEpD0JNJzQAzFu3Z hXmk64oZ7+WE4QuM0VTthAt5S/gC44HboI69OEJ6wrB0JsQH4KAz2scaXJ/JLpcvQLX/ IUDIzNxkArrS80OxaIIaQZ07d1l/OlIAvb4OgXtee/j1zjNuaM5JA7He1hS9ZbgPWzFC B/Q4YVCPYt/9tmxk8x6g0022f/FJlt4ag8im3gO3Be9plkd2TCZ6w88/eucZQ6xVEyiy +X5g== X-Gm-Message-State: APjAAAWziILsExy4E38l29AwUlUcjgSEuETtvluAwE87bvQk+BXOjQ1o I5WtT4remfPweDF63uu3dvU= X-Received: by 2002:a1c:2bc7:: with SMTP id r190mr13159077wmr.174.1559716025780; Tue, 04 Jun 2019 23:27:05 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id b5sm9221611wru.69.2019.06.04.23.27.04 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 23:27:04 -0700 (PDT) Subject: Re: [devm_kfree() usage] When should devm_kfree() be used? To: Gen Zhang , rafael@kernel.org, gregkh@linuxfoundation.org Cc: jonathanh@nvidia.com, linux-kernel@vger.kernel.org, luojiaxing@huawei.com References: <20190525020305.GA10933@zhanggen-UX430UQ> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBtKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jej6JAjgEEwECACIFAk6S6NgCGwMGCwkIBwMCBhUIAgkKCwQWAgMB Ah4BAheAAAoJEL0lsQQGtHBJgDsP/j9wh0vzWXsOPO3rDpHjeC3BT5DKwjVN/KtP7uZttlkB duReCYMTZGzSrmK27QhCflZ7Tw0Naq4FtmQSH8dkqVFugirhlCOGSnDYiZAAubjTrNLTqf7e 5poQxE8mmniH/Asg4KufD9bpxSIi7gYIzaY3hqvYbVF1vYwaMTujojlixvesf0AFlE4x8WKs wpk43fmo0ZLcwObTnC3Hl1JBsPujCVY8t4E7zmLm7kOB+8EHaHiRZ4fFDWweuTzRDIJtVmrH LWvRDAYg+IH3SoxtdJe28xD9KoJw4jOX1URuzIU6dklQAnsKVqxz/rpp1+UVV6Ky6OBEFuoR 613qxHCFuPbkRdpKmHyE0UzmniJgMif3v0zm/+1A/VIxpyN74cgwxjhxhj/XZWN/LnFuER1W zTHcwaQNjq/I62AiPec5KgxtDeV+VllpKmFOtJ194nm9QM9oDSRBMzrG/2AY/6GgOdZ0+qe+ 4BpXyt8TmqkWHIsVpE7I5zVDgKE/YTyhDuqYUaWMoI19bUlBBUQfdgdgSKRMJX4vE72dl8BZ +/ONKWECTQ0hYntShkmdczcUEsWjtIwZvFOqgGDbev46skyakWyod6vSbOJtEHmEq04NegUD al3W7Y/FKSO8NqcfrsRNFWHZ3bZ2Q5X0tR6fc6gnZkNEtOm5fcWLY+NVz4HLaKrJuQINBE6S 54YBEADPnA1iy/lr3PXC4QNjl2f4DJruzW2Co37YdVMjrgXeXpiDvneEXxTNNlxUyLeDMcIQ K8obCkEHAOIkDZXZG8nr4mKzyloy040V0+XA9paVs6/ice5l+yJ1eSTs9UKvj/pyVmCAY1Co SNN7sfPaefAmIpduGacp9heXF+1Pop2PJSSAcCzwZ3PWdAJ/w1Z1Dg/tMCHGFZ2QCg4iFzg5 Bqk4N34WcG24vigIbRzxTNnxsNlU1H+tiB81fngUp2pszzgXNV7CWCkaNxRzXi7kvH+MFHu2 1m/TuujzxSv0ZHqjV+mpJBQX/VX62da0xCgMidrqn9RCNaJWJxDZOPtNCAWvgWrxkPFFvXRl t52z637jleVFL257EkMI+u6UnawUKopa+Tf+R/c+1Qg0NHYbiTbbw0pU39olBQaoJN7JpZ99 T1GIlT6zD9FeI2tIvarTv0wdNa0308l00bas+d6juXRrGIpYiTuWlJofLMFaaLYCuP+e4d8x rGlzvTxoJ5wHanilSE2hUy2NSEoPj7W+CqJYojo6wTJkFEiVbZFFzKwjAnrjwxh6O9/V3O+Z XB5RrjN8hAf/4bSo8qa2y3i39cuMT8k3nhec4P9M7UWTSmYnIBJsclDQRx5wSh0Mc9Y/psx9 B42WbV4xrtiiydfBtO6tH6c9mT5Ng+d1sN/VTSPyfQARAQABiQIfBBgBAgAJBQJOkueGAhsM AAoJEL0lsQQGtHBJN7UQAIDvgxaW8iGuEZZ36XFtewH56WYvVUefs6+Pep9ox/9ZXcETv0vk DUgPKnQAajG/ViOATWqADYHINAEuNvTKtLWmlipAI5JBgE+5g9UOT4i69OmP/is3a/dHlFZ3 qjNk1EEGyvioeycJhla0RjakKw5PoETbypxsBTXk5EyrSdD/I2Hez9YGW/RcI/WC8Y4Z/7FS ITZhASwaCOzy/vX2yC6iTx4AMFt+a6Z6uH/xGE8pG5NbGtd02r+m7SfuEDoG3Hs1iMGecPyV XxCVvSV6dwRQFc0UOZ1a6ywwCWfGOYqFnJvfSbUiCMV8bfRSWhnNQYLIuSv/nckyi8CzCYIg c21cfBvnwiSfWLZTTj1oWyj5a0PPgGOdgGoIvVjYXul3yXYeYOqbYjiC5t99JpEeIFupxIGV ciMk6t3pDrq7n7Vi/faqT+c4vnjazJi0UMfYnnAzYBa9+NkfW0w5W9Uy7kW/v7SffH/2yFiK 9HKkJqkN9xYEYaxtfl5pelF8idoxMZpTvCZY7jhnl2IemZCBMs6s338wS12Qro5WEAxV6cjD VSdmcD5l9plhKGLmgVNCTe8DPv81oDn9s0cIRLg9wNnDtj8aIiH8lBHwfUkpn32iv0uMV6Ae sLxhDWfOR4N+wu1gzXWgLel4drkCJcuYK5IL1qaZDcuGR8RPo3jbFO7Y Message-ID: Date: Wed, 5 Jun 2019 08:27:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190525020305.GA10933@zhanggen-UX430UQ> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25. 05. 19, 4:03, Gen Zhang wrote: > devm_kmalloc() is used to allocate memory for a driver dev. Comments > above the definition and doc > (https://www.kernel.org/doc/Documentation/driver-model/devres.txt) all > imply that allocated the memory is automatically freed on driver attach, > no matter allocation fail or not. However, I examined the code, and > there are many sites that devm_kfree() is used to free devm_kmalloc(). > e.g. hisi_sas_debugfs_init() in drivers/scsi/hisi_sas/hisi_sas_main.c. The guy who added the code in: commit eb1c2b72b7694c984d520300c901f5fc1fa8ea9e Author: Luo Jiaxing Date: Wed Dec 19 23:56:40 2018 +0800 scsi: hisi_sas: Alloc debugfs snapshot buffer memory for all registers seems to be as confused as you are. > So I am totally confused about this issue. Can anybody give me some > guidance? When should we use devm_kfree()? Whenever you want to free the memory earlier than on ->remove or failed ->probe. For whatever reason. thanks, -- js suse labs