Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6368273ybi; Tue, 4 Jun 2019 23:35:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqxcLeIo1JETbyznPlNax+HbTksH3xJxglTwL/VIzzV8zx0PnpYT4fNkJ9GajlQ+Rxos+TxV X-Received: by 2002:a62:1a93:: with SMTP id a141mr43945945pfa.72.1559716525020; Tue, 04 Jun 2019 23:35:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559716525; cv=none; d=google.com; s=arc-20160816; b=b2cl9FiXhuCCl5mB4aLwvBrctSrB2rEuidH/dIqf0VPgQa/c7+zXRfephs1C/jhW4O yeIgOvdEtZwulV3LxDx881pBfcXAORtbZcJsVwVPTasZ9Zky9u9ElnMJHulENuKaMsRh BOA35BqIjLIiz6QyRtI9BkCQ/fld75UuLvjGETECKswTieHltMwh4r4b9TftWK+zPdRD L3kyggGVFojfrT5pVyVaHrRoJSU7MUhMHbR/em6ch5WcPEw1KX99fCNnqbk4NO++EOpg ubU/4Ygj4Y0juMCxHaYZCKNNnswA/R/IWoh80aIgs7fqNkzkxL5/4DrkTNetMdJDCpAa QNhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=3jkuBIFQQ07F1VjyzRvRa/WhrROvZdSv64waFyHMexk=; b=m+aQyyKrZ1tGZbJjN0PdEhHhWlRZ19J6mednxed8rBQvndsUso9gVIspIST0WnQNva sB1SKHSNousoFOD6Bya713PkNS/y4sx6ffwkidjzwnqv6ctIwnBs97br9BKTG1TZPrD7 SmfQEtpH0iIPHBxassUghzpbJz4hwqpm45eN1/8kODm+3A18Ad60S+I3LT3IS7pdIsNM fn4NIrFR+9eDrt8ddLVfIPe+jdb3OdcpQlhMf6+eLHdq14qqGy16C/UktpCKx6ngbOBc X4Z934s8NVKfy6Du+gWiuXdH7vVXfNInxyd7KYafrL7N6ab50SgQWd3Vp5V1KLFc+C7v ZyDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z195si23448013pgz.493.2019.06.04.23.35.07; Tue, 04 Jun 2019 23:35:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726530AbfFEGcs (ORCPT + 99 others); Wed, 5 Jun 2019 02:32:48 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46621 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbfFEGcr (ORCPT ); Wed, 5 Jun 2019 02:32:47 -0400 Received: by mail-wr1-f66.google.com with SMTP id n4so12927541wrw.13 for ; Tue, 04 Jun 2019 23:32:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3jkuBIFQQ07F1VjyzRvRa/WhrROvZdSv64waFyHMexk=; b=FPj80LqdQmWIP2abeCCncO9m+rDWjqPjU5OQcLIKnZ1+ha4Ehz4h/fs1QGgEbAFalm lXMYAYpkqwwQjUZAeC7ue1UHDyKXv34LDsTxjGv0E1yNNc3Qqr39g8PfR1uvsil1Yew3 IVSe3thGjOkmbPu4Jmx86XHdP7i3yyHMtq/n8mPbSGIM8gsHTpSxO1iV3X1DsFQoJATH K8bMeD6oflyZ5/FYObXTtP5OM4BGMq2j+lpgdbspZeUtF1QYqPennqCTWQRJHSNQCALB CMhH43K0ginfoqh5oaQAB9eV0MuMc+U2egCWvV8PV4Z594dhdQH5MR/1R2nDCK/SfimA X4HQ== X-Gm-Message-State: APjAAAUVRaKZ1F5da6GkBSYN5qGxPucL2y6DiCDVxKmB156NBLkN0zlG A69R6UKpWCJV7/6Uajd4HIhitH1w X-Received: by 2002:adf:8028:: with SMTP id 37mr23366438wrk.106.1559716365854; Tue, 04 Jun 2019 23:32:45 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id s63sm10736869wme.17.2019.06.04.23.32.44 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 23:32:45 -0700 (PDT) Subject: Re: [PATCH] orangefs-debugfs: fix a missing-check bug in debug_string_to_mask() To: Gen Zhang , hubcap@omnibond.com, martin@omnibond.com Cc: devel@lists.orangefs.org, linux-kernel@vger.kernel.org References: <20190530090455.GA3059@zhanggen-UX430UQ> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBtKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jej6JAjgEEwECACIFAk6S6NgCGwMGCwkIBwMCBhUIAgkKCwQWAgMB Ah4BAheAAAoJEL0lsQQGtHBJgDsP/j9wh0vzWXsOPO3rDpHjeC3BT5DKwjVN/KtP7uZttlkB duReCYMTZGzSrmK27QhCflZ7Tw0Naq4FtmQSH8dkqVFugirhlCOGSnDYiZAAubjTrNLTqf7e 5poQxE8mmniH/Asg4KufD9bpxSIi7gYIzaY3hqvYbVF1vYwaMTujojlixvesf0AFlE4x8WKs wpk43fmo0ZLcwObTnC3Hl1JBsPujCVY8t4E7zmLm7kOB+8EHaHiRZ4fFDWweuTzRDIJtVmrH LWvRDAYg+IH3SoxtdJe28xD9KoJw4jOX1URuzIU6dklQAnsKVqxz/rpp1+UVV6Ky6OBEFuoR 613qxHCFuPbkRdpKmHyE0UzmniJgMif3v0zm/+1A/VIxpyN74cgwxjhxhj/XZWN/LnFuER1W zTHcwaQNjq/I62AiPec5KgxtDeV+VllpKmFOtJ194nm9QM9oDSRBMzrG/2AY/6GgOdZ0+qe+ 4BpXyt8TmqkWHIsVpE7I5zVDgKE/YTyhDuqYUaWMoI19bUlBBUQfdgdgSKRMJX4vE72dl8BZ +/ONKWECTQ0hYntShkmdczcUEsWjtIwZvFOqgGDbev46skyakWyod6vSbOJtEHmEq04NegUD al3W7Y/FKSO8NqcfrsRNFWHZ3bZ2Q5X0tR6fc6gnZkNEtOm5fcWLY+NVz4HLaKrJuQINBE6S 54YBEADPnA1iy/lr3PXC4QNjl2f4DJruzW2Co37YdVMjrgXeXpiDvneEXxTNNlxUyLeDMcIQ K8obCkEHAOIkDZXZG8nr4mKzyloy040V0+XA9paVs6/ice5l+yJ1eSTs9UKvj/pyVmCAY1Co SNN7sfPaefAmIpduGacp9heXF+1Pop2PJSSAcCzwZ3PWdAJ/w1Z1Dg/tMCHGFZ2QCg4iFzg5 Bqk4N34WcG24vigIbRzxTNnxsNlU1H+tiB81fngUp2pszzgXNV7CWCkaNxRzXi7kvH+MFHu2 1m/TuujzxSv0ZHqjV+mpJBQX/VX62da0xCgMidrqn9RCNaJWJxDZOPtNCAWvgWrxkPFFvXRl t52z637jleVFL257EkMI+u6UnawUKopa+Tf+R/c+1Qg0NHYbiTbbw0pU39olBQaoJN7JpZ99 T1GIlT6zD9FeI2tIvarTv0wdNa0308l00bas+d6juXRrGIpYiTuWlJofLMFaaLYCuP+e4d8x rGlzvTxoJ5wHanilSE2hUy2NSEoPj7W+CqJYojo6wTJkFEiVbZFFzKwjAnrjwxh6O9/V3O+Z XB5RrjN8hAf/4bSo8qa2y3i39cuMT8k3nhec4P9M7UWTSmYnIBJsclDQRx5wSh0Mc9Y/psx9 B42WbV4xrtiiydfBtO6tH6c9mT5Ng+d1sN/VTSPyfQARAQABiQIfBBgBAgAJBQJOkueGAhsM AAoJEL0lsQQGtHBJN7UQAIDvgxaW8iGuEZZ36XFtewH56WYvVUefs6+Pep9ox/9ZXcETv0vk DUgPKnQAajG/ViOATWqADYHINAEuNvTKtLWmlipAI5JBgE+5g9UOT4i69OmP/is3a/dHlFZ3 qjNk1EEGyvioeycJhla0RjakKw5PoETbypxsBTXk5EyrSdD/I2Hez9YGW/RcI/WC8Y4Z/7FS ITZhASwaCOzy/vX2yC6iTx4AMFt+a6Z6uH/xGE8pG5NbGtd02r+m7SfuEDoG3Hs1iMGecPyV XxCVvSV6dwRQFc0UOZ1a6ywwCWfGOYqFnJvfSbUiCMV8bfRSWhnNQYLIuSv/nckyi8CzCYIg c21cfBvnwiSfWLZTTj1oWyj5a0PPgGOdgGoIvVjYXul3yXYeYOqbYjiC5t99JpEeIFupxIGV ciMk6t3pDrq7n7Vi/faqT+c4vnjazJi0UMfYnnAzYBa9+NkfW0w5W9Uy7kW/v7SffH/2yFiK 9HKkJqkN9xYEYaxtfl5pelF8idoxMZpTvCZY7jhnl2IemZCBMs6s338wS12Qro5WEAxV6cjD VSdmcD5l9plhKGLmgVNCTe8DPv81oDn9s0cIRLg9wNnDtj8aIiH8lBHwfUkpn32iv0uMV6Ae sLxhDWfOR4N+wu1gzXWgLel4drkCJcuYK5IL1qaZDcuGR8RPo3jbFO7Y Message-ID: Date: Wed, 5 Jun 2019 08:32:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190530090455.GA3059@zhanggen-UX430UQ> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30. 05. 19, 11:04, Gen Zhang wrote: > In debug_string_to_mask(), 'strsep_fodder' is allocated by kstrdup(). > It returns NULL when fails. So 'strsep_fodder' should be checked. > > Signed-off-by: Gen Zhang > --- > diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c > index 87b1a6f..a9a9aac 100644 > --- a/fs/orangefs/orangefs-debugfs.c > +++ b/fs/orangefs/orangefs-debugfs.c > @@ -888,6 +888,8 @@ static void debug_string_to_mask(char *debug_string, void *mask, int type) > char *unchecked_keyword; > int i; > char *strsep_fodder = kstrdup(debug_string, GFP_KERNEL); > + if (!strsep_fodder) > + return; > char *original_pointer; You should get a compiler error/warning about mixing declarations with code. thanks, -- js suse labs