Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190602143017.19645-1-benniciemanuel78@gmail.com>
In-Reply-To: <20190602143017.19645-1-benniciemanuel78@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 5 Jun 2019 11:32:42 +0300
Message-ID: <CAHp75Vf5Foj3FKD6DiRgck07KAVddGTTXJQhWib77yctfdAjOg@mail.gmail.com>
Subject: Re: [PATCH] pci: ibmphp: add check of return value from pci_hp_register()
To:     benniciemanuel78@gmail.com
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Joe Perches <joe@perches.com>, Lukas Wunner <lukas@wunner.de>,
        Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
        Sebastian Ott <sebott@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jun 2, 2019 at 5:30 PM Emanuel Bennici
<benniciemanuel78@gmail.com> wrote:
>
> Check the return value of pci_hp_register() in Function
> ebda_rsrc_controller()
>

Maybe this is correct, maybe not.
You are changing behaviour of the function.
How did you test this?

> Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
> ---
>  drivers/pci/hotplug/ibmphp_ebda.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/ibmphp_ebda.c b/drivers/pci/hotplug/ibmphp_ebda.c
> index 11a2661dc062..7e523ce071b3 100644
> --- a/drivers/pci/hotplug/ibmphp_ebda.c
> +++ b/drivers/pci/hotplug/ibmphp_ebda.c
> @@ -896,10 +896,17 @@ static int __init ebda_rsrc_controller(void)
>
>         }                       /* each hpc  */
>
> +       int result = 0;
>         list_for_each_entry(tmp_slot, &ibmphp_slot_head, ibm_slot_list) {
>                 snprintf(name, SLOT_NAME_SIZE, "%s", create_file_name(tmp_slot));
> -               pci_hp_register(&tmp_slot->hotplug_slot,
> -                       pci_find_bus(0, tmp_slot->bus), tmp_slot->device, name);
> +               result = pci_hp_register(&tmp_slot->hotplug_slot,
> +                                        pci_find_bus(0, tmp_slot->bus),
> +                                        tmp_slot->device, name);
> +
> +               if (result) {
> +                       err("pci_hp_register failed with error %d\n", result);
> +                       goto error;
> +               }
>         }
>
>         print_ebda_hpc();
> --
> 2.19.1
>


-- 
With Best Regards,
Andy Shevchenko