Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6577785ybi; Wed, 5 Jun 2019 03:11:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqwwtLT/Bbqkt/5SyQIRM2+fnBFpHxi4t4jPOO2TKzlpb9YY6Uj5t3ZPYuXdjlIcsKC25xxB X-Received: by 2002:a17:902:2ba7:: with SMTP id l36mr41960998plb.334.1559729504631; Wed, 05 Jun 2019 03:11:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559729504; cv=none; d=google.com; s=arc-20160816; b=FP+ePsehDsbmpR/xEVy7jSQm+hLQ3wfsoYj6mWkqbGLtw8VogYtqY4/VjvHL9Ki5i0 LTSjXiHaN1Uithchy4Yt7a0hpgkv01A7z+GWibIdlaMZwc4Lug/YSfVrGxBkIQVc1vhg /N368Czbyh3Cvm1Kzw56gkLq6WOl+Z2Do5UCLSskfhM4Iedqr5ZW2vNmOnU/TkJHXFvj NKSBCcd81zGcuDfPr4kolwT1dUp0z98EPMxKt+rauJL0bScf0QTGcMMGjvy8G7avs9nP dZvwLzg9xt1rtzs4FSF1Ti1oKiVrXu4sPrIjtOzl2+hkXbXLeK2lftB+lMaFdEpSWw1L HE1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature:dkim-filter; bh=spSyBc2f59SMr1HLkOA0i/JhLd4nLOmABZGZ8e1sX4M=; b=f6H9uyYIvWXGW8KHflXZJY9pfdWJnx+HYvLfjX4gW/1e/udt1Ey1RqrgP+cGprZGjY PJH8xsay9g6DVQ0QYcjzPWjVTak3+fIL5hcvMzOl/ps3LEOlGqfdz/YwgLA0mcmkoUya u34q/EYt9n3rPtzG3kY/brSWjULg8AFCrQ8aMjyNY+Lic0bnrBqsfiLbGPcm7RdtuUDZ 8Jo0FqDDC6r8j+XB/8MnIJkL3M1TSZ8fpaJ7bbsZFThubstLtR8rJdibRlvI822ug+a9 vTKdc57Cujt/+1KQKiCBV6w25TY3cqczMe8mocJ4xKtusLf5q8VozFK3LuQMefHPj1ca rFhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=xjuWaVGp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 59si29338632plp.158.2019.06.05.03.11.27; Wed, 05 Jun 2019 03:11:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=xjuWaVGp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727227AbfFEKJR (ORCPT + 99 others); Wed, 5 Jun 2019 06:09:17 -0400 Received: from conssluserg-03.nifty.com ([210.131.2.82]:44102 "EHLO conssluserg-03.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727183AbfFEKJQ (ORCPT ); Wed, 5 Jun 2019 06:09:16 -0400 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) (authenticated) by conssluserg-03.nifty.com with ESMTP id x55A9Cef010064; Wed, 5 Jun 2019 19:09:13 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com x55A9Cef010064 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1559729353; bh=spSyBc2f59SMr1HLkOA0i/JhLd4nLOmABZGZ8e1sX4M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=xjuWaVGpdL6WVMegKW6v4TWepAyvjNBR0tbIEOq0MlBZUn1NhqeaOShlvcuiw+t/c 2mkgtlpCzkYfW8nTVvXwtsLlXKGlTaiDBtto2PJmMu1zvRGIHcK/WWOMUD/A0V06/w BAzeEr05rGpNZ8RDBvCOW3+hQM78zNiu0vgLsa/Y/JUv5SQ7wWiZz1XpwBUNrf8sRc FwTDgQsP7mEGi0ZWtwIK4AaqcBRN+q9pV263V3jSFnO31XFMefeKYZ0P3GTOXh/dcr dUBHXbDBRtrqeI3sDnevI0M4wUlafjBsBkAm+SqyIrhXovUeP2tUguibp7CbUx9hxC 6NEFDqd+CnLBw== X-Nifty-SrcIP: [209.85.217.53] Received: by mail-vs1-f53.google.com with SMTP id n2so6971811vso.6; Wed, 05 Jun 2019 03:09:13 -0700 (PDT) X-Gm-Message-State: APjAAAUr3Hw6y74pq77w4JI8acLSMzPiDntGnHKYrbmDv3DMjTTaSLNm clqjSs46yOX5DbNttuszi6xOj7YqyofEsiHQslw= X-Received: by 2002:a67:f495:: with SMTP id o21mr4387671vsn.54.1559729352077; Wed, 05 Jun 2019 03:09:12 -0700 (PDT) MIME-Version: 1.0 References: <20190604111334.22182-1-yamada.masahiro@socionext.com> <8cf48e20064eabdfe150795365e6ca6f36032e9f.camel@perches.com> <20190604134213.GA26263@kroah.com> <20190605051040.GA22760@kroah.com> <20190605060205.GA29484@kroah.com> In-Reply-To: <20190605060205.GA29484@kroah.com> From: Masahiro Yamada Date: Wed, 5 Jun 2019 19:08:35 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] media: do not use C++ style comments in uapi headers To: Greg KH Cc: Joe Perches , Arnd Bergmann , Linux Media Mailing List , Mauro Carvalho Chehab , Thomas Gleixner , Randy Dunlap , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 5, 2019 at 3:03 PM Greg KH wrote: > > On Tue, Jun 04, 2019 at 10:22:05PM -0700, Joe Perches wrote: > > On Wed, 2019-06-05 at 07:10 +0200, Greg KH wrote: > > > On Wed, Jun 05, 2019 at 01:10:41PM +0900, Masahiro Yamada wrote: > > > > On Wed, Jun 5, 2019 at 3:21 AM Arnd Bergmann wrote: > > [] > > > > This means we cannot reliably use uint{8,16,32,64}_t in UAPI headers. > > > > > > We should not be doing that as they are in the userspace "namespace" of > > > variables, not in the kernel namespace. We've been over this many times > > > in the past :( > > > > Just not very successfully... > > > > $ git grep -w -P 'u?_?int(?:8|16|32|64)_t' include/uapi | wc -l > > 342 > > > > $ git grep -w -P --name-only 'u?_?int(?:8|16|32|64)_t' include/uapi | wc -l > > 13 > > > > Documentation helps a bit, checkpatch helps as well. > > Maintainer knowledge and vigilance probably helps the most. > > Yes, it's not been a dedicated effort at all :( I am proposing this series. https://lkml.org/lkml/2019/6/4/1379 When CONFIG_UAPI_HEADER_TEST=y, UAPI headers are compile-tested. 0-day bot tests allmodconfig, which enables CONFIG_UAPI_HEADER_TEST, so new buggy headers will be blocked. It will take some time to eliminate existing bugs. I just started with low-hanging fruits: https://lore.kernel.org/patchwork/patch/1083711/ https://lore.kernel.org/patchwork/patch/1084123/ Anyway, having a document will be really nice. Not all maintainers understand the detail. Having some evidence in Documentation/ will help the review process move smoothly. > But it needs to be resolved, if we want people to actually use our > kernel headers easily. > > thanks, > > greg k-h -- Best Regards Masahiro Yamada