Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6618691ybi; Wed, 5 Jun 2019 03:55:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqx46eCSUZ6kTsGvOsI/OElPro8GbizVxrl65SczKXMGNoCreEVz2BAjx5dlPCLjLk8H37s5 X-Received: by 2002:aa7:8014:: with SMTP id j20mr3873949pfi.125.1559732150918; Wed, 05 Jun 2019 03:55:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559732150; cv=none; d=google.com; s=arc-20160816; b=z6Di8ii79dJp5h4mHuimX0Lyb2xicZ+fMfOukGTRBtU6k8DNUqJMR+hqwjF5hnRm3g lSG9DR5C75LiJc5hmmg3srCoO2Gi+GT9AjaE5yVGI1Hfi0/c0q2Eymk/Mi/mL1YKFXMI lfgXUhPNZz4+/XWHy+2UVpycpBopxwmSed6/UTn27XDzOtxnuG+gmN2AhT1kbJ9euYa6 t3KB1Frtbisnkd0z5S5IUkTpm3Jlt6yTFz8jKkl8JNVKW9qnG85qqQqUEY811cZIe98x qbnDSOtBGX63bgYWl8r+HwB0fPvpSaQcnA4MCoZOhdylKFrQYaP1bhvRIhNBDQv0TK78 JqRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=0vhc5Y1lg3rvhyDXgYLyaHEMIVjx3BfD4Oc5zwPTN/g=; b=Xp68s0AJphqwMbOLNmGWVbZnnjwBtVKLDQKjcMY28PFboBYyWGxAXXhwWWgNKBV9MR wM6EQvgasuRTEf0/5WGVwTj0yPP6dinrycaJZZZ9Esqh/GH35UQFr832WjFgG2qvwpW2 9RD63OOkFhdOUWjpM6Muy5+Fo+l9LREyviNp7h+ZW4mJEg2QEsQDEzpVCOJSb3b1q+uY NCsZ5j86E0sq7i2M5tEglbE+tnk3LjpSosCqvexHzTcMIubYBW33wbBAnrS3EVc0HCgR 0l6ZVzRq42wPkmtiqV55izVcwD4gRXKkl8mO6Pkq2qDaHUUGjz1GRbEyVNLOX6ipJKqQ ymPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=GUQ5T8SK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bo10si24946429pjb.59.2019.06.05.03.55.33; Wed, 05 Jun 2019 03:55:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=GUQ5T8SK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727302AbfFEKwq (ORCPT + 99 others); Wed, 5 Jun 2019 06:52:46 -0400 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:55860 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726502AbfFEKwq (ORCPT ); Wed, 5 Jun 2019 06:52:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1559731963; x=1591267963; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=0vhc5Y1lg3rvhyDXgYLyaHEMIVjx3BfD4Oc5zwPTN/g=; b=GUQ5T8SKCqtQrkpa2N8OGsPe0LCMyTdUqCPy7KMQdKEzz9Mtt5kelxjv E9ykVFFp5sOZ57u/v0ZkiyqQyWg8PCc52/hSfLMcjCQs8v4B2LoOaLvBz GwZIxJUkqPEb1/W31a5Zx2DipNiiN9EjyOKnKOunnytDKL1jQ1qXnGeYA c=; X-IronPort-AV: E=Sophos;i="5.60,550,1549929600"; d="scan'208";a="803708516" Received: from sea3-co-svc-lb6-vlan2.sea.amazon.com (HELO email-inbound-relay-2a-c5104f52.us-west-2.amazon.com) ([10.47.22.34]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 05 Jun 2019 10:52:43 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-2a-c5104f52.us-west-2.amazon.com (Postfix) with ESMTPS id A2AB7A2070; Wed, 5 Jun 2019 10:52:39 +0000 (UTC) Received: from EX13D01EUB001.ant.amazon.com (10.43.166.194) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 5 Jun 2019 10:52:38 +0000 Received: from udc4a3e82dbc15a031435.hfa15.amazon.com (10.43.162.246) by EX13D01EUB001.ant.amazon.com (10.43.166.194) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 5 Jun 2019 10:52:29 +0000 From: Talel Shenhar To: , , , , , , , , , , , CC: , , , , , , , Talel Shenhar Subject: [PATCH v2 2/2] irqchip: al-fic: Introduce Amazon's Annapurna Labs Fabric Interrupt Controller Driver Date: Wed, 5 Jun 2019 13:52:01 +0300 Message-ID: <1559731921-14023-3-git-send-email-talel@amazon.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1559731921-14023-1-git-send-email-talel@amazon.com> References: <1559731921-14023-1-git-send-email-talel@amazon.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.162.246] X-ClientProxiedBy: EX13D14UWC003.ant.amazon.com (10.43.162.19) To EX13D01EUB001.ant.amazon.com (10.43.166.194) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Amazon's Annapurna Labs Fabric Interrupt Controller has 32 inputs lines. A FIC (Fabric Interrupt Controller) may be cascaded into another FIC or directly to the main CPU Interrupt Controller (e.g. GIC). Signed-off-by: Talel Shenhar --- MAINTAINERS | 6 + drivers/irqchip/Kconfig | 11 ++ drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-al-fic.c | 289 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 307 insertions(+) create mode 100644 drivers/irqchip/irq-al-fic.c diff --git a/MAINTAINERS b/MAINTAINERS index f485597..b4f5255 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1209,6 +1209,12 @@ S: Maintained F: Documentation/devicetree/bindings/interrupt-controller/arm,vic.txt F: drivers/irqchip/irq-vic.c +AMAZON ANNAPURNA LABS FIC DRIVER +M: Talel Shenhar +S: Maintained +F: Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt +F: drivers/irqchip/irq-al-fic.c + ARM SMMU DRIVERS M: Will Deacon R: Robin Murphy diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 51a5ef0..1e51f0f 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -89,6 +89,17 @@ config ALPINE_MSI select PCI_MSI select GENERIC_IRQ_CHIP +config AL_FIC + bool "Amazon's Annapurna Labs Fabric Interrupt Controller" + depends on OF || COMPILE_TEST + select GENERIC_IRQ_CHIP + select IRQ_DOMAIN + select GENERIC_IRQ_MULTI_HANDLER + select IRQ_DOMAIN_HIERARCHY + select SPARSE_IRQ + help + Support Amazon's Annapurna Labs Fabric Interrupt Controller. + config ATMEL_AIC_IRQ bool select GENERIC_IRQ_CHIP diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile index 794c13d..a20eba5 100644 --- a/drivers/irqchip/Makefile +++ b/drivers/irqchip/Makefile @@ -1,6 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_IRQCHIP) += irqchip.o +obj-$(CONFIG_AL_FIC) += irq-al-fic.o obj-$(CONFIG_ALPINE_MSI) += irq-alpine-msi.o obj-$(CONFIG_ATH79) += irq-ath79-cpu.o obj-$(CONFIG_ATH79) += irq-ath79-misc.o diff --git a/drivers/irqchip/irq-al-fic.c b/drivers/irqchip/irq-al-fic.c new file mode 100644 index 0000000..484ef18 --- /dev/null +++ b/drivers/irqchip/irq-al-fic.c @@ -0,0 +1,289 @@ +// SPDX-License-Identifier: GPL-2.0 +/** + * Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* FIC Registers */ +#define AL_FIC_CAUSE 0x00 +#define AL_FIC_MASK 0x10 +#define AL_FIC_CONTROL 0x28 + +#define CONTROL_TRIGGER_RISING BIT(3) +#define CONTROL_MASK_MSI_X BIT(5) + +#define NR_FIC_IRQS 32 + +MODULE_AUTHOR("Talel Shenhar"); +MODULE_DESCRIPTION("Amazon's Annapurna Labs Interrupt Controller Driver"); +MODULE_LICENSE("GPL v2"); + +enum al_fic_state { + AL_FIC_CLEAN = 0, + AL_FIC_CONFIGURED_LEVEL, + AL_FIC_CONFIGURED_RAISING_EDGE, +}; + +struct al_fic { + void __iomem *base; + struct irq_domain *domain; + const char *name; + unsigned int parent_irq; + enum al_fic_state state; +}; + +static void al_fic_set_trigger(struct al_fic *fic, + struct irq_chip_generic *gc, + enum al_fic_state new_state) +{ + irq_flow_handler_t handler; + u32 control = readl(fic->base + AL_FIC_CONTROL); + + if (new_state == AL_FIC_CONFIGURED_LEVEL) { + handler = handle_level_irq; + control &= ~CONTROL_TRIGGER_RISING; + } else { + handler = handle_edge_irq; + control |= CONTROL_TRIGGER_RISING; + } + gc->chip_types->handler = handler; + fic->state = new_state; + writel(control, fic->base + AL_FIC_CONTROL); +} + +static int al_fic_irq_set_type(struct irq_data *data, unsigned int flow_type) +{ + struct irq_chip_generic *gc = irq_data_get_irq_chip_data(data); + struct al_fic *fic = gc->private; + enum al_fic_state new_state; + int ret = 0; + + irq_gc_lock(gc); + + if (!(flow_type & IRQ_TYPE_LEVEL_HIGH) && + !(flow_type & IRQ_TYPE_EDGE_RISING)) { + pr_err("fic doesn't support flow type %d\n", flow_type); + ret = -EPERM; + goto err; + } + + new_state = (flow_type & IRQ_TYPE_LEVEL_HIGH) ? + AL_FIC_CONFIGURED_LEVEL : AL_FIC_CONFIGURED_RAISING_EDGE; + + /* A given FIC instance can be either all level or all edge triggered. + * This is generally fixed depending on what pieces of HW it's wired up + * to. + * + * We configure it based on the sensitivity of the first source + * being setup, and reject any subsequent attempt at configuring it in a + * different way. + */ + if (fic->state == AL_FIC_CLEAN) { + al_fic_set_trigger(fic, gc, new_state); + } else if (fic->state != new_state) { + pr_err("fic %s state already configured to %d\n", + fic->name, fic->state); + ret = -EPERM; + goto err; + } + +err: + irq_gc_unlock(gc); + + return ret; +} + +static void al_fic_irq_handler(struct irq_desc *desc) +{ + struct al_fic *fic = irq_desc_get_handler_data(desc); + struct irq_domain *domain = fic->domain; + struct irq_chip *irqchip = irq_desc_get_chip(desc); + struct irq_chip_generic *gc = irq_get_domain_generic_chip(domain, 0); + unsigned long pending; + unsigned int irq; + u32 hwirq; + + chained_irq_enter(irqchip, desc); + + pending = readl(fic->base + AL_FIC_CAUSE); + pending &= ~gc->mask_cache; + + for_each_set_bit(hwirq, &pending, domain->revmap_size) { + irq = irq_find_mapping(domain, hwirq); + generic_handle_irq(irq); + } + + chained_irq_exit(irqchip, desc); +} + +static int al_fic_register(struct device_node *node, + struct al_fic *fic) +{ + struct irq_chip_generic *gc; + int ret; + + fic->domain = irq_domain_add_linear(node, + NR_FIC_IRQS, + &irq_generic_chip_ops, + fic); + if (!fic->domain) { + pr_err("fail to add irq domain\n"); + return -ENOMEM; + } + + ret = irq_alloc_domain_generic_chips(fic->domain, + NR_FIC_IRQS, + 1, fic->name, + handle_level_irq, + 0, 0, IRQ_GC_INIT_MASK_CACHE); + if (ret) { + pr_err("fail to allocate generic chip (%d)\n", ret); + goto err_domain_remove; + } + + gc = irq_get_domain_generic_chip(fic->domain, 0); + gc->reg_base = fic->base; + gc->chip_types->regs.mask = AL_FIC_MASK; + gc->chip_types->regs.ack = AL_FIC_CAUSE; + gc->chip_types->chip.irq_mask = irq_gc_mask_set_bit; + gc->chip_types->chip.irq_unmask = irq_gc_mask_clr_bit; + gc->chip_types->chip.irq_ack = irq_gc_ack_clr_bit; + gc->chip_types->chip.irq_set_type = al_fic_irq_set_type; + gc->chip_types->chip.flags = IRQCHIP_SKIP_SET_WAKE; + gc->private = fic; + + irq_set_chained_handler_and_data(fic->parent_irq, + al_fic_irq_handler, + fic); + return 0; + +err_domain_remove: + irq_domain_remove(fic->domain); + + return ret; +} + +static void al_fic_hw_init(struct al_fic *fic) +{ + u32 control = CONTROL_MASK_MSI_X; + + /* mask out all interrupts */ + writel(0xFFFFFFFF, fic->base + AL_FIC_MASK); + + /* clear any pending interrupt */ + writel(0, fic->base + AL_FIC_CAUSE); + + writel(control, fic->base + AL_FIC_CONTROL); +} + +/** + * al_fic_wire_init() - initialize and configure fic in wire mode + * @of_node: optional pointer to interrupt controller's device tree node. + * @base: mmio to fic register + * @name: name of the fic + * @parent_irq: interrupt of parent + * + * This API will configure the fic hardware to to work in wire mode. + * In wire mode, fic hardware is generating a wire ("wired") interrupt. + * Interrupt can be generated based on positive edge or level - configuration is + * to be determined based on connected hardware to this fic. + * + * Returns fic context that allows the user to obtain the irq_domain by using + * al_fic_wire_get_domain(). + */ +static struct al_fic *al_fic_wire_init(struct device_node *node, + void __iomem *base, + const char *name, + unsigned int parent_irq) +{ + struct al_fic *fic; + int ret; + + if (!base) + return ERR_PTR(-EINVAL); + + fic = kzalloc(sizeof(*fic), GFP_KERNEL); + if (!fic) + return ERR_PTR(-ENOMEM); + + fic->base = base; + fic->parent_irq = parent_irq; + fic->name = (name ?: "al-fic-wire"); + + al_fic_hw_init(fic); + + ret = al_fic_register(node, fic); + if (ret) { + pr_err("fail to register irqchip\n"); + goto err_free; + } + + pr_debug("%s initialized successfully in Legacy mode (parent-irq=%u)\n", + fic->name, parent_irq); + + return fic; + +err_free: + kfree(fic); + return ERR_PTR(ret); +} + +static int __init al_fic_init_dt(struct device_node *node, + struct device_node *parent) +{ + int ret; + void __iomem *base; + unsigned int parent_irq; + struct al_fic *fic; + + if (!parent) { + pr_err("%s: unsupported - device require a parent\n", + node->name); + return -EINVAL; + } + + base = of_iomap(node, 0); + if (!base) { + pr_err("%s: fail to map memory\n", node->name); + return -ENOMEM; + } + + parent_irq = irq_of_parse_and_map(node, 0); + if (!parent_irq) { + pr_err("%s: fail to map irq\n", node->name); + ret = -EINVAL; + goto err_unmap; + } + + fic = al_fic_wire_init(node, + base, + node->name, + parent_irq); + if (IS_ERR(fic)) { + pr_err("%s: fail to initialize irqchip (%lu)\n", + node->name, + PTR_ERR(fic)); + ret = PTR_ERR(fic); + goto err_irq_dispose; + } + + return 0; + +err_irq_dispose: + irq_dispose_mapping(parent_irq); +err_unmap: + iounmap(base); + + return ret; +} + +IRQCHIP_DECLARE(al_fic, "amazon,al-fic", al_fic_init_dt); -- 2.7.4