Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6633836ybi; Wed, 5 Jun 2019 04:09:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqzKYcfORyOr8hWN3cP6vzHx92lVx8FO4maQEW1uCM77MqXbNBSmaJDklYNVbbq60Gv+0l4L X-Received: by 2002:a63:a84c:: with SMTP id i12mr3564494pgp.115.1559732987103; Wed, 05 Jun 2019 04:09:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559732987; cv=none; d=google.com; s=arc-20160816; b=WHI5BhSNWNACmJjx/g+E3hOQWW1LbXLOQ+zBOZAm1RlflZFEqNEhpXJ9E2g23idz3U dHdExxWUURkng/Bjk5ywbpeccDTIJ1Ppka2YlwK/6Pefpw5KPXkv/zlTuUtlvJY/7vU+ UHnXFnzjp2ULygcYMaAxKkTO0QbUEGJqN2UXYFZVIpFf4u/+VjPnEKVuyBArnm3+oDNB pqxUQGzgwGTam6aKjNkogb5L8o49/TCuMLM8ugsk1DSTlpDsivBJP7vWiAgYwzR49shN fyXizMHM9tapSJ4jwWimpugN6xr2BH/AvJlRskR/Eftk/FMhWAPiy6NvkHG5ALU550V1 AIig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=cHaeIv5gFLHQjALqxVOsUvzlWQn1IBs/E6RQSrV3XX8=; b=Vvon7ABGXiquLNKwWmTqApbLXsUhMgk/zrNQRbmwZKCFdq0al5KbYgdSZJ3+0B9ogN NZ65tjUh12jQwzbsaib15+DpKzX9HlRBtnDJO9CHo7c7T9eQquVtxfkZNzaDMuZ+d9qW kF87AfQPC7lxzmQTHqlGh5p3J2XYwwhgp3cFYm+dx2z43PWcfLjNsZuoDj6dl/S42b20 Z006szZKwb+gy74h7+lfnrjQvHApXXGe6WUgXW+K/yxLb7celetveM/gezuh/rq/6wSL eiOhC89aArxfZgnqZzlISa5P4FXKvIvicg9ao6hUDrC67s6+2ZeCuJMtoMQZi3aUO3cZ UjaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n9si27012236pgr.280.2019.06.05.04.09.28; Wed, 05 Jun 2019 04:09:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727348AbfFELIS (ORCPT + 99 others); Wed, 5 Jun 2019 07:08:18 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:49695 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727154AbfFELIS (ORCPT ); Wed, 5 Jun 2019 07:08:18 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 45JmHM6thCz9sBb; Wed, 5 Jun 2019 21:08:15 +1000 (AEST) From: Michael Ellerman To: "Martin K. Petersen" , Nathan Chancellor Cc: Tyrel Datwyler , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH v3] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work In-Reply-To: References: <20190603221941.65432-1-natechancellor@gmail.com> <20190603234405.29600-1-natechancellor@gmail.com> Date: Wed, 05 Jun 2019 21:08:14 +1000 Message-ID: <87woi0mgrl.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Martin K. Petersen" writes: > Nathan, > >> clang warns: >> >> drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used >> uninitialized whenever switch case is taken [-Wsometimes-uninitialized] >> case IBMVSCSI_HOST_ACTION_NONE: >> ^~~~~~~~~~~~~~~~~~~~~~~~~ > > Applied to 5.3/scsi-queue, thanks! Thanks all. cheers