Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6684101ybi; Wed, 5 Jun 2019 04:59:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqwy+mn18YCwrDTQUPcCB94NSOjSX9VGI+/HadV0/1SyAQxanIXwqZdE/1lLk07KQATmLXRT X-Received: by 2002:a63:c24c:: with SMTP id l12mr3850335pgg.173.1559735997438; Wed, 05 Jun 2019 04:59:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559735997; cv=none; d=google.com; s=arc-20160816; b=GL3KYPdYbbyzijEcKS+nYcmXKvkWbuMfSUITB6huyZ8CBMgveFYwFcJALxHutEa7pF dJmnj8QFOkHHVykkfJWa4Krt5kZaHbYoqUm4ovPTaM6MTz/SEBxZrHzKVCcUovYa4My6 8fX1EjtIHQGBfmq4myN4kvqWFtwqfcZShey26BCe+Kp25UCfOjwdIZ/5sQ4JVtSh/vkd WDeYUv0cG8pGo1CF1i4QlhL3yN/4Kwrze/AQLt803T31+7dFJ472jpFS7LLsaPQs8Gnd lBXffBm275RQS7wbSMUmOCG7YNGdR1n6+/hbV6r2r03XLlvGgmoVJGSQ7GnBE+sTV8G9 TOUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ELcMUQV5vzEhBdC+1er8cwz9GPMDZv7QyWToMSwbfJU=; b=Ph7t/8ekHQtnAJAOgRvqUEJHwop0faDS/mfx/13NFcWert1iSnuaEk5hTZqaJ2199L K1DH+hjCwPbiGlCSFg/gGzr9TZFyTcQA1ShOa4G0HDuoTioyW9Pp55JMWJe0iP5hzEOv JIRdRSSK/B9qGoI6YveU6KiGzeQb/k8ymGbbnXSPT8a65Y5aPZPpd4SlMf9k880ApaOl XrCa6v5c/4WPTEd+wSN2lugnbmHXj1IfwH+wnhHGOVQG0sF7R1ODOrjCKn3HyubttDMX TmANenYYY/RMHO0oHrc2mF565NgMu1wX272NNDTciMd6lXW/bKJUrMOevGTuw5yrA7Qf q2vg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 36si30883962pla.80.2019.06.05.04.59.40; Wed, 05 Jun 2019 04:59:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727644AbfFEL6U (ORCPT + 99 others); Wed, 5 Jun 2019 07:58:20 -0400 Received: from foss.arm.com ([217.140.101.70]:58612 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727183AbfFEL6T (ORCPT ); Wed, 5 Jun 2019 07:58:19 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78A2F80D; Wed, 5 Jun 2019 04:58:19 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 68E173F5AF; Wed, 5 Jun 2019 04:58:18 -0700 (PDT) Date: Wed, 5 Jun 2019 12:58:15 +0100 From: Will Deacon To: Anders Roxell Cc: peterz@infradead.org, mingo@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] seqlock: mark raw_read_seqcount and read_seqcount_retry as __always_inline Message-ID: <20190605115815.GG15030@fuggles.cambridge.arm.com> References: <20190603091008.24776-1-anders.roxell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190603091008.24776-1-anders.roxell@linaro.org> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 03, 2019 at 11:10:08AM +0200, Anders Roxell wrote: > If CONFIG_FUNCTION_GRAPH_TRACER is enabled function sched_clock() in > kernel/time/sched_clock.c is marked as notrace. However, functions > raw_read_seqcount and read_seqcount_retry are marked as inline. If > CONFIG_OPTIMIZE_INLINING is set that will make the two functions > tracable which they shouldn't. Might be nice to elaborate a bit here on what goes from specifically for seqlocks. I assume something ends up going recursive thanks to the tracing code? With that: Acked-by: Will Deacon Will