Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/3] KVM: LAPIC: lapic timer is injected by posted
 interrupt
To:     Wanpeng Li <kernellwp@gmail.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
References: <1559729351-20244-1-git-send-email-wanpengli@tencent.com>
 <1559729351-20244-3-git-send-email-wanpengli@tencent.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <16c54182-7198-f476-080b-5876cd871e42@redhat.com>
Date:   Wed, 5 Jun 2019 14:30:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1559729351-20244-3-git-send-email-wanpengli@tencent.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 05/06/19 12:09, Wanpeng Li wrote:
> +static void apic_timer_expired_pi(struct kvm_lapic *apic)
> +{
> +	struct kvm_timer *ktimer = &apic->lapic_timer;
> +
> +	kvm_apic_local_deliver(apic, APIC_LVTT);
> +	if (apic_lvtt_tscdeadline(apic))
> +		ktimer->tscdeadline = 0;
> +	if (apic_lvtt_oneshot(apic)) {
> +		ktimer->tscdeadline = 0;
> +		ktimer->target_expiration = 0;
> +	}
> +}

Please rename this function to kvm_apic_inject_pending_timer_irqs and
call it from kvm_inject_apic_timer_irqs.

Then apic_timer_expired can just do

        if (atomic_read(&apic->lapic_timer.pending))
                return;

+	if (unlikely(posted_interrupt_inject_timer(apic->vcpu))) {
+		kvm_apic_inject_pending_timer_irqs(apic);
+		return;
+	}

etc.

Paolo