Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6846485ybi; Wed, 5 Jun 2019 07:18:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqynhwsePK14Vw+C+h+1vdbqJPHyb1ygbyJ+gvN4FG14t1rU9JkDl0GSaVjlOPnLoiyjNicw X-Received: by 2002:a65:5004:: with SMTP id f4mr4897972pgo.268.1559744307889; Wed, 05 Jun 2019 07:18:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559744307; cv=none; d=google.com; s=arc-20160816; b=Hc1Kj+8M1iz39kSMMXm9R9k7+Zh4fu+qEuPVd5NLz+lfBt+OHvq62f9F00o8FTTl21 dhVZoc0/daFYBw7ijRQXR2M3o++brfBNZr9o1udMNMAM0k5KKMf43RAkm3AGeDl1VyM/ hrHMs3pye+HT9sN58LFAWCyeQhVOqESujUSyiBq6phEZ8q0SZiUZ2M3wyPmmZSYFZ11U D5nNIAKM8MADEjBisSmvwx+Z3X0jWYJmnxua2RhI6YISCRInne8vukkQPcIOmE2w8OZB HB1tmfUZ3zHHzWSmNYaz29mzJZlWy8ZNxcCMwrWTAsiHRzBUf0dHIS6dJ6bSyTFrHbYa 0fcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3nxaWWlSg2/iB9rS6bygSLVjyICkZF7FnH/YXeHuqlU=; b=Jv0kOBdeHT49Mp+akxenkBbrEhFcHVh37sSdGHWy/BPaTve/EswM7Gdn7vECJalUjc eKm4LbGOm5850HGY/QTcEdYaIYpv8x5JVdxjIFgZBgPmpz0ndLjljhsRtQTSiKqph1qB yvk1t013+CyQ1twELyZlOtcyvLglEjntAtFGCqr9G8V8or9w6NT860hvoCnEkM9HGMfh c0+IKviK+mIY94vN/kFc3HfylXkBBB1o+uiyhBtI9YSEgUyg9/kLzUXLjzSQqh/3vQCz daNFwHdqiixNkpXRLOaDZZ7CCESRGikUyRrXqHvexo15RPTzXLbvTq3R1LilRME4bCkk OOrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m5si26688850pls.18.2019.06.05.07.18.11; Wed, 05 Jun 2019 07:18:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728434AbfFEOQ4 (ORCPT + 99 others); Wed, 5 Jun 2019 10:16:56 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:34578 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728161AbfFEOQx (ORCPT ); Wed, 5 Jun 2019 10:16:53 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id D265EF6D1C1336EA5915; Wed, 5 Jun 2019 22:16:45 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Wed, 5 Jun 2019 22:16:37 +0800 From: Kefeng Wang To: CC: Kefeng Wang , Jens Axboe , Subject: [PATCH] block: Drop unlikely before IS_ERR(_OR_NULL) Date: Wed, 5 Jun 2019 22:24:27 +0800 Message-ID: <20190605142428.84784-4-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190605142428.84784-1-wangkefeng.wang@huawei.com> References: <20190605142428.84784-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag, so no need to do that again from its callers. Drop it. Cc: Jens Axboe Cc: linux-block@vger.kernel.org Signed-off-by: Kefeng Wang --- block/blk-cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index b97b479e4f64..1f7127b03490 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -881,7 +881,7 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol, blkg_free(new_blkg); } else { blkg = blkg_create(pos, q, new_blkg); - if (unlikely(IS_ERR(blkg))) { + if (IS_ERR(blkg)) { ret = PTR_ERR(blkg); goto fail_unlock; } -- 2.20.1