Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp6853199ybi; Wed, 5 Jun 2019 07:24:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqxAiA9mnQ4Q8OIzpmdtj3iK/tihpxUahOD64SFhP+U0eBj2vRnQ96IZWVU2t7TYy70zs63U X-Received: by 2002:a17:90a:2488:: with SMTP id i8mr36533753pje.123.1559744673347; Wed, 05 Jun 2019 07:24:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559744673; cv=none; d=google.com; s=arc-20160816; b=yoU1llPcRcNxCvuaBciMpAdOH2MJK5j4FianUU5mSsM9D3NS7K99csf685DJXkis+u 2zyDjI9Ypph4G+rekS/7ycZFTb6h0z3WRqp+bFAgPsdN8/QfaPGMaklaG4lIh0kVUcNI AhUR3CY56Lki0Tp3eCmUQeBYAxNZATnM1EnG0as+bNeWZA2ID7+Cktd5RBeZdL+N/hbw /t8SiLulzHxmahWwA4kz9Nkvp6TDPBU9cSBHnIrdfaHHutKEqVW0rOVgUl0X2lf2btJQ 4E9/WYOJ1czgOU0U2di5mG5kGJ2jykCl60V8AybvZs+R234qWwG6uRhqyEI3CHeM6Zki mI/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=o+IcDP8xywihziIgb7p/GLXZhp4cLmigR0A3EK7XJW0=; b=GhjqoA7WlVKc/K5Wt4Fw4Ik5nHYhTbZZMQbNhZ1qBE3GQZfvcTocjjq8TSw5VHS+i1 ny3AomhS/ZHA2AlrSX5sk/TPh+C6Pjobouay+NCR8pF9ifE3R+YmTDIVgHCKopGTISpN zE8FUF4ZmD2hcL5r+JCNgEIlT6DVblAJAhFSrvgM87x1pwiHpW/SiMgWirMMMbmphg92 F2OrjQ6JDdA2Vpag3973cUtMRB/tqzobWmOHCBiEiMD/P/4BTP12TobHqhhm0Ev7a3eQ u0N4+QjdxkVXRsiM3RGCCRvqPPfVeRNgyoeTsHx0sthSKfVWfNy3t2M3mHnv2ueGMENm R4+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=yyD4roMK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i18si22202901pfr.65.2019.06.05.07.24.14; Wed, 05 Jun 2019 07:24:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=yyD4roMK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728364AbfFEOWj (ORCPT + 99 others); Wed, 5 Jun 2019 10:22:39 -0400 Received: from mail-pg1-f182.google.com ([209.85.215.182]:34139 "EHLO mail-pg1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728190AbfFEOWj (ORCPT ); Wed, 5 Jun 2019 10:22:39 -0400 Received: by mail-pg1-f182.google.com with SMTP id h2so9240963pgg.1 for ; Wed, 05 Jun 2019 07:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o+IcDP8xywihziIgb7p/GLXZhp4cLmigR0A3EK7XJW0=; b=yyD4roMK8IUzMUzyYYIle4EboYZB9IzE6GPQGoQtFvfggOvviH/3vpHFMwjPy6yMS3 WxYPl11RTtZxvEJUCaC/UF43bEUALvX5Jk2kEr+il/5OgV4GM+OFmk9/m42A9JOpmE6t X693rS571KV6xsvo170fRaAsVnujNlNuVARoPovwK38pFU0LPWSWkSb0t7tvlC3EJMIN eDpNXXsudC8vHx1QCZRIKcbDBuaPLij83tVhhdPWlQlSMuoQH3MGwO0CZCn+9E76qPum wesb7zyj/jsBaJCnnLkw77Pw1DmaVxfI/cQMUYdV9YXCeSCdZlgInhZJ+2eM2++wOOzr dRXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o+IcDP8xywihziIgb7p/GLXZhp4cLmigR0A3EK7XJW0=; b=pXlVD3Sr2raQqb8rXvHprh3CjKlRxinOKLSqAQpYZUeC6dN5eCxop1FCtncCOFqV7q BL1H+q9vHCc5gEbQSjLTICVd2EYF7Spr2EzxTR9YQovIEc/oGW2YghdxkunatIhsJhbT KL16XnwEs0GxlqaEyDUMdc2jGNzleUmRXTRCw5Z3+0ddY97oETuh3CA4NQUg4kuCqtWm Gci2li5W/FUS9z7DjHFD8GILllshbPvIlP5a+sZPkAFQ0dincv/QInpw0QwpDhKU27Y6 UWqyAOXeznacEd+Us1SkN2CukK4qrcTSKbMJzSSKdYeKbE0rQpJceUkQKdQq8sPbWBJa uLkg== X-Gm-Message-State: APjAAAX2tOVfrg5wu65MOwasW0LLokIvN+gMOKKzA5F9wu7F7siNtMrZ w4GaI1cswQwOx+r4hIbsIbiPKw== X-Received: by 2002:a62:6d47:: with SMTP id i68mr46913713pfc.189.1559744557582; Wed, 05 Jun 2019 07:22:37 -0700 (PDT) Received: from [192.168.1.158] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id d9sm17865159pgl.20.2019.06.05.07.22.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2019 07:22:36 -0700 (PDT) Subject: Re: [PATCH] block: Drop unlikely before IS_ERR(_OR_NULL) To: Kefeng Wang , linux-kernel@vger.kernel.org Cc: linux-block@vger.kernel.org References: <20190605142428.84784-1-wangkefeng.wang@huawei.com> <20190605142428.84784-4-wangkefeng.wang@huawei.com> From: Jens Axboe Message-ID: <5142de36-e834-1514-a63c-4addea773c41@kernel.dk> Date: Wed, 5 Jun 2019 08:22:35 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190605142428.84784-4-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/5/19 8:24 AM, Kefeng Wang wrote: > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag, > so no need to do that again from its callers. Drop it. Applied, thanks. -- Jens Axboe