Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751235AbVKRXux (ORCPT ); Fri, 18 Nov 2005 18:50:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751231AbVKRXux (ORCPT ); Fri, 18 Nov 2005 18:50:53 -0500 Received: from dsl027-180-168.sfo1.dsl.speakeasy.net ([216.27.180.168]:9360 "EHLO sunset.davemloft.net") by vger.kernel.org with ESMTP id S1751230AbVKRXux (ORCPT ); Fri, 18 Nov 2005 18:50:53 -0500 Date: Fri, 18 Nov 2005 15:51:01 -0800 (PST) Message-Id: <20051118.155101.51861744.davem@davemloft.net> To: yanzheng@21cn.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, yoshfuji@linux-ipv6.org Subject: Re: [PATCH]IPv6: Acquire addrconf_hash_lock for reading instead of writing in addrconf_verify(...) From: "David S. Miller" In-Reply-To: <437BE773.6010007@21cn.com> References: <437BE773.6010007@21cn.com> X-Mailer: Mew version 4.2.53 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 633 Lines: 15 From: Yan Zheng Date: Thu, 17 Nov 2005 10:14:11 +0800 > addrconf_verify(...) only traverse address hash table when addrconf_hash_lock is held > for writing, and it may hold addrconf_hash_lock for a long time. So I think it's better > to acquire addrconf_hash_lock for reading instead of writing > > Signed-off-by: Yan Zheng Applied, thanks Yan. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/