Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 6 Jun 2019 00:16:00 +0800
From:   Gen Zhang <blackgod016574@gmail.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Ben Hutchings <ben@decadent.org.uk>, Jiri Slaby <jslaby@suse.com>,
        Kees Cook <keescook@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "consolemap: Fix a memory leaking bug in
 drivers/tty/vt/consolemap.c"
Message-ID: <20190605161600.GA4720@zhanggen-UX430UQ>
References: <20190604180039.gai2phwdxn7ias6n@decadent.org.uk>
 <20190604190234.GA10572@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190604190234.GA10572@kroah.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 04, 2019 at 09:02:34PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 04, 2019 at 07:00:39PM +0100, Ben Hutchings wrote:
> > This reverts commit 84ecc2f6eb1cb12e6d44818f94fa49b50f06e6ac.
> > 
> > con_insert_unipair() is working with a sparse 3-dimensional array:
> > 
> > - p->uni_pgdir[] is the top layer
> > - p1 points to a middle layer
> > - p2 points to a bottom layer
> > 
> > If it needs to allocate a new middle layer, and then fails to allocate
> > a new bottom layer, it would previously free only p2, and now it frees
> > both p1 and p2.  But since the new middle layer was already registered
> > in the top layer, it was not leaked.
> > 
> > However, if it looks up an *existing* middle layer and then fails to
> > allocate a bottom layer, it now frees both p1 and p2 but does *not*
> > free any other bottom layers under p1.  So it *introduces* a memory
> > leak.
> > 
> > The error path also cleared the wrong index in p->uni_pgdir[],
> > introducing a use-after-free.
> > 
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> 
> Now applied, thanks.
> 
> Gen, please be careful with these types of "fixes"...
Thanks for your comments. I will for sure. And I am always submutting 
patches and revising it according to the maintainers.

Thanks
Gen
> 
> thanks,
> 
> greg k-h