Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1559769249-22011-1-git-send-email-info@metux.net>
In-Reply-To: <1559769249-22011-1-git-send-email-info@metux.net>
From:   Steve French <smfrench@gmail.com>
Date:   Wed, 5 Jun 2019 16:52:30 -0500
Message-ID: <CAH2r5mvzEPj2NXMJW5fOfq0+bbh-pZFnJnL1jEnyFYDt1HJi1A@mail.gmail.com>
Subject: Re: [PATCH] fs: cifs: drop unneeded likely() call around IS_ERR()
To:     "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        CIFS <linux-cifs@vger.kernel.org>,
        Kefeng Wang <wangkefeng.wang@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This duplicates a patch submitted earlier by Kefeng Wang
<wangkefeng.wang@huawei.com> which I plan to merge later today into
cifs-2.6.git for-next

On Wed, Jun 5, 2019 at 4:14 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> From: Enrico Weigelt <info@metux.net>
>
> IS_ERR() already calls unlikely(), so this extra unlikely() call
> around IS_ERR() is not needed.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
>  fs/cifs/dfs_cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
> index e3e1c13..1692c0c 100644
> --- a/fs/cifs/dfs_cache.c
> +++ b/fs/cifs/dfs_cache.c
> @@ -492,7 +492,7 @@ static struct dfs_cache_entry *__find_cache_entry(unsigned int hash,
>  #ifdef CONFIG_CIFS_DEBUG2
>                         char *name = get_tgt_name(ce);
>
> -                       if (unlikely(IS_ERR(name))) {
> +                       if (IS_ERR(name)) {
>                                 rcu_read_unlock();
>                                 return ERR_CAST(name);
>                         }
> --
> 1.9.1
>


-- 
Thanks,

Steve