Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7326401ybi; Wed, 5 Jun 2019 15:35:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwacnxGh075e06XBcnpzIbzqUN8bumT8eAQ9m41jNvGLUhcJpqoBope+9rKPmNnKeEFY5GP X-Received: by 2002:a63:2b88:: with SMTP id r130mr205591pgr.348.1559774117566; Wed, 05 Jun 2019 15:35:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559774117; cv=none; d=google.com; s=arc-20160816; b=ec86bOWoKYPpSn/CSFmB/zflYYgclbnMY2SoNdbJwMZrzaft6yM5mpM5VUKNBOI5+g zQb+fC7z166XsB84pKnfzROomyHEZuhrgAcy1IDdpsMZZ5DhnZ2jS5Fytr9BQyU8wf88 vHFeSkjKlYcRE4TAAnNtKyoWsMwW1QayXW3ZiYg1peupHLeXTHdwgDJojRJfTpveUC2E c0OwNIBSt77pZ1tQDKiheviQpe9YDe/oNid1GFdV2Ees6Qoyt9AIPzBhnL5ysWIgEyMy uNE7kDei564uKmmNJyhuPZ2RtL7GYhZ56qwawvu9fhOCvNbQE2GGyXvpWje2lgkXopSR 04aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=+u7YBm8vYOGPGCeUSL8Dah2U8LU1aVEixolaff3h19A=; b=xeUpJRtn8mAyVsgXzHPIiVfn6V6uGVP9tucDkQMCpCY7QnufAbkEBQLP0ieakT7SUY v2PzoYpMQf9cORDgdcVT3p1rs85y1ojxde5r0ueu47KaVhw/anvKPrHL60MFPqxKnM/k /zgc+TO+1qQ/pF9qGueKxArZ08SWbOF36k0oYwu0WqyTlz1O98WlK1LrypXMwPo0RP+R jl3ZG4xH4D2AwaJsQYtAvNZ/of52y3DJ4dj7qqd3v+6GmIr2J/sPW839Qald854TPNxD 5hdD96IahzieDWBZVcGkW8pznWzlMusgRaM5vnJBjxB6jv3B8goz8AD0mr1PWsBhgLib N4aQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y186si21696221pfy.212.2019.06.05.15.35.01; Wed, 05 Jun 2019 15:35:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726726AbfFEWdu (ORCPT + 99 others); Wed, 5 Jun 2019 18:33:50 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:38288 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726502AbfFEWds (ORCPT ); Wed, 5 Jun 2019 18:33:48 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E24FB374; Wed, 5 Jun 2019 15:33:47 -0700 (PDT) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.195.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1FE503F5AF; Wed, 5 Jun 2019 15:33:45 -0700 (PDT) Date: Wed, 5 Jun 2019 23:33:43 +0100 From: Qais Yousef To: Christoph Hellwig Cc: Peter Zijlstra , Ingo Molnar , Steven Rostedt , linux-kernel@vger.kernel.org, Pavankumar Kondeti , Sebastian Andrzej Siewior , Uwe Kleine-Konig , Dietmar Eggemann , Quentin Perret Subject: Re: [PATCH v3 0/6] sched: Add new tracepoints required for EAS testing Message-ID: <20190605223343.r42pgngvs7myzfke@e107158-lin.cambridge.arm.com> References: <20190604111459.2862-1-qais.yousef@arm.com> <20190605061748.GA20661@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190605061748.GA20661@infradead.org> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/19 23:17, Christoph Hellwig wrote: > > The following patches add the bare minimum tracepoints required to perform EAS > > testing in Lisa[1]. > > What is EAS? Whhy is "Lisa" not part of the patch submission? > submission. EAS is Energy Aware Scheduling. It was merged in 5.0. Lisa is a python based testing platform that has dependency on other binaries like trace-cmd, rt-app, etc. It is not suitable for kernel submission. Lisa, or any userspace based testing for that matter, requires to know what's happening inside the scheduler to test its behavior. I don't know know of any other scheduler centric testing framework. I didn't intend to specify Lisa as the sole user and reason for these tracepoints, I know others are interested in these tracepoints in general for anyone who wants to achieve a similar goal of studying scheduler PELT behavior and how it affects some of the decisions it makes. We had a talk in OSPM a couple of weeks ago to cover this topic if you're interested to learn more https://www.youtube.com/watch?v=I_MZ9XS3_zc > > > It is done in this way because adding new TRACE_EVENTS() is no longer accepted > > AFAIU. > > Huh? We keep adding trace events all the time. And they actually > are useful because they are testable. > > This series on the other hand adds exports not used in tree, which is > a big no-go. I see that Peter has already covered this part. Thanks -- Qais Yousef