Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7388922ybi; Wed, 5 Jun 2019 16:59:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqyz4BAsVaNHOkV2T7WbhkrdXCn1byOcFuVkMOrGO13z/PNX9GDBF6p7gv2zvi3ps1bgsaUf X-Received: by 2002:a17:90a:29a4:: with SMTP id h33mr41601280pjd.105.1559779169469; Wed, 05 Jun 2019 16:59:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559779169; cv=none; d=google.com; s=arc-20160816; b=ZS3bn+lD+WTK8mXugwfk3bojYyMDaoYXMpGqpPAODLVOD6UnjLcqWL/16F49vyYImT KPlV9rxEYhna7mkzLV/67gNblW4WKCwr6Ta5pUifs986oAva8ibD6sDd+TWrqu/EeQvn Z/UD2I6NdaWnCjLycY68Fwq+l+HjyKwKFqk4ZsNTvQfWf848GYEjhHhuXoEcIcAOcWiW BlEKLt3/fmEfya2JVTXQ7WbYv+labZHiJGHDKEv7pY8IFOH+AFDb1qUlF9pinVDT1VmU tixZ0kN97stNqX5/2EAD9Ujo0nOGN5bjEU1HPzfRudXmKzf/dj9VAFPCoLdk0uIceqtw pXcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=EVhkqqY3QHOFrCyXo4ociW05U8aWpBRg/8XDCQw8z0U=; b=RyBKaSbmNfY2ByQGEPmLQTo861lazEA453vRUPzgX9hl+SaOuO02oX1mjC82EBW48y Zq2nPsUz1UKTK+BGWo68IQRPGf8ehy2LVZ5MPvuRXkwHDiTL3x5ZQjwnWt1N6gSnIuDG 4Uy8uxlv9LbcFqv2Y81SyW76Whp+5v6jD5PqtJpFPZKhHkCSUmFzgZ3kKbVvY6EfCe8e epX0dQSP7zSLpAXJXnLuXOB58aD6b6cmSVsqdTEjRrGjs91MURDHmgegu8x5qgyPfTXk qNitfLaCZ2sMuIIM1+TE11mYFVCq0nKEWP5+nqjZ0ZQMSg8yEgTDGAdgUYVWg7t9i1fy ClHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k15si86595pfi.61.2019.06.05.16.59.13; Wed, 05 Jun 2019 16:59:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726788AbfFEX6B (ORCPT + 99 others); Wed, 5 Jun 2019 19:58:01 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:42532 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbfFEX6B (ORCPT ); Wed, 5 Jun 2019 19:58:01 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EA035136E16AB; Wed, 5 Jun 2019 16:58:00 -0700 (PDT) Date: Wed, 05 Jun 2019 16:58:00 -0700 (PDT) Message-Id: <20190605.165800.351777565833375126.davem@davemloft.net> To: info@metux.net Cc: linux-kernel@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com, marcelo.leitner@gmail.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: sctp: drop unneeded likely() call around IS_ERR() From: David Miller In-Reply-To: <1559768607-17439-1-git-send-email-info@metux.net> References: <1559768607-17439-1-git-send-email-info@metux.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 05 Jun 2019 16:58:01 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Enrico Weigelt, metux IT consult" Date: Wed, 5 Jun 2019 23:03:27 +0200 > From: Enrico Weigelt > > IS_ERR() already calls unlikely(), so this extra unlikely() call > around IS_ERR() is not needed. > > Signed-off-by: Enrico Weigelt Skipping this because of the overlap...