Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7443841ybi; Wed, 5 Jun 2019 18:10:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqzutdfOnE8HtCSI9Gtsn22u3hOJjmP/ixIYj2ld95oLn97DBKZzm2Q1ulzcr5QR40VoodUz X-Received: by 2002:a63:158:: with SMTP id 85mr723655pgb.101.1559783445467; Wed, 05 Jun 2019 18:10:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559783445; cv=none; d=google.com; s=arc-20160816; b=ps1dKLXKjcUpRwB7L0fiG0InmNlkE6ZKf8O15jB6+NlqmZdeilfvu6VBhEjGc5VVej ictF6ieY4EfBrbOxAjLxGzjm+DxeSzqGhqwPuNE203La//T89Es4YeuWjPa9jPpr9Uzy rnbq21uBB7ZdaLe5OkC9/r8p5RoP01hua6hHnpSkII1E87VNWICNgIcm5uCAhwXF643E W3rwEnp0Ip/GK2VFayunl80UMbkcndWeDS3ND7KkLypdlFat0nwNOTFHzAzfwWctEpUx BwIlx7gab7Yd4sbWR/UAz8bqT6IR1wfch8+8iqwR9/9DUKHpdQPqQX/EFy33qGzBrMYf VVJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GP8GrUO0aq50NCOCxBaAISfvqpwLWVgfaAVgMc9u37s=; b=f9iFBxEXeATJnT2e/R+ALXhhraKHEm0h96N1ZUiySDSoHE6G9y+xEFaMhucO16jckj jO0mm2IYrpXEXi7lvk/HAVSdw5lILdTEP28JtV01fYiv19Fz/hwom8CLnfCx8p4Ac6+3 n8luaMjqxV+05f5ihQmq8o54rMtD6iS87bO+KY6rmV2p2x+8ZwMOPHVEX6P21azWO5Y4 WON1JECoGglkF4+YwOmDh+dAAgYTAFNK+H9urHKLBqk30ZstUE4zOf0rSl4bxyF7RKSu U9NQN3Ccgy/JrTl5OQdYSm3hHOLTfvlIKCdNKk+3a+Of0uStTjyMOyC9eBket9XL/x0N L3jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2mEGngSq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h9si363120pgq.539.2019.06.05.18.10.28; Wed, 05 Jun 2019 18:10:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2mEGngSq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726606AbfFFBI7 (ORCPT + 99 others); Wed, 5 Jun 2019 21:08:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:60980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726561AbfFFBI7 (ORCPT ); Wed, 5 Jun 2019 21:08:59 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B74062070B; Thu, 6 Jun 2019 01:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559783339; bh=rLe4wDM1i8CUFx415ydIm5XkrbpThXQyTUO1Dg0eLXI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2mEGngSqWpMxkHC7m+iR4PKQmzOLiH0JMRN2BOqO+Wp2Hu17PHY9+axqBQ/jWRmsm ZZrML5vbocNStOeyg/rZLakuwSZlHaH6qv+nT3ohes3ARlc3pb5RZooNej7ZAQ79UQ S85Up0xct/oDOWO4Uc7X6s+k6uzfxIK4ZHBV8+oo= Date: Wed, 5 Jun 2019 21:08:57 -0400 From: Sasha Levin To: Chunyan Zhang Cc: Greg Kroah-Hartman , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Grygorii Strashko , "Rafael J . Wysocki" , Chunyan Zhang Subject: Re: [BACKPORT 4.4.y] PM / sleep: prohibit devices probing during suspend/hibernation Message-ID: <20190606010857.GF29739@sasha-vm> References: <20190605111412.3461-1-zhang.chunyan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190605111412.3461-1-zhang.chunyan@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 05, 2019 at 07:14:12PM +0800, Chunyan Zhang wrote: >From: "Strashko, Grygorii" > >[ Upstream commit 013c074f8642d8e815ad670601f8e27155a74b57 ] > >It is unsafe [1] if probing of devices will happen during suspend or >hibernation and system behavior will be unpredictable in this case. >So, let's prohibit device's probing in dpm_prepare() and defer their >probing instead. The normal behavior will be restored in >dpm_complete(). > >This patch introduces new DD core APIs: > device_block_probing() > It will disable probing of devices and defer their probes instead. > device_unblock_probing() > It will restore normal behavior and trigger re-probing of deferred > devices. > >[1] https://lkml.org/lkml/2015/9/11/554 > >Signed-off-by: Grygorii Strashko >Acked-by: Pavel Machek >Signed-off-by: Rafael J. Wysocki >Signed-off-by: Chunyan Zhang This patch had to be fixed a few times (see 015bb5e134 and 9a2a5a638f8), we can't just take it as is. It might be just simpler to move to a newer kernel at this point. -- Thanks, Sasha