Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7469414ybi; Wed, 5 Jun 2019 18:47:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqzPhfM0ESw9P+nqUcAPrp5/7SCXdr23QZqJdLiOnPISWmhGqFtkD0Xiaz9QYv+7p2+5TjxK X-Received: by 2002:a17:90a:9201:: with SMTP id m1mr48564586pjo.38.1559785645022; Wed, 05 Jun 2019 18:47:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559785645; cv=none; d=google.com; s=arc-20160816; b=AVMcz1eAikCUo2g1+7/Wq44nebfEBRZjCucgQFTfbkSuG6OQ3+8oJy8AII2ZogbuDh eHr2UiKa/oLZgKfRWm4Snr2UeGeRSSGwG8FOJ1rfETEP90dnWfN7dWt59fcQ71Bsm4BC n1dEt7AN4kaVsma/HZ55ZmZKrULcVaGRVAP3kBR3SE4zd8cLbiCNonTFpy8ApD1/Sifg pRvlQoZ7mO/PjKu3KneySuV87RMM75VrqEsCmQJ49Rrccvd1dl6m+45IezkzBqiy1IWE V5bzHn4lnXj+ZHHp4jzRv+0XLDJjazJX24dC1Ihn1XUF8Bi7srvvvOPN90uD3Nez1Ch3 nUKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=uaTRZLRYkOF6zdKGHzjPlcXa4k/4GB2jeuLkq5t3Y0A=; b=jUWEegSpcS57NsnlipJ5v07ZzBLVFKFD8v9wSRIxIHL5tJ7I7GrOGm5x+VmSjJnM/m zRj0F404z4btRmyLDzz8AElOR6zQGBBt7x9noyHQ7GKccNFVGyHsnvZZeoMTT8tVVGaD 21zOZm7GMPzrAb5Vvq5cRi+CSvSILeNwFz1NiYeGb6XwGzKb3SBLDtE3PEfIZ4UN97FU jui3EoEiwKkXEy/8zzc2DtbmAR5THRorvEI4Xz70a8P5v1iuGUYtoEb541TOA2PacKtt fdlFPdIpjzVSTmLuaUSfO9c5gvKRoMWR+e8oG341mkfuOJ95Hw+pQFGhVH5d9kpZi0N1 QubA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g190si555106pgc.1.2019.06.05.18.47.08; Wed, 05 Jun 2019 18:47:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726997AbfFFBpm (ORCPT + 99 others); Wed, 5 Jun 2019 21:45:42 -0400 Received: from mga03.intel.com ([134.134.136.65]:36145 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726863AbfFFBpV (ORCPT ); Wed, 5 Jun 2019 21:45:21 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2019 18:45:21 -0700 X-ExtLoop1: 1 Received: from iweiny-desk2.sc.intel.com ([10.3.52.157]) by orsmga002.jf.intel.com with ESMTP; 05 Jun 2019 18:45:20 -0700 From: ira.weiny@intel.com To: Dan Williams , Jan Kara , "Theodore Ts'o" , Jeff Layton , Dave Chinner Cc: Ira Weiny , Matthew Wilcox , linux-xfs@vger.kernel.org, Andrew Morton , John Hubbard , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH RFC 07/10] fs/ext4: Fail truncate if pages are GUP pinned Date: Wed, 5 Jun 2019 18:45:40 -0700 Message-Id: <20190606014544.8339-8-ira.weiny@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190606014544.8339-1-ira.weiny@intel.com> References: <20190606014544.8339-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ira Weiny If pages are actively gup pinned fail the truncate operation. Signed-off-by: Ira Weiny --- fs/ext4/inode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 75f543f384e4..1ded83ec08c0 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -4250,6 +4250,9 @@ int ext4_break_layouts(struct inode *inode, loff_t offset, loff_t len) if (!page) return 0; + if (page_gup_pinned(page)) + return -ETXTBSY; + error = ___wait_var_event(&page->_refcount, atomic_read(&page->_refcount) == 1, TASK_INTERRUPTIBLE, 0, 0, -- 2.20.1