Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1559729351-20244-1-git-send-email-wanpengli@tencent.com>
 <1559729351-20244-3-git-send-email-wanpengli@tencent.com> <16c54182-7198-f476-080b-5876cd871e42@redhat.com>
In-Reply-To: <16c54182-7198-f476-080b-5876cd871e42@redhat.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Thu, 6 Jun 2019 13:33:10 +0800
Message-ID: <CANRm+Cyzf_P_npJMBDbHN1g+GDfKsNR23bNWXMuUCtFq_caQnQ@mail.gmail.com>
Subject: Re: [PATCH 2/3] KVM: LAPIC: lapic timer is injected by posted interrupt
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 5 Jun 2019 at 20:30, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 05/06/19 12:09, Wanpeng Li wrote:
> > +static void apic_timer_expired_pi(struct kvm_lapic *apic)
> > +{
> > +     struct kvm_timer *ktimer = &apic->lapic_timer;
> > +
> > +     kvm_apic_local_deliver(apic, APIC_LVTT);
> > +     if (apic_lvtt_tscdeadline(apic))
> > +             ktimer->tscdeadline = 0;
> > +     if (apic_lvtt_oneshot(apic)) {
> > +             ktimer->tscdeadline = 0;
> > +             ktimer->target_expiration = 0;
> > +     }
> > +}
>
> Please rename this function to kvm_apic_inject_pending_timer_irqs and
> call it from kvm_inject_apic_timer_irqs.
>
> Then apic_timer_expired can just do
>
>         if (atomic_read(&apic->lapic_timer.pending))
>                 return;
>
> +       if (unlikely(posted_interrupt_inject_timer(apic->vcpu))) {
> +               kvm_apic_inject_pending_timer_irqs(apic);
> +               return;
> +       }

Do it in v2.

Regards,
Wanpeng Li