Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1559222962-22891-1-git-send-email-ufo19890607@gmail.com>
In-Reply-To: <1559222962-22891-1-git-send-email-ufo19890607@gmail.com>
From:   =?UTF-8?B?56a56Iif6ZSu?= <ufo19890607@gmail.com>
Date:   Thu, 6 Jun 2019 14:05:44 +0800
Message-ID: <CAHCio2gFbPn_m4AkMzLXuathtk8sW-cqtXAB6nkTwpbFmMf-aw@mail.gmail.com>
Subject: Re: [PATCH] perf record: Add support to collect callchains from
 kernel or user space only.
To:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, David Ahern <dsahern@gmail.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Milian Wolff <milian.wolff@kdab.com>,
        Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        Wind Yu <yuzhoujian@didichuxing.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Wang Nan <wangnan0@huawei.com>
Cc:     linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        acme@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

PING


ufo19890607 <ufo19890607@gmail.com> =E4=BA=8E2019=E5=B9=B45=E6=9C=8830=E6=
=97=A5=E5=91=A8=E5=9B=9B =E4=B8=8B=E5=8D=889:29=E5=86=99=E9=81=93=EF=BC=9A
>
> From: yuzhoujian <yuzhoujian@didichuxing.com>
>
> One can just record callchains in the kernel or user space with
> this new options. We can use it together with "--all-kernel" options.
> This two options is used just like print_stack(sys) or print_ustack(usr)
> for systemtap.
>
> Show below is the usage of this new option combined with "--all-kernel"
> options.
>         1. Configure all used events to run in kernel space and just
> collect kernel callchains.
>         $ perf record -a -g --all-kernel --kernel-callchains
>         2. Configure all used events to run in kernel space and just
> collect user callchains.
>         $ perf record -a -g --all-kernel --user-callchains
>
> Signed-off-by: yuzhoujian <yuzhoujian@didichuxing.com>
> ---
>  tools/perf/Documentation/perf-record.txt | 6 ++++++
>  tools/perf/builtin-record.c              | 4 ++++
>  tools/perf/perf.h                        | 2 ++
>  tools/perf/util/evsel.c                  | 4 ++++
>  4 files changed, 16 insertions(+)
>
> diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Docume=
ntation/perf-record.txt
> index de269430720a..b647eb3db0c6 100644
> --- a/tools/perf/Documentation/perf-record.txt
> +++ b/tools/perf/Documentation/perf-record.txt
> @@ -490,6 +490,12 @@ Configure all used events to run in kernel space.
>  --all-user::
>  Configure all used events to run in user space.
>
> +--kernel-callchains::
> +Collect callchains from kernel space.
> +
> +--user-callchains::
> +Collect callchains from user space.
> +
>  --timestamp-filename
>  Append timestamp to output file name.
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index e2c3a585a61e..dca55997934e 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -2191,6 +2191,10 @@ static struct option __record_options[] =3D {
>         OPT_BOOLEAN_FLAG(0, "all-user", &record.opts.all_user,
>                          "Configure all used events to run in user space.=
",
>                          PARSE_OPT_EXCLUSIVE),
> +       OPT_BOOLEAN(0, "kernel-callchains", &record.opts.kernel_callchain=
s,
> +                   "collect kernel callchains"),
> +       OPT_BOOLEAN(0, "user-callchains", &record.opts.user_callchains,
> +                   "collect user callchains"),
>         OPT_STRING(0, "clang-path", &llvm_param.clang_path, "clang path",
>                    "clang binary to use for compiling BPF scriptlets"),
>         OPT_STRING(0, "clang-opt", &llvm_param.clang_opt, "clang options"=
,
> diff --git a/tools/perf/perf.h b/tools/perf/perf.h
> index d59dee61b64d..711e009381ec 100644
> --- a/tools/perf/perf.h
> +++ b/tools/perf/perf.h
> @@ -61,6 +61,8 @@ struct record_opts {
>         bool         record_switch_events;
>         bool         all_kernel;
>         bool         all_user;
> +       bool         kernel_callchains;
> +       bool         user_callchains;
>         bool         tail_synthesize;
>         bool         overwrite;
>         bool         ignore_missing_thread;
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index a6f572a40deb..a606b2833e27 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -680,6 +680,10 @@ static void __perf_evsel__config_callchain(struct pe=
rf_evsel *evsel,
>
>         attr->sample_max_stack =3D param->max_stack;
>
> +       if (opts->kernel_callchains)
> +               attr->exclude_callchain_user =3D 1;
> +       if (opts->user_callchains)
> +               attr->exclude_callchain_kernel =3D 1;
>         if (param->record_mode =3D=3D CALLCHAIN_LBR) {
>                 if (!opts->branch_stack) {
>                         if (attr->exclude_user) {
> --
> 2.14.1
>