Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7704009ybi; Wed, 5 Jun 2019 23:38:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqyCp1nb/nfriqTKv2kfSTtIxFnSb8WmnptOgYP3PC3LeHhrfinYab6teSqJiKxMTJ9PSsa0 X-Received: by 2002:a63:4e10:: with SMTP id c16mr1893148pgb.214.1559803094878; Wed, 05 Jun 2019 23:38:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559803094; cv=none; d=google.com; s=arc-20160816; b=GpeTLhJfQwsNevgLsWI7xe+6DK3SdLXiYXgrw/Dsh4Q3TiWlsRs4IzQlfLwBQndlHR Qdii+xr/0g6RZhWJ0PUN5bKhLikUHauRlmuqwoO5pc57BTn06apjWNg241fWzNpvm/3x X8D0rZrT6/DbgbiEkYCxzkdvdzyGjBefnX2CIFD17rO7ZanZ2PY/O7Is5+Ya9+yPuQGg ayLc8eSs43D3nIGsYfX/icbhPKoaAZ6shZGKHeFCbPrLXDtG00sGEOmBfv5YoMIGJ/9i H955G4Gg2dzTpA92RshotdyColiKN7QBki1x/QNfn3s5ZrnA7+buLztsxSv18CY8eZMo hd8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :wdcipoutbound:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature:dkim-signature; bh=sdhSAoDoPtdHbdxwUQZniSOsm6I76sfh9IxmQMqTqks=; b=wBkQjCQZVN7DBqPKEZWJxqqsbcJgz7dUoWH2KeLZaoQ6ZLUi2fkXdlynlKMS76p4nx i7gHm7CETl1itlWVa0Ksh3+GPQqqcx7aT8QWOpiVckeW82/lGmwReMmwLO9k3CsWsx/x 2HOA2PtEWXkgIy88hFIM9WGYxFNeXXG58ztICo5aEQdLU77pbW+jGi812VTFJl8bx3TX k7J1NoEv2F/VcjWJ7egzfJSdKJvwv7MgI3uQp3l0Jb7/eKGk11SSNqPrUQMWCpzKJpoM DxvglJLEwrYqwv6xKZLX0cZupnUfAojRyIOjOW64tkVi+9dFb69cwCv4xgM7l9d7cdH/ WFRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=LcmEO5cc; dkim=pass header.i=@sharedspace.onmicrosoft.com header.s=selector2-sharedspace-onmicrosoft-com header.b=r85ctanC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=wdc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l15si1204260pgm.548.2019.06.05.23.37.58; Wed, 05 Jun 2019 23:38:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=LcmEO5cc; dkim=pass header.i=@sharedspace.onmicrosoft.com header.s=selector2-sharedspace-onmicrosoft-com header.b=r85ctanC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=wdc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726667AbfFFGga (ORCPT + 99 others); Thu, 6 Jun 2019 02:36:30 -0400 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:12850 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbfFFGga (ORCPT ); Thu, 6 Jun 2019 02:36:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1559803027; x=1591339027; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GROh4qCTdCjDOeNTyHdfWCyNWpdwRCHJ5JXYERWlgu0=; b=LcmEO5ccA5R3PSpAdvlFBX9D2Rl46oBQQBrXh17CJIgev0B9pPavXGo0 tBGbmgFz8CAvjZuqhX0VLnhFmUjobZHV6cM1n+/lUHjugGnODX3cgcudw 6owL02qnvaAk0pAn5LIbVaLzgzZYsgtlUzQZP/Hca/HnJT9OuMbIafd5B tBVWtFO4by7q209gB7JbPUrG5puAD7KmQUFOsJq0/n8XJcEHU1xiTJ3/3 ECAJbQ6l/Ara4fOSmJNi92FzhvgZIByFvGBib9HU9+uv0IoDSN7KOSnoF V+ZscA37J1Ll4TxucJv2pz9gOMAeQmkKNQZtk3PWu8Qg8gMvsB4DCpRa/ w==; X-IronPort-AV: E=Sophos;i="5.63,558,1557158400"; d="scan'208";a="209549030" Received: from mail-dm3nam03lp2051.outbound.protection.outlook.com (HELO NAM03-DM3-obe.outbound.protection.outlook.com) ([104.47.41.51]) by ob1.hgst.iphmx.com with ESMTP; 06 Jun 2019 14:37:05 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sdhSAoDoPtdHbdxwUQZniSOsm6I76sfh9IxmQMqTqks=; b=r85ctanC0fsTOgTMTSpXJQeucLOZXrTbELDDxPuNqbha/lpON5SeAUkdliMS2/TiDpilTRrdLy5eE17SFFhymJljpvIVaLoThnm1777p6y8tvW70XnBxHwvqiODJbqk0aKFfOAS+91ySGcU+qXrjzgYB2BMee7KmAI/8e4YTtU8= Received: from SN6PR04MB4925.namprd04.prod.outlook.com (52.135.114.82) by SN6PR04MB4158.namprd04.prod.outlook.com (52.135.71.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.21; Thu, 6 Jun 2019 06:36:22 +0000 Received: from SN6PR04MB4925.namprd04.prod.outlook.com ([fe80::6d99:14d9:3fa:f530]) by SN6PR04MB4925.namprd04.prod.outlook.com ([fe80::6d99:14d9:3fa:f530%6]) with mapi id 15.20.1943.018; Thu, 6 Jun 2019 06:36:22 +0000 From: Avri Altman To: Bjorn Andersson , Rob Herring , Mark Rutland , Alim Akhtar , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" CC: Andy Gross , Linus Walleij , Evan Green , "linux-arm-msm@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" Subject: RE: [PATCH v2 2/3] scsi: ufs: Allow resetting the UFS device Thread-Topic: [PATCH v2 2/3] scsi: ufs: Allow resetting the UFS device Thread-Index: AQHVHAOW/gPfCB+BCUqDoLF2sKUkJqaOK2sA Date: Thu, 6 Jun 2019 06:36:22 +0000 Message-ID: References: <20190606010249.3538-1-bjorn.andersson@linaro.org> <20190606010249.3538-3-bjorn.andersson@linaro.org> In-Reply-To: <20190606010249.3538-3-bjorn.andersson@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Avri.Altman@wdc.com; x-originating-ip: [212.25.79.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41b35a9c-4567-4f04-99d2-08d6ea494a7d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:SN6PR04MB4158; x-ms-traffictypediagnostic: SN6PR04MB4158: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 00603B7EEF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(73956011)(76116006)(66446008)(66556008)(64756008)(66476007)(86362001)(66946007)(99286004)(14454004)(7416002)(74316002)(5660300002)(4326008)(6246003)(478600001)(68736007)(52536014)(256004)(102836004)(72206003)(305945005)(25786009)(71190400001)(71200400001)(7696005)(4744005)(6506007)(66066001)(53936002)(76176011)(186003)(2906002)(8676002)(81156014)(81166006)(8936002)(26005)(3846002)(55016002)(486006)(9686003)(110136005)(54906003)(6116002)(33656002)(7736002)(316002)(476003)(446003)(11346002)(6436002)(229853002);DIR:OUT;SFP:1102;SCL:1;SRVR:SN6PR04MB4158;H:SN6PR04MB4925.namprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: O5fXCumXJe8xh/1Hp2CY2EBrpkx9FbkYVpUAE8hwX2oD97nmXB9OQQ0b2zUuSuc0Y74A4G7oDbiORHOKwzTvoJQBNdWu0fqHv/EJuCj1GxdCyBQ7Et4lq6ky9OSZMrO2NZBO39uc22jBHDaQ3LV8lgDeTwiwOVFCvj86kSEJHKY0OjHwDblXP1KDw72uW0lVZoEz3fq+SZLRFeXxcEm0fCIzAY8oKEMBvpUuNKUIX4HHTkMohViLzpa33wd8OlpA6cJJFFZeGKsLc8wO3nJ2clndAtDjhnoBxcIWVDwkR/3woM1l05coO5GOBjaIPZWgp+Tb3OK0llWSyV+fNLjJvQ64bKg/WK8VVRDjUZc1ZS4Xz2oofqjvqSgJZcWjM8DmF1dvi4VXj7cwVEMqzSSUxU0NtajthYpOGAPhpCX9GPw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41b35a9c-4567-4f04-99d2-08d6ea494a7d X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2019 06:36:22.1322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Avri.Altman@wdc.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4158 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static int ufshcd_hba_init(struct ufs_hba *hba) > { > int err; > @@ -7425,9 +7460,15 @@ static int ufshcd_hba_init(struct ufs_hba *hba) > if (err) > goto out_disable_vreg; >=20 > + err =3D ufshcd_init_device_reset(hba); > + if (err) > + goto out_disable_variant; > + > hba->is_powered =3D true; > goto out; >=20 > +out_disable_variant: > + ufshcd_vops_setup_regulators(hba, false); Is this necessary? ufshcd_vops_setup_regulators() was just called as part of ufshcd_variant_hb= a_init Thanks, Avri