Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7852115ybi; Thu, 6 Jun 2019 02:33:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqyWl1DgmwHCS58TFziIGiRcjML+BJJekg7EpSsErPOWIYink0+rJQydUClzXdLGGtQUuW69 X-Received: by 2002:a62:3741:: with SMTP id e62mr52613344pfa.213.1559813616324; Thu, 06 Jun 2019 02:33:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559813616; cv=none; d=google.com; s=arc-20160816; b=f0iOVMobl6wqOIXQod+pdZ9OjFCh6kESpLgAkQjlzwLGAjngwi/uC04NBcW9AErZLZ iZjy0X+6HOLz3JDb06swGOhSTKkBXN4/MKFYnu3wrwPxhM660m/rMUZjHJ5iE7k/4mcR DZYcAu6GIMjPck57F7Xk+L2kaTNy9Yw+t4kTZujwuBASAccEW4ZkmU4WA6lfWsxRDUa3 fEobfBbwIfkU/BO+stGxIIUOrQe51HdF6DM0S6RYhvr94s4AOGYrfcm8fvsDvOQRe3OV qIKwMt0O6G9DBdTK4IUOYNIwcQN6v08xGxWhI44oG3LbbUVjFsBvM/FewF6o+uW1HoEo RjAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=kAkC8VrYXvUXZtGn4S66nxEy5QJIRM2zn+lvwfDl7yo=; b=RVTKMyyRH8WEGziGB2idhXA9oXabgrgrwnjNe/xqYeCWfLDBK2YZmRqkuIsJlDYsKD PuMm34F2kV3JAIUoc1LX+8uz3O2nc7cteXmeXEUwi/0wx5RQ1rQFImYYfbxORc0gCcZG uBk4SCLGe+uOK88HzBjc0WV4Vn09c17hnn9UH6muGTL9qHweXBUVPzKgraoSdKkdAj6y HJcg6syRCa4+WcQapR4gr4kJF5Y4VUGbs1uGTELXTBTT6ngpOPuPWVV9iQq8e2gsmDkn PSITrLLV37+/DsGeBZm4J3RHRBt9wRN5xVX23WEssEgsDfhHv0T93SA6b/Bg5tLH5LYQ YijA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x7si1455261plv.130.2019.06.06.02.33.19; Thu, 06 Jun 2019 02:33:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727887AbfFFJcI (ORCPT + 99 others); Thu, 6 Jun 2019 05:32:08 -0400 Received: from foss.arm.com ([217.140.101.70]:43590 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727509AbfFFJcH (ORCPT ); Thu, 6 Jun 2019 05:32:07 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EEBE180D; Thu, 6 Jun 2019 02:32:06 -0700 (PDT) Received: from e112298-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DB04C3F690; Thu, 6 Jun 2019 02:32:04 -0700 (PDT) From: Julien Thierry To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, marc.zyngier@arm.com, yuzenghui@huawei.com, wanghaibin.wang@huawei.com, james.morse@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, mark.rutland@arm.com, liwei391@huawei.com, Julien Thierry Subject: [PATCH v3 1/8] arm64: Do not enable IRQs for ct_user_exit Date: Thu, 6 Jun 2019 10:31:50 +0100 Message-Id: <1559813517-41540-2-git-send-email-julien.thierry@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1559813517-41540-1-git-send-email-julien.thierry@arm.com> References: <1559813517-41540-1-git-send-email-julien.thierry@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For el0_dbg and el0_error, DAIF bits get explicitly cleared before calling ct_user_exit. When context tracking is disabled, DAIF gets set (almost) immediately after. When context tracking is enabled, among the first things done is disabling IRQs. What is actually needed is: - PSR.D = 0 so the system can be debugged (should be already the case) - PSR.A = 0 so async error can be handled during context tracking Do not clear PSR.I in those two locations. Signed-off-by: Julien Thierry Cc:Catalin Marinas Cc: Will Deacon Cc: Mark Rutland Cc: Marc Zyngier --- arch/arm64/kernel/entry.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S index cd0c7af..89ab6bd 100644 --- a/arch/arm64/kernel/entry.S +++ b/arch/arm64/kernel/entry.S @@ -870,7 +870,7 @@ el0_dbg: mov x1, x25 mov x2, sp bl do_debug_exception - enable_daif + enable_da_f ct_user_exit b ret_to_user el0_inv: @@ -922,7 +922,7 @@ el0_error_naked: enable_dbg mov x0, sp bl do_serror - enable_daif + enable_da_f ct_user_exit b ret_to_user ENDPROC(el0_error) -- 1.9.1