Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7855372ybi; Thu, 6 Jun 2019 02:37:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqzLKLK7K1kcvlYyFbuo6N6KiMD4dmAvEk07SQy/GN7LcXCV/Uq7HZcBn4w4rnIli3ou69JA X-Received: by 2002:a62:6d47:: with SMTP id i68mr52805980pfc.189.1559813852387; Thu, 06 Jun 2019 02:37:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559813852; cv=none; d=google.com; s=arc-20160816; b=n6hmmeHxRU7IhK8Ybg9cJa7q7dpKvjJ6+s05N+2mUp3wlOtlNAxmwyVbZAxw4tKXL5 OdcfsN7JjkWwwSgdvJPnk+qWngmc6N5jqTAti8M/Rqh3R72VPJuQfAREGnNq8o4GXnBA FZDA/FhNZufxt9jett7NS1l6xiYrjqa0rbdjpZUHiT+lYqn1ooQTxH6QJP81vtxzPi0R MtARVcbAF/hiAJzK/QuyC2YTonBz0l0U875huvfxhy2IIZAmR3rjDDqblLrcTp0k6iOv /+tGeSHeeDbp6n+aEgyhnzzUlr6wtrxexchnC2piZl642KmknY0hw/uiDp2VPvfh/nxy gIFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=HHp49uQlU5yIys64xH4zvS9Cue2SVr3RQK/YgKDpiRc=; b=luttBhi6VdgMHseODDbVcRITXy8X9Kmnacp4utc48lxmur0FvAHbQtFQql93Sc399w bQJExVMn3WB0k1+IX6W4JhoLeF+kvh0BUjX6ezMUucPRJ46GwZ0AXjmQ0ZWkx8dwYn1X QeslodhAguMuDZfjLKVsQ3UF2CBXpMqMDXXlnz5o9foaaP+cRPkMig6uk85/1G+8tSdN OejrF6MnsgD1wt2bJOOS55IvUz9yBDpNqTA0SUtGzSo6pYb4x/h5+vYrv7LUjJfUtpaK KaCDKdjVLsUcWiRe5cRTCuVwMLTCBQ7yXgjk5dI59EqotPxS7akZSXd6B9sEtXV8MPmD f1Eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AN2CNz7C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i95si1306983plb.106.2019.06.06.02.37.15; Thu, 06 Jun 2019 02:37:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AN2CNz7C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727923AbfFFJfQ (ORCPT + 99 others); Thu, 6 Jun 2019 05:35:16 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:40624 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727816AbfFFJfQ (ORCPT ); Thu, 6 Jun 2019 05:35:16 -0400 Received: by mail-io1-f65.google.com with SMTP id n5so138529ioc.7 for ; Thu, 06 Jun 2019 02:35:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HHp49uQlU5yIys64xH4zvS9Cue2SVr3RQK/YgKDpiRc=; b=AN2CNz7CPqZzivrS99g5nvwP/o/SgLHBsg/4sHt3Gs4l8ZE8woyNIea7FNZ+ZLVBs9 10My5n58np8Mog6V4seZA5WseaRXJL42mH3XFJho3fx5KAEGrLvh/B3CRxP75+hoXCZs yutgAOz6DZfYnD+C1SCiox4cawVPPNLBMCf9t8dwKI04O4kGiCd7c2Jjr/n8fqgzSIiS H1/AVWlWmtVtxOGX+Qm4cp0uMl8cAUWzNzyeVJwTJsegYoFIkG0U2hJ8qyVYHuOjZlDV WqbmmgQgR4GOiTE/hNEAD0H0E1uqB+MqNjm+3CN5fKeF1BIthAwuYe+Q8cxB4XWQ0DyS PWVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HHp49uQlU5yIys64xH4zvS9Cue2SVr3RQK/YgKDpiRc=; b=DBlfNdRUQRrkM9TgYxkwdptbJTYFN5XZKbyNsBOHnSJuEe8tySF4q3df3v2bgy+50x u1LxLYf8GBVNvbUwRnASN+OEWm7GpxIPCx/1zDUFfFe1Kr+PtZuFVZvKhYW4qwUiteJX v2ggUFuXfRVwcweT/PWpk5nquymPzA/M3mZPhiGtxe7VOLFI6nBzIN6RIeHv47jE1iVz bVmy51hpxue5sk43EzBGHMO1W99K23+99+1D2yx19HPkr/45nKX1wCy02VSOvgdKI+ZN AiILPYBG6bDomPCDnb9dHvZV6SG/vqx1pe0g5CzC3gf0hqpBsXrrILrddbRgLj64GZen 0YSQ== X-Gm-Message-State: APjAAAU32IYQoQwTuLUj62Hk7R28AVgFy0SOmpEDLdYFshZ4UtR+BSDp iJ8dGYAzOvtuXjyXYingrU63141+Si3KuyFfv385e/j5EBeaRw== X-Received: by 2002:a6b:e608:: with SMTP id g8mr5429025ioh.88.1559813714855; Thu, 06 Jun 2019 02:35:14 -0700 (PDT) MIME-Version: 1.0 References: <779905244.a0lJJiZRjM@devpool35> <20190605162626.GA31164@kroah.com> <20190606070807.GA17985@kroah.com> In-Reply-To: From: Ard Biesheuvel Date: Thu, 6 Jun 2019 11:34:54 +0200 Message-ID: Subject: Re: Building arm64 EFI stub with -fpie breaks build of 4.9.x (undefined reference to `__efistub__GLOBAL_OFFSET_TABLE_') To: Greg KH Cc: Nick Desaulniers , Rolf Eike Beer , Linus Torvalds , Matt Fleming , Peter Zijlstra , Thomas Gleixner , linux-efi , Linux Kernel Developers List , stable , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Jun 2019 at 10:58, Ard Biesheuvel wrote: > > On Thu, 6 Jun 2019 at 09:08, Greg KH wrote: > > > > On Thu, Jun 06, 2019 at 08:55:29AM +0200, Ard Biesheuvel wrote: > > > On Wed, 5 Jun 2019 at 22:48, Nick Desaulniers wrote: > > > > > > > > On Wed, Jun 5, 2019 at 11:42 AM Ard Biesheuvel > > > > wrote: > > > > > For the record, this is an example of why I think backporting those > > > > > clang enablement patches is a bad idea. > > > > > > > > There's always a risk involved with backports of any kind; more CI > > > > coverage can help us mitigate some of these risks in an automated > > > > fashion before we get user reports like this. I meet with the > > > > KernelCI folks weekly, so I'll double check on the coverage of the > > > > stable tree's branches. The 0day folks are also very responsive and > > > > I've spoken with them a few times, so I'll try to get to the bottom of > > > > why this wasn't reported by either of those. > > > > > > > > Also, these patches help keep Android, CrOS, and Google internal > > > > production kernels closer to their upstream sources. > > > > > > > > > We can't actually build those > > > > > kernels with clang, can we? So what is the point? > > > > > > > > Here's last night's build: > > > > https://travis-ci.com/ClangBuiltLinux/continuous-integration/builds/114388434 > > > > > > > > > > If you are saying that plain upstream 4.9-stable defconfig can be > > > built with Clang, then I am pleasantly surprised. > > > > I know some specific configs can, there's no rule that I know of that > > 'defconfig' support is required. But then again, it might also work, > > try it and see :) > > > > Well, it is the rule that the arm64 maintainers use. > > > > > Also, Android and CrOS have shipped X million devices w/ 4.9 kernels > > > > built with Clang. I think this number will grow at least one order of > > > > magnitude imminently. > > > > > > > > > > I know that (since you keep reminding me :-)), but obviously, Google > > > does not care about changes that regress GCC support. > > > > What are you talking about? Bugs happen all the time, what specifically > > did "Google" do to break gcc support? If you are referring to this > > patch, and it is a regression, of course I will revert it. But note > > that gcc and 4.9 works just fine for all of the other users right now, > > remember we do do a lot of testing of these releases. > > > > Don't get me wrong: I am not blaming Google for this. But having > strict Documented/ stable-rules, violating them by backporting patches > that are clearly not bug fixes, and *then* saying 'bugs happen all the > time' makes no sense to me at all. BTW I hit the same issue immediately building 4.9.180 defconfig + CONFIG_RANDOMIZE_BASE=y, using my distro GCC (6.3.0), so I'd say the testing coverage is not sufficient.