Date: Fri, 18 Nov 2005 22:17:44 -0800
From: Andrew Morton <akpm@osdl.org>
To: Dave Jones <davej@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: dell_rbu driver depends on x86[64]
Message-Id: <20051118221744.2aa58499.akpm@osdl.org>
In-Reply-To: <20051119061459.GA7335@redhat.com>
References: <20051118212938.GB3881@redhat.com>
	<20051118220144.11671174.akpm@osdl.org>
	<20051119061459.GA7335@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1395
Lines: 35

Dave Jones <davej@redhat.com> wrote:
>
> On Fri, Nov 18, 2005 at 10:01:44PM -0800, Andrew Morton wrote:
>  > Dave Jones <davej@redhat.com> wrote:
>  > >
>  > > This driver only appears on IA32 & EM64T boxes.
>  > > 
>  > > Signed-off-by: Dave Jones <davej@redhat.com>
>  > > 
>  > > --- linux-2.6.14/drivers/firmware/Kconfig~	2005-11-14 19:23:45.000000000 -0500
>  > > +++ linux-2.6.14/drivers/firmware/Kconfig	2005-11-14 19:24:18.000000000 -0500
>  > > @@ -60,6 +60,7 @@ config EFI_PCDP
>  > >  
>  > >  config DELL_RBU
>  > >  	tristate "BIOS update support for DELL systems via sysfs"
>  > > +	depends on X86
>  > >  	select FW_LOADER
>  > >  	help
>  > >  	 Say m if you want to have the option of updating the BIOS for your
>  > 
>  > Does it not compile on other architectures?  If it does, there's an
>  > argument for leaving it there, for compile coverage.
> 
> If this were a "only works on non-x86" driver, I'd agree, but
> x86 drivers probably get way more coverage than any arch already,
> so I don't we really gain much by having this available on
> archs that can't run it.
> 

Where's the advantage in removing it from non-x86 builds?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/