Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7981686ybi; Thu, 6 Jun 2019 04:54:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqw3z0Z/CJnadxIWkjMpjBHhLriN4k0TAnJBIFTQlFhJ/jm1GUhxIVn+QxisTwBlSx1zYQNQ X-Received: by 2002:a63:a055:: with SMTP id u21mr3006473pgn.5.1559822085504; Thu, 06 Jun 2019 04:54:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559822085; cv=none; d=google.com; s=arc-20160816; b=kQV/G9BFQaulROyjOe885RNtpKrqF38+daoZHgQcl1pM55g4vXzi3IWNpR6trkgnSU LM9Mi0d4zlMrOYmCHnME2zeSoFDdpWeiXVTKfih3DiJe5Mk0tuRLoIMM6w5EiXAh3Ik8 2rT8kGB95kzKH4/OqY+n6gC7Vi2BA/AJbRFdNIL5fNmrBpYe+Gn216Xn9GiSEFpGgOo1 khbrIvT9/z5GoGVoU45Wt2F4nfiZIM7qc01fz+7nSsUjPDeIcxiwNUEOO4CmCBuuhdeH rHXAa9ubPABq9NqMn3LjdHUiAkLMOsBVO3nbx7qwLHebfEhQqkh42lnl4OW9vDy35lnN Nikw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=k5G77k0j63/1dHq8s2sfTu2vMdGLfH/hNCHXcpdGXNs=; b=Px7vSqTs6xtxJVrDaBY3UqI4ddyFjJKYEuy3dl5QE2pRvGkSjqbIVACVn59rMV/C1v rKPv3L4xIHoDugEs1zI60suMGnHinbnBjeQ8efPekhci75TCfR8fGEyG0fY8idcnrOIL +TfgoKLcS/QCikEeN1tOrgFWAELqRHS8mD/kcGZWUDf7enh7rnBjiHmaQz60jyVavX6b Gtc/iOHpQPv6yzBUbiihEI/CmNRG1vKDdeCjb7DdMz3c5BC67V3xPHKnu7V1Uj/rKcu2 nJUJyNy2KN+ACtJ8C74i3Yjk+TcWEMuKeoPTsb11d3yiN99jlsLdGQLQyt3wjlOA3X9t I9nQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZivuuU5W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6si1738277pfe.21.2019.06.06.04.54.28; Thu, 06 Jun 2019 04:54:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZivuuU5W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727563AbfFFI7B (ORCPT + 99 others); Thu, 6 Jun 2019 04:59:01 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:38691 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727458AbfFFI7A (ORCPT ); Thu, 6 Jun 2019 04:59:00 -0400 Received: by mail-it1-f196.google.com with SMTP id h9so1930306itk.3 for ; Thu, 06 Jun 2019 01:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k5G77k0j63/1dHq8s2sfTu2vMdGLfH/hNCHXcpdGXNs=; b=ZivuuU5W7ouwon2oensR1KO0lnkteogDIK19A1X47Zoe4snPwL4k8a1t5bMf+dLWtT VOolVZmdsbxr315riQpfgCTO9M+BvJkRcvx5Auo/80TgV0IhCbWvFr4sFhIGt5pUCR7p i87b/pz4u4Yr9UP4seBZ2JGEhaw0pLTuN8ocfr/jIWeSd8lpqqKt2h1mjpI1Ynfp2UNC VzR74ww2NeTIOGWs/UfvQLSaHJqdZ/zTI/r8bMHgyGx+cy9FxUNYzVH01iD8Idkz84l3 /CRfUU2sfdy/GaQ2TCjNTb/MicRZ9JXaVGcI2tM9o7JlFVeYo7uhrw3d0WAbGh1nRi/7 ODlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k5G77k0j63/1dHq8s2sfTu2vMdGLfH/hNCHXcpdGXNs=; b=tb+9NUvK12TswCDdWiRJQG3drajBaqy3jSjcQTX2HdZziIE08yNp6Cx2slWht+Ot5y 7WIQQbwNqG5uN/O79TB5hAI92WgofET/WGVezLwzoqGyuDUKmVY4hkbq7p7fI9DLvstX uHJo27bTK1AztzInLWR1SNFPVTpIBfLlT/zdOoMIZnJl8Rr9873tthLqwKTY6XzBHgMI 1xcnWXrHJwMBT0NA4pae78ue5nOWhbthFftBKfwzs9gy8PZjwWPMPtILCAhPA3GBwYli MqEzvvYXfhKKWaXFxHBNkp0bVuPHcdMud31T4RckH1Eedw967QSGVMwYQm9bPr+1XDuH 03ug== X-Gm-Message-State: APjAAAXly1+fmdiAyPXZAqFbJjq+xYrBQwaN926Tsu5rKwIISRQpwG3V mUssn45tDBacii15QJvoF+5VbTzAkUh3TY67deFaOw== X-Received: by 2002:a24:740f:: with SMTP id o15mr14731071itc.76.1559811539672; Thu, 06 Jun 2019 01:58:59 -0700 (PDT) MIME-Version: 1.0 References: <779905244.a0lJJiZRjM@devpool35> <20190605162626.GA31164@kroah.com> <20190606070807.GA17985@kroah.com> In-Reply-To: <20190606070807.GA17985@kroah.com> From: Ard Biesheuvel Date: Thu, 6 Jun 2019 10:58:45 +0200 Message-ID: Subject: Re: Building arm64 EFI stub with -fpie breaks build of 4.9.x (undefined reference to `__efistub__GLOBAL_OFFSET_TABLE_') To: Greg KH Cc: Nick Desaulniers , Rolf Eike Beer , Linus Torvalds , Matt Fleming , Peter Zijlstra , Thomas Gleixner , linux-efi , Linux Kernel Developers List , stable , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Jun 2019 at 09:08, Greg KH wrote: > > On Thu, Jun 06, 2019 at 08:55:29AM +0200, Ard Biesheuvel wrote: > > On Wed, 5 Jun 2019 at 22:48, Nick Desaulniers wrote: > > > > > > On Wed, Jun 5, 2019 at 11:42 AM Ard Biesheuvel > > > wrote: > > > > For the record, this is an example of why I think backporting those > > > > clang enablement patches is a bad idea. > > > > > > There's always a risk involved with backports of any kind; more CI > > > coverage can help us mitigate some of these risks in an automated > > > fashion before we get user reports like this. I meet with the > > > KernelCI folks weekly, so I'll double check on the coverage of the > > > stable tree's branches. The 0day folks are also very responsive and > > > I've spoken with them a few times, so I'll try to get to the bottom of > > > why this wasn't reported by either of those. > > > > > > Also, these patches help keep Android, CrOS, and Google internal > > > production kernels closer to their upstream sources. > > > > > > > We can't actually build those > > > > kernels with clang, can we? So what is the point? > > > > > > Here's last night's build: > > > https://travis-ci.com/ClangBuiltLinux/continuous-integration/builds/114388434 > > > > > > > If you are saying that plain upstream 4.9-stable defconfig can be > > built with Clang, then I am pleasantly surprised. > > I know some specific configs can, there's no rule that I know of that > 'defconfig' support is required. But then again, it might also work, > try it and see :) > Well, it is the rule that the arm64 maintainers use. > > > Also, Android and CrOS have shipped X million devices w/ 4.9 kernels > > > built with Clang. I think this number will grow at least one order of > > > magnitude imminently. > > > > > > > I know that (since you keep reminding me :-)), but obviously, Google > > does not care about changes that regress GCC support. > > What are you talking about? Bugs happen all the time, what specifically > did "Google" do to break gcc support? If you are referring to this > patch, and it is a regression, of course I will revert it. But note > that gcc and 4.9 works just fine for all of the other users right now, > remember we do do a lot of testing of these releases. > Don't get me wrong: I am not blaming Google for this. But having strict Documented/ stable-rules, violating them by backporting patches that are clearly not bug fixes, and *then* saying 'bugs happen all the time' makes no sense to me at all.