Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 6 Jun 2019 15:15:02 +0200
From:   Pavel Machek <pavel@denx.de>
To:     pavel@ucw.cz
Cc:     linux-kernel@vger.kernel.org,
        Andrea Merello <andrea.merello@gmail.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.19 163/276] mmc: core: make pwrseq_emmc (partially)
 support sleepy GPIO controllers
Message-ID: <20190606131502.GF27432@amd>
References: <20190530030523.133519668@linuxfoundation.org>
 <20190530030535.648236068@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="Mjqg7Yu+0hL22rav"
Content-Disposition: inline
In-Reply-To: <20190530030535.648236068@linuxfoundation.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--Mjqg7Yu+0hL22rav
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

(stable removed from cc list)

>  static void mmc_pwrseq_emmc_reset(struct mmc_host *host)
>  {
>  	struct mmc_pwrseq_emmc *pwrseq =3D  to_pwrseq_emmc(host->pwrseq);
> =20
> -	__mmc_pwrseq_emmc_reset(pwrseq);
> +	gpiod_set_value_cansleep(pwrseq->reset_gpio, 1);
> +	udelay(1);
> +	gpiod_set_value_cansleep(pwrseq->reset_gpio, 0);
> +	udelay(200);
>  }
> =20

If we can sleep here, does it make sense to use *sleep() here?

Best regards,
									Pavel
--=20
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo=
g.html

--Mjqg7Yu+0hL22rav
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlz5EdYACgkQMOfwapXb+vI73QCcD0/77UA1q37UoIEdouGVsb1F
apYAnjysBsjTTVLIGvh1hy1Eoe4h/vGX
=xIuN
-----END PGP SIGNATURE-----

--Mjqg7Yu+0hL22rav--