Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp8125601ybi; Thu, 6 Jun 2019 07:09:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzlh+N/cBWjmr3zRtP8OcmmhfS9+DaZ11b/5jP7SS9FsjtARVwgCgb/NFhgvdOjbWi/9PtY X-Received: by 2002:a62:6844:: with SMTP id d65mr53681590pfc.175.1559830139910; Thu, 06 Jun 2019 07:08:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559830139; cv=none; d=google.com; s=arc-20160816; b=HDzl6ajjS4NDeJpMvE91CtQtjbAr+5F1IMP9B9d2H4NhRAw5Xzc46bFF+jM1ET+2g1 puy7mS4gxbvVwx9J+1Ve3+4BAEcLor6kEutKNhZJCivHofhnJbWMBVKA5IzVZS4Y+xCV BIhL2sLKmp9LaF/aRW2JEojZIaNFPV78jcyNVSOFfcLQaI+p+OrOaPRQsWNMZk90by/R B6nkD0bX0AC5Xg3tAvVPBISLmIgSo0Qv5Yn11qZoHlglD0qh8M2QXNlubb9j7NPo4O0u pgmul9Pu9PF8oucE2xUYRUnsbm+1JlEd4a7W+8+3ILE8Gw0W2iIlgZ9WdhrUFWg1F0Yo wk4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-transfer-encoding :content-id:mime-version:comments:references:in-reply-to:subject:cc :to:from:dkim-signature; bh=Cyx8E24aaWuAJPRyqX/wIlKlF5BLIhZSkSyqcx5lpvY=; b=UW2X6+wmQA3hT63Uwc5Rh1ESMVKQrsA8Y/Uj/0GVWFsKb8g2sqPVo9M57JYDkoiVae Pz0d2m62OA5E+uNm8peBptXvM8mP54D2LZHttuc5rZJYb+tm3l95LE4Xu2FtdX1zl89p PlBsd+n7Z8gjTV0tv614zMeLrG9UBD31MwB1mboCAZ82lbPnKRZVX/CM2ruG17PbezRy lfHV3d+edr5GzSRcf8+JnjWvB/nV2BuusypXWwXTV6B+a5AsCtVrT5JAIRsPaU9x6bQ/ HeSamUo5jyXJFUIJwL9F4J4zCH8D6JwIDo4ok/YIZkeYQNtH45RrkcPBduD01/XjF6dM DOgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@ccbib.org header.s=201902 header.b=Xfkl4O7w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z30si2195067pga.363.2019.06.06.07.08.42; Thu, 06 Jun 2019 07:08:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@ccbib.org header.s=201902 header.b=Xfkl4O7w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727961AbfFFOHD (ORCPT + 99 others); Thu, 6 Jun 2019 10:07:03 -0400 Received: from h1.radempa.de ([176.9.142.194]:35084 "EHLO mail.cosmopool.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbfFFOHD (ORCPT ); Thu, 6 Jun 2019 10:07:03 -0400 X-Greylist: delayed 446 seconds by postgrey-1.27 at vger.kernel.org; Thu, 06 Jun 2019 10:07:00 EDT Received: from localhost (localhost [127.0.0.1]) by mail.cosmopool.net (Postfix) with ESMTP id 0B80890FE45; Thu, 6 Jun 2019 15:59:33 +0200 (CEST) Received: from mail.cosmopool.net ([127.0.0.1]) by localhost (mail.b.radempa.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t6ScGfx02b-c; Thu, 6 Jun 2019 15:59:32 +0200 (CEST) Received: from stardust.g4.wien.funkfeuer.at (77.117.149.20.wireless.dyn.drei.com [77.117.149.20]) by mail.cosmopool.net (Postfix) with ESMTPSA id 513A190213F; Thu, 6 Jun 2019 15:59:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ccbib.org; s=201902; t=1559829572; bh=yRX2r+1exJu+xt6035zadTL1ALZUnRaTg/CjqI7wAzk=; h=From:To:cc:Subject:In-reply-to:References:Date:From; b=Xfkl4O7wX3W5m8UlC0jDHhFkqAU2BvG0QxydrPbS9pMTSjHknn5s/c1SBTbtruCcq coWAmuJr1yuOJaqZowoulZ4CcLBNmsNeCqUBUAZ7PircVahSQsVhWKIyeT5tBQ5436 fIYEpSYrT8cO2D3AnUl0hF34wAuI64BKWaKomt8Y= Received: from lambda by stardust.g4.wien.funkfeuer.at with local (Exim 4.89) (envelope-from ) id 1hYsvP-0000PY-Pz; Thu, 06 Jun 2019 15:59:27 +0200 From: Harald Geyer To: Maxime Ripard cc: Torsten Duwe , Vasily Khoruzhick , Chen-Yu Tsai , Rob Herring , Mark Rutland , Thierry Reding , David Airlie , Daniel Vetter , Andrzej Hajda , Laurent Pinchart , Icenowy Zheng , Sean Paul , Greg Kroah-Hartman , Thomas Gleixner , dri-devel , devicetree , arm-linux , linux-kernel Subject: Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I In-reply-to: <20190605120237.ekmytfxcwbjaqy3x@flea> References: <20190604122150.29D6468B05@newverein.lst.de> <20190604122308.98D4868B20@newverein.lst.de> <20190605101317.GA9345@lst.de> <20190605120237.ekmytfxcwbjaqy3x@flea> Comments: In-reply-to Maxime Ripard message dated "Wed, 05 Jun 2019 14:02:37 +0200." MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1582.1559829566.1@stardust.g4.wien.funkfeuer.at> Content-Transfer-Encoding: quoted-printable Date: Thu, 06 Jun 2019 15:59:27 +0200 Message-Id: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guys, this discussion is getting heated for no reason. Let's put personal frustrations aside and discuss the issue on its merits: Maxime Ripard writes: > On Wed, Jun 05, 2019 at 12:13:17PM +0200, Torsten Duwe wrote: > > On Tue, Jun 04, 2019 at 08:08:40AM -0700, Vasily Khoruzhick wrote: > > > On Tue, Jun 4, 2019 at 5:23 AM Torsten Duwe wrote: > > > > > > > > Teres-I has an anx6345 bridge connected to the RGB666 LCD output, = and > > > > the I2C controlling signals are connected to I2C0 bus. eDP output = goes > > > > to an Innolux N116BGE panel. > > > > > > > > Enable it in the device tree. > > > > > > > > Signed-off-by: Icenowy Zheng > > > > Signed-off-by: Torsten Duwe > > > > --- > > > > .../boot/dts/allwinner/sun50i-a64-teres-i.dts | 65 +++++++++= +++++++++++-- > > > > 1 file changed, 61 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts = b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > > > > index 0ec46b969a75..a0ad438b037f 100644 > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > > > > @@ -65,6 +65,21 @@ > > > > }; > > > > }; > > > > > > > > + panel: panel { > > > > + compatible =3D"innolux,n116bge", "simple-panel"; > > > > > > It's still "simple-panel". I believe I already mentioned that Rob > > > asked it to be edp-connector. Actually just dropping the "simple-panel" compatible would be a poor choice. Even if "edp-connector" is specified as binding and implemented in= a driver, there are older kernel versions and other operating systems to keep in mind. If the HW works with "simple-panel" driver satisfactorily, we should definitely keep the compatible as a fall back for cases where the edp-connector driver is unavailable. If think valid compatible properties would be: compatible =3D "innolux,n116bge", "simple-panel"; compatible =3D "edp-connector", "simple-panel"; compatible =3D "innolux,n116bge", "edp-connector", "simple-panel"; compatible =3D "edp-connector", "innolux,n116bge", "simple-panel"; I can't make up my mind which one I prefere. However neither of these variants requires actually implmenting an edp-connector driver. And each of these variants is clearly preferable to shipping DTs without description of the panel at all and complies with bindings after adding a stub for "edp-connector". > And the DT is considered an ABI, so yeah, we will witheld everything > that doesn't fit what we would like. I fail to see how the patch in discussion adds new ABI. While I understand the need to pester contributors for more work, outright blocking DTs, that properly describe the HW and comply with existing bindings, seems a bit unreasonable. (Assuming there are no other issues of course.) Also note that the innolux,n116bge binding suggestes using simple-panel as fallback. HTH, Harald -- = If you want to support my work: see http://friends.ccbib.org/harald/supporting/ or donate via CLAM to xASPBtezLNqj4cUe8MT5nZjthRSEjrRQXN or via peercoin to P98LRdhit3gZbHDBe7ta5jtXrMJUms4p7w